Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYVyH-0001AG-7f for pgadmin-hackers@arkaria.postgresql.org; Thu, 28 Jun 2018 12:24:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYVyE-0005vD-Qp for pgadmin-hackers@arkaria.postgresql.org; Thu, 28 Jun 2018 12:24:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYVyE-0005uj-If for pgadmin-hackers@lists.postgresql.org; Thu, 28 Jun 2018 12:24:18 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYVyA-0004P0-RU for pgadmin-hackers@postgresql.org; Thu, 28 Jun 2018 12:24:16 +0000 Received: by mail-wr0-x244.google.com with SMTP id a12-v6so5327351wro.1 for ; Thu, 28 Jun 2018 05:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Tn8Xtm0fPpalpzcNMQ3ePCUHkQcSXXKc+P/MXcfLIFI=; b=X0ZhBlOXtM6h0hyXiS7gqvhASWpJBlTU7zyTlu3BTMMAhHL0Ht61SpLULlr7EJhJwQ Lsc3dAsdccR81aHbU5gvqOi4NL5WcTDbmC67VEKpxPU6V5bvBxURR7OoMw924uN7sv6n CK/3RQa9WShPIQuDUdcOEXf/uahwSzyGlZ+dlZybl771IRvI1DnJf32H1Msd0CI1CP7c GvbwsW3e7743a1xRZMYMWeLyTXqXpRCJgMGgkNCO4yWLHcFk/cM3fB/fMAaly8UnYdag TLekDkXd942IrkCUXlBISD5ZDMsSP7Nh8xWTc3tBAM7/jGQ2fjqbCfhTOuZWK3e8w+hl rCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Tn8Xtm0fPpalpzcNMQ3ePCUHkQcSXXKc+P/MXcfLIFI=; b=G8jaVt10XpLW4i9MAofT3+hCI3A67ck28cUWRy+2fW2bRfrlvsq2/ZUa/tVVZTJFcO O6Ng7nuCqK9ALPt/WhiNFK+YATSxZaAaIwWBAwCopbjS3YlmgzCACjRlFMVPnrY8bvoy Gdv89tTuRNs2i2Vu34Ojo103LZqfjpsfGQdH88MVtoqrumQecWhk/Njxe5Th5sAece1f Pz++NgViRb9eML1o/vLyXQPNeZ5P2T8HmYtUGCQi/qXjfKrXc7fbuYhXPSNR/gxTt5An TE22SAEc7200ln6qKBONCuYW1WErFEm9yRh7pytcajt+0JcksRIgsHMdUxnUzVeByH/7 zzsw== X-Gm-Message-State: APt69E1oLOcQzW3yRvjblzUD5OUdwgOvgqsCs1yR6pClUokub2RtIjxx ahlenz516ZrGqXVf33DMkhM1tHypYfrlyK7SAgHgiw== X-Google-Smtp-Source: AAOMgpc3hqxuZ6VpsllPzJm+96IDo7sEdw636yyt5t/szN5elaLCsUBztfJTONEjNhJD2ogi1n++7e1Qa7GIQSSycFo= X-Received: by 2002:adf:e590:: with SMTP id l16-v6mr8114453wrm.190.1530188653264; Thu, 28 Jun 2018 05:24:13 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 05:24:12 -0700 (PDT) In-Reply-To: <20180628114706.GB32048@msg.df7cb.de> References: <20180626192819.GA32582@msg.df7cb.de> <20180628114706.GB32048@msg.df7cb.de> From: Dave Page Date: Thu, 28 Jun 2018 13:24:12 +0100 Message-ID: Subject: Re: pgAdmin v3.1 candidate builds and source... To: Christoph Berg Cc: Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001e16f6056fb2cfcd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001e16f6056fb2cfcd Content-Type: text/plain; charset="UTF-8" Hi On Thu, Jun 28, 2018 at 12:47 PM, Christoph Berg wrote: > Re: Dave Page 2018-06-27 NsR84Xw@mail.gmail.com> > > On Tue, Jun 26, 2018 at 8:28 PM, Christoph Berg wrote: > > > > > Re: Dave Page 2018-06-26 > > RD6QNxA5ynH-X+-rPN7jA@mail.gmail.com> > > > > ... can be found at https://developer.pgadmin.org/ > builds/2018-06-26-3.1/ > > > > and dpage/pgadmin4:2018-06-26-3.1 on Docker Hub. > > > > > > > > Fahar; please verify for release on Thursday. > > > > > > > > Note that these are the first builds from the new fully automated > build > > > > system, and both the Windows and Mac versions now use Python 3, so > please > > > > be sure to test with extra care! > > > > > > Hmm, ModuleNotFoundError: No module named 'sshtunnel' > > > > > > Could you perhaps announce new versions that need new python modules a > > > bit earlier, so we have time to package them? > > > > > > > Good point. Not entirely sure how the mechanics of that would work, given > > that we're trying to shorten release cycles down to a couple of weeks > > (ideally). > > Just drop a note "hey we've added $module" once a non-standard > dependency is added. > Yeah - it's the remembering to do that that is the issue. > > > That said, for all other builds we're giving up trying to maintain Python > > packages. Instead, we're going to be shipping a pre-built Python venv as > > part of the package, built using Python 3.6. Whilst it's not perfect > from a > > "following the packaging rules" perspective, in other cases we're having > to > > install modules privately for pgAdmin anyway to avoid conflicts with > older, > > vendor supplied versions, so it's really just a different evil rather > than > > a new one. > > I'm not going to "pip install" or whatever from the build system. > OK, that's up to you. > > That said, the web/pgadmin/static/*/generated/ directories have > disappeared from the tarball, so pgadmin doesn't load anymore. Could > you please put them back, as I don't think rebuilding them via yarn is > feasible? Because that's not packaged either... > OK, please go grab the tarball again, from thttps://www.postgresql.org/ ftp/pgadmin/pgadmin4/v3.1/source/. The MD5 checksum should be: f057bf46055d4f7b07a42ae984f499dd pgadmin4-3.1.tar.gz This should contain the missing files. Sorry about that - stupid case-sensitivity bug in a script :-( -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000001e16f6056fb2cfcd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Jun 28, 2018 at 12:47 PM, Christoph Berg &l= t;myon@debian.org&= gt; wrote:
Re: Dave Page 2018-06-2= 7 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyX= NsR84Xw@mail.gmail.com>
> On Tue, Jun 26, 2018 at 8:28 PM, Christoph Berg <<= a href=3D"mailto:myon@debian.org">myon@debian.org> wrote:
>
> > Re: Dave Page 2018-06-26 <CA+OCxow1BDDXK9K1d-pnSAoBE5O=3D= +
> > RD6QNxA= 5ynH-X+-rPN7jA@mail.gmail.com>
> > > ... can be found at https://devel= oper.pgadmin.org/builds/2018-06-26-3.1/
> > > and dpage/pgadmin4:2018-06-26-3.1 on Docker Hub.
> > >
> > > Fahar; please verify for release on Thursday.
> > >
> > > Note that these are the first builds from the new fully auto= mated build
> > > system, and both the Windows and Mac versions now use Python= 3, so please
> > > be sure to test with extra care!
> >
> > Hmm, ModuleNotFoundError: No module named 'sshtunnel'
> >
> > Could you perhaps announce new versions that need new python modu= les a
> > bit earlier, so we have time to package them?
> >
>
> Good point. Not entirely sure how the mechanics of that would work, gi= ven
> that we're trying to shorten release cycles down to a couple of we= eks
> (ideally).

Just drop a note "hey we've added $module" once a non-= standard
dependency is added.

Yeah - it's th= e remembering to do that that is the issue.
=C2=A0

> That said, for all other builds we're giving up trying to maintain= Python
> packages. Instead, we're going to be shipping a pre-built Python v= env as
> part of the package, built using Python 3.6. Whilst it's not perfe= ct from a
> "following the packaging rules" perspective, in other cases = we're having to
> install modules privately for pgAdmin anyway to avoid conflicts with o= lder,
> vendor supplied versions, so it's really just a different evil rat= her than
> a new one.

I'm not going to "pip install" or whatever from the bu= ild system.

OK, that's up to you.
=C2=A0

That said, the web/pgadmin/static/*/generated/ directories have
disappeared from the tarball, so pgadmin doesn't load anymore. Could you please put them back, as I don't think rebuilding them via yarn is<= br> feasible? Because that's not packaged either...

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company
--0000000000001e16f6056fb2cfcd--