MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZSas8Chx0neZqpvFwSBPE1JDwF=afbvP3aptfF578Xhxw@mail.gmail.com>
References: 
 <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
 <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
 <CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
 <CAKKotZRwaG6X-9ZZ3+CCMQ0y=h7kTR_ver=QfWf6savrjtbF3A@mail.gmail.com>
 <CAKKotZSas8Chx0neZqpvFwSBPE1JDwF=afbvP3aptfF578Xhxw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 7 Mar 2018 16:29:25 +0000
Message-ID: 
 <CA+OCxoywkaEX7VL-4G_p=DeLAFyWmSAOGGd+JOMNQ-bew1_eMg@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a114b3cd405c3eb0566d510bd"
Precedence: bulk

--001a114b3cd405c3eb0566d510bd
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
>
Using your example on the ticket, I added a "character varying (32)" column
with NOT NULL to the table. When I then edit the column, and turn off NOT
NULL (making no other changes), the SQL generated is:

ALTER TABLE public.test_drop
    ALTER COLUMN col2 TYPE character varying (32) COLLATE
pg_catalog."default";
ALTER TABLE public.test_drop
    ALTER COLUMN col2 DROP NOT NULL;

I didn't see that when turning off NOT NULL for col1.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114b3cd405c3eb0566d510bd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <span dir=3D"ltr">&=
lt;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">=
murtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div style=3D"font-fami=
ly:verdana,sans-serif;color:rgb(68,68,68)">Hi Dave,</div><div style=3D"font=
-family:verdana,sans-serif;color:rgb(68,68,68)"><br></div><div style=3D"fon=
t-family:verdana,sans-serif;color:rgb(68,68,68)">PFA updated patch.</div></=
div><div class=3D"gmail_extra"><br></div></blockquote><div><br></div><div>U=
sing your example on the ticket, I added a &quot;character varying (32)&quo=
t; column with NOT NULL to the table. When I then edit the column, and turn=
 off NOT NULL (making no other changes), the SQL generated is:</div><div><b=
r></div><div><div>ALTER TABLE public.test_drop</div><div>=C2=A0 =C2=A0 ALTE=
R COLUMN col2 TYPE character varying (32) COLLATE pg_catalog.&quot;default&=
quot;;</div><div>ALTER TABLE public.test_drop</div><div>=C2=A0 =C2=A0 ALTER=
 COLUMN col2 DROP NOT NULL;</div></div><div><br></div><div>I didn&#39;t see=
 that when turning off NOT NULL for col1.</div></div><div><br></div>-- <br>=
<div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake=
.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter=
: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" =
target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Postgre=
SQL Company<br></div>
</div></div>

--001a114b3cd405c3eb0566d510bd--