MIME-Version: 1.0
References: 
 <CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_mBN5ZYxTZ2wcWuJ6RLvsffG+iha9Zb8bRJok=-cuNZ7w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 10 Jan 2019 11:53:05 +0530
Message-ID: 
 <CA+OCxoywzbQ9NPAhgDUfSkDvSnfxogkg8dadU+JeRFK5GnCg=Q@mail.gmail.com>
Subject: Re: [pgAdmin4][RM3575] Right click does not work on database node if
 server name changed
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks - patch applied.

On Wed, Jan 9, 2019 at 4:16 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix the issue where changing the name (or any vi=
sible property on tree) of the server node breaks the context menu on the d=
atabase nodes.
>
> The user information of the server is updated on successful connection. H=
ere, the data is updated on the aciTreeNode(domNode). But, in the context m=
enu the user data is referred from TreeNode object (a wrapper to aciTreeNod=
e). After checking the code (and a lot of debugging) it was found that aciT=
reeNode and TreeNode point to two different data(I don't know why). Every t=
ime you change one, it should be synced to other, which is not done everywh=
ere.
> Changes are done to point both aciTreeNode and TreeNode data to the same =
data object.
>
> Kindly review.
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"


--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company