MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZTk6yj5T8VvKRyqK0_Q__O8L-fpFoqQh3E3J+MyhBz25g@mail.gmail.com>
References: 
 <CAKKotZTk6yj5T8VvKRyqK0_Q__O8L-fpFoqQh3E3J+MyhBz25g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 26 May 2017 11:05:16 -0400
Message-ID: 
 <CA+OCxoyxGj_fyAnjCaQPLcNkP=79e=krJE=PmsYn9aHT5Y761g@mail.gmail.com>
Subject: Re: [pgAdmin4] [PATCH] To fix issue in UPDATE
 Script and Primary key order when view data
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, patch applied (and bugs created for the other two issues).

On Fri, May 26, 2017 at 6:12 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in table node,
> 1) In 'UPDATE Script', '?' is missing with last column.
> 2) If there are multiple primary keys in table then the order of columns is
> incorrect in view data ORDER BY clause.
> RM#2417
>
> Also fixed minor issue in Materialized view which I found during testing, we
> were not passing database id in properties.sql which is required for Select
> and Insert script to work.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers