Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goRPz-00048c-OS for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 11:19:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goRPv-0003Py-Jh for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jan 2019 11:18:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goRPv-0003Pq-Ar for pgadmin-hackers@lists.postgresql.org; Tue, 29 Jan 2019 11:18:59 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goRPs-0000BP-0I for pgadmin-hackers@postgresql.org; Tue, 29 Jan 2019 11:18:57 +0000 Received: by mail-wr1-x444.google.com with SMTP id v13so21555956wrw.5 for ; Tue, 29 Jan 2019 03:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cGlCSC0L5TgaowNCXcORmmLuDVIyCT4MoMNVctibUB4=; b=PIOWWehGABKxQXsat6dXUpR1blJ23AUBDdKA4cvBXyJYNCtnJ0LEriD1YQXfmvt1Am FjcDi+Sju3d4UB+lvccoeMHwEG5Wu971ynn4edkKQX0xgUdUoqvrSrIDe53PwUo1v+uH i71nprkNWbMUN4e5DFezIUI3koyzXKemi0dLEKjRxQpiNWsZZAj1Szd1ljHTpdIMS2rs mhNv+HcmdI5JliuwPYupuC83ekEglWHBQalZ51f5gI4BO+FUfvWMHizbJ87K8TT1er+F vwFL4yr9IoLR6Wt/X1d2GpBFZ3himal9188uhq3uOZ8qePpSvIA+l0TVl4zPOEZaD3XN xrog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cGlCSC0L5TgaowNCXcORmmLuDVIyCT4MoMNVctibUB4=; b=qiP1ueJULuQx0W/hz0/uf95GIa1t2ogBKEplgqEFn1Jj9L0QCPfDxWHcVTunegx5Ik Ik6yhfTJ2oZhpWh2jK4aNjLi2fYm6elF0AQYLiSoxTJYIEFR/0Gna17NFQDrNrFr1vYb lZpCNKiy/SCzALdmZV5QWs4AS2OL2gxyudRzubpPa6uXnaoG7zxaB3JW+IorkvGU73b8 N2HETsdcFiqZz6FyTtMRc1whZ8H1qzkysr4VJF7/a7bwVCM1aDXQqiqhOTMMDo0DPX0G 8pvhNf83d6Hqb2+R4YLEbSkMDElDMxfBImiqe2ZlqeKkbV/JhSSEldanFoQMpNXhbnsW E8jQ== X-Gm-Message-State: AJcUukddgP2/sd1ImYxUxMnggOQkUMLX9ybIVmqiksVQTQHwVNS41eaX 5D4R+DXZw+r5SufRC3YTAu+zDBu7mCp/zgJQS+hIbS4AX/8= X-Google-Smtp-Source: ALg8bN4UnSJoFF6ekI5boPSGuKJaIT2TqGa/krU0PuQMnmvoQPE8o98oACYh/7bhEp/rn68lnGN1ZNWAdlR6Him0LG4= X-Received: by 2002:a5d:4a8e:: with SMTP id o14mr24483531wrq.159.1548760733813; Tue, 29 Jan 2019 03:18:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 29 Jan 2019 11:18:42 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package To: Akshay Joshi Cc: pgadmin-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Khushboo, can you review this please? If you're happy with it, Akshay can commit. Thanks. On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi wrote: > > Hi Hackers, > > Attached is the patch to fix RM 3927 "Unable to debug the procedure inside package". Problem with the existing code is we assume that "PLDBGBREAK" will be always found in the first element of the notification list. > > In this patch we loop through the list and found the string. Apart from that patch contains small fix to cancel the transaction of Query Tool when panel is closed. > > Please review it. > > -- > Akshay Joshi > Sr. Software Architect > > > Phone: +91 20-3058-9517 > Mobile: +91 976-788-8246 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company