Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTOOy-00008v-7L for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jun 2018 09:18:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fTOOw-0005IK-H2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jun 2018 09:18:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTOOw-0005IA-2f for pgadmin-hackers@lists.postgresql.org; Thu, 14 Jun 2018 09:18:42 +0000 Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fTOOn-0003iB-W0 for pgadmin-hackers@postgresql.org; Thu, 14 Jun 2018 09:18:40 +0000 Received: by mail-wr0-x22a.google.com with SMTP id v13-v6so5568892wrp.13 for ; Thu, 14 Jun 2018 02:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e/IBlD3MArV6KWUzvIApYIjBu5TOmjCYVcRD7lMyFbw=; b=sqXtWOS/CsJduCZ368hDtGQP+6bQlGC1UpVYXKJMTrRLtibKx9XGLnRXfn0P/u3T2W FMbCyxA1uxaiHjYZvhGsd1TW9dsAoKvDgqm0uT6mntlTbUogXnof3CeOCgeiItMKj99z T5nyLhFoeU0SQG+alNc01HyefGewfHD0FbR6NjpQWsPSoKJna6HZyxFpfE1t0LK9V9J/ VumjuFXvTnl8PqhK1Dh+UmcJ0X7GsuHMHFpkYBWS8V1d3SoutfNPTc9y4cANz01n+qxV 0vBFNa9NUpgiit2OUCEwc3MX1u364p7+uTB/EHXRP9rdyopVs2A+q7MPIJ1/VQd08vJb NQww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e/IBlD3MArV6KWUzvIApYIjBu5TOmjCYVcRD7lMyFbw=; b=kSeX95KoEW81m1shEUt0Lt45YyLVHP+bICoyGWrEu/D1EtZ043dFHfrxfWmY3r8aZU AYeyOiw5/7t3GnoxJKE7moA+WDFGJu3mBlb+k0wpRyD+mpOj2RbSNM+L1VmGo1hy6rSV 0RicB4y2+flY2u+wC3EU/6RNtjW9pPLNzbuF1rA8rOUYJiDgwnnf6LDf3dnTgfOJW7Fh T89EDD8Y5DSDHleeknNtedKiMFkS0QTRGyVNEbA5H//ZqVKd73ObgGl1qQxuOUjYmJ/C fIoQDrOPMUfhoOfJeqqgDx2LjJuf2OSWIZoF8fqDtQghqPsAPuPRNMnnLHLlxBxinXeQ PMiw== X-Gm-Message-State: APt69E04bDNL0PPZHviciggTjo82A+0LncYsOh/rxJuSnxrD265aqnYE eq7FT2jyxZ6xer+gwiqASB7SIu7BSC8cs/86kApHEw== X-Google-Smtp-Source: ADUXVKKZZfgnOpE19bipX7Cebw74AO0IgnEh+M/BqaBfaVFT1SIfXTW4ZY9fjVe2iwwh2FQgE6SaxokiUQKBB0igoXU= X-Received: by 2002:adf:9950:: with SMTP id x74-v6mr1361713wrb.135.1528967912117; Thu, 14 Jun 2018 02:18:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 02:18:31 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 14 Jun 2018 10:18:31 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000466da4056e96951e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000466da4056e96951e Content-Type: text/plain; charset="UTF-8" On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi < akshay.joshi@enterprisedb.com> wrote: > > > On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for the Feature #2686 Property to switch >>> lower/upper case auto completion. I have added new preferences settings >>> "Keywords in uppercase" if it is set to True then all the keywords are >>> shown in upper case in auto completion. >>> >>> I have also implemented the second request in the RM to change the >>> selected text to upper/lower case. For that I have added new keyboard >>> shortcut "Toggle case of selected text" in preferences dialog. Default >>> key is "Ctrl + Shift + u". >>> >>> Please review it. >>> >> >> I don't see any doc updates in the patch - seems like that was forgotten? >> > > You mean to say ".rst" files? If yes, then sorry I forgot to update > that. Will do it and send the modified patch. > Yes (and any screenshots). Thanks. > >> Any opportunities to re-factor the code in that area into more testable >> functions? >> > > I have modified the files which are already re-factored. I haven't > seen any logic that can be re-factored. > Great, thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000466da4056e96951e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:


On Thu, Jun 14, 2018 at 1:14 PM, Dave Page <dpage@p= gadmin.org> wrote:
Hi

On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch = for the Feature=C2=A0#2686 Property to switch lower/upper case auto complet= ion. I have added new preferences settings "Keywords in uppercase"= ; if it is set to True then all the keywords are shown in upper case in aut= o completion.

I have also implemented the second r= equest in the RM to change the selected text to upper/lower case. For that = I have added new keyboard shortcut "Toggle case of selected text"= in preferences dialog. Default key is "Ctrl<= /span> + Shift + u".

Please review it.=C2=A0<= /div>

I don't see any doc = updates in the patch - seems like that was forgotten?

=C2=A0 =C2=A0 You mean to say &qu= ot;.rst" files? If yes, then sorry I forgot to update that. Will do it= and send the modified patch.=C2=A0

Yes (and any screenshots). Thanks.
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div class=3D"gmail_quote">
<= div dir=3D"ltr">
=
Any opportunities to re-factor the code in that area into mo= re testable functions?=C2=A0

<= /div>
=C2=A0 =C2=A0 I have modified the files which are already = re-factored. I haven't seen any logic that can be re-factored.=C2=A0 = =C2=A0

Great, thank= s.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company
--000000000000466da4056e96951e--