MIME-Version: 1.0
References: 
 <CAM9w-_=e8+iiEP0+pTv0htRHhUjupfK6N9dFS1wQNG6MBCq4Vw@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_=e8+iiEP0+pTv0htRHhUjupfK6N9dFS1wQNG6MBCq4Vw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 21 May 2019 13:02:29 +0100
Message-ID: 
 <CA+OCxoz+C3JKXMu2u7taYGSsSVAEQh20w2mDyxqLSKbbFq=21g@mail.gmail.com>
Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool
 (Accessibility)
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000392222058964a077"
Precedence: bulk

--000000000000392222058964a077
Content-Type: text/plain; charset="UTF-8"

Hi

On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the accessibility issue in query tool.
>
> The query tool can be completely restructured unlike previously where
> query tool used to stick at top and other tabs in the bottom.
> - I have added a new shortcut to switch between frames if in query tool
> the tab positions are changed. On switching the frames, the frame will
> blink to show it is focussed.
> - In the frame, you can switch tab same as previous. The tabs in SQL
> editor are cyclic now, which means if you execute shortcut to go right on
> the last tab then it will cycle to first tab.
> - I have also changed the default shortcut to switch between tabs from
> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
> browser tabs.
> - Similar changes done for debugger also.
>

Shouldn't there be documentation changes to go with this?

Otherwise, it seems to work :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000392222058964a077
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Tue, May 21, 2019 at 10:01 AM Aditya=
 Toshniwal &lt;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com" target=
=3D"_blank">aditya.toshniwal@enterprisedb.com</a>&gt; wrote:<br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div style=3D=
"font-family:verdana,sans-serif">Hi Hackers,<br clear=3D"all"></div><div st=
yle=3D"font-family:verdana,sans-serif"><br></div><div style=3D"font-family:=
verdana,sans-serif">Attached is the patch to fix the accessibility issue in=
 query tool.</div><div style=3D"font-family:verdana,sans-serif"><br></div><=
div style=3D"font-family:verdana,sans-serif">The query tool can be complete=
ly restructured unlike previously where query tool used to stick at top and=
 other tabs in the bottom.=C2=A0</div><div style=3D"font-family:verdana,san=
s-serif">- I have added a new shortcut to switch between frames if in query=
 tool the tab positions are changed. On switching the frames, the frame wil=
l blink to show it is focussed.=C2=A0</div><div style=3D"font-family:verdan=
a,sans-serif">- In the frame, you can switch tab same as previous. The tabs=
 in SQL editor are cyclic now, which means if you execute shortcut to go ri=
ght on the last tab then it will cycle to first tab.</div><div style=3D"fon=
t-family:verdana,sans-serif">- I have also changed the default shortcut to =
switch between tabs from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar=
 to what we have in browser tabs.</div><div style=3D"font-family:verdana,sa=
ns-serif">- Similar changes done for debugger also.</div></div></blockquote=
><div><br></div><div>Shouldn&#39;t there be documentation changes to go wit=
h this?=C2=A0</div><div><br></div><div>Otherwise, it seems to work :-)</div=
></div><div><br></div>-- <br><div dir=3D"ltr" class=3D"m_419703954789838517=
1gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com=
" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br=
><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_bl=
ank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<b=
r></div></div>

--000000000000392222058964a077--