MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELf1EwMw5dgPTfTp+50C5GOWmrC0bOmbYqZBCUKNay83VA@mail.gmail.com>
References: 
 <CAFOhELeqEBG3qd+Fe8nLfpc1SuJpkJzuzPmy1-jogD0220WiLw@mail.gmail.com>
	<CAFOhELfm9y9jQLLzvnQpKey5TX=yZkL+qaF=6g+CsvuWKFDh2w@mail.gmail.com>
	<CAFOhELekGKVKaMQt9L_itJw2WGdG69yVdiJDfq=1BPz3OjRJiw@mail.gmail.com>
	<CACCA4P0Q_9DBt43asNze9OjkJ+xya_m_cmf3DMoZB3HKWLKidw@mail.gmail.com>
	<CAFOhELf1EwMw5dgPTfTp+50C5GOWmrC0bOmbYqZBCUKNay83VA@mail.gmail.com>
Date: Wed, 4 May 2016 12:07:37 +0100
Message-ID: 
 <CA+OCxoz+LZ-PO--N6B-y6cecJ3QhCF9pOo7V-wJg_AUc9jcHUw@mail.gmail.com>
Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module
From: Dave Page <dave.page@enterprisedb.com>
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Wed, May 4, 2016 at 7:51 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
> In PG 9.5, for Foreign Table Editing, below new functionalities are added:
>
> ALTER [ COLUMN ] column_name SET STORAGE { PLAIN | EXTERNAL | EXTENDED |
> MAIN }
> DISABLE TRIGGER [ trigger_name | ALL | USER ]
> ENABLE TRIGGER [ trigger_name | ALL | USER ]
> ENABLE REPLICA TRIGGER trigger_name
> ENABLE ALWAYS TRIGGER trigger_name
> SET WITH OIDS
> SET WITHOUT OIDS
>
> As per our conversation yesterday, we need to incorporate these
> functionalities into pgAdmin4. Here I have some queries regarding the
> implementation. Under the Foreign Table Node, we don't have separate nodes
> for columns, triggers and constraints as table. So in order to add above
> Trigger related functionalities, we will have to add Trigger Node under the
> Foreign Table. And If we add Triggers, then Do we need to add Columns and
> Constraints as separate nodes under the Foreign Table?

Following discussion with Ashesh and some further thought, please put
these enhancements on hold. We'll add them in a future release, as
it's just too much work to do right now.

Please add a TODO file to the root directory of pgAdmin 4, and add
these as items for later completion.

Thanks.

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers