Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIaqG-0002zC-16 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Jun 2017 13:17:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dIaqF-0004fW-KK for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Jun 2017 13:17:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dIaq0-0003qW-Pg for pgadmin-hackers@postgresql.org; Wed, 07 Jun 2017 13:17:28 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dIapx-0008T3-F0 for pgadmin-hackers@postgresql.org; Wed, 07 Jun 2017 13:17:27 +0000 Received: by mail-io0-x22e.google.com with SMTP id y77so6656905ioe.3 for ; Wed, 07 Jun 2017 06:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=phccSUFDqoB5JBKWFAgQsCfJrKChzheyf9fI5s/huGA=; b=ZXxH7L+BR7/PCNewYrtXyTE/OR0NEr/NFQDBs5wrbRcdS0o0XkIu26vS0pwxUpRux0 wK55obTfEILXfWVg7aR2N76xaWRg0fbRql04pckWfSu6AfDFUFfLlfAQkVa+CWaw+Zyq gCU+P0MwzIrbMQooJhFCgsDsH8IfzXfmre4PxrnGyPclb5gCkd0T1oeVbxRPYMlbpiu6 duvyo0JKlqnBi8RVb23nGVCw+lrP9PjEHyU8Y7wQHdg4wsutWKIsbTVkujrOlBTvXnmS 66iUcZACO4Vvls+GQiaL4B9/sr6Zx0aKwc+nziyeqyUD3/VBhxkJlQIXgqUEiXz7NEG2 W83g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=phccSUFDqoB5JBKWFAgQsCfJrKChzheyf9fI5s/huGA=; b=Q4cX5cQQ0N+sBRCHgbEIfKyMvDHxOWGtqhBdEDp/cJMHeOJVMm1JbPMSipM7pJzDlk QBAErY6GH53GLinFkIypvkQQh+lOlLHh8xk+orNSvvYwRBWa0TDp+wwWvhBK0h90swrr kfth2xIhiCW+R4MU28LJtgpuTMhnT2ZtewjuDp8v14Mc4qwAXjIYhni58rgewMkRzU3a EZx1+Pu/j/prbWZeGtbZSn47CE05Wd3wCMVzpfX2hgTSn6W29aMHrvKsRtteV3f45DN+ 1+MzvabsjylT/H3+vJxV1L+EJmKGGYL87Ge9jhCpsSUcVGaMMu4uFArPpUnhGZTohweH y5PA== X-Gm-Message-State: AODbwcDPHI8Ilv/aS7h2c/XOCUL0bB9EUpyViIwx5Z+GCk/S6ngpF9cD DRYoMrapLPxaEYmT17FA9nJGwIIGmrg2 X-Received: by 10.107.175.95 with SMTP id y92mr5677252ioe.84.1496841444448; Wed, 07 Jun 2017 06:17:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.147 with HTTP; Wed, 7 Jun 2017 06:17:23 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 7 Jun 2017 14:17:23 +0100 Message-ID: Subject: Re: [PATCH] extract function from sqleditor To: George Gelashvili Cc: pgadmin-hackers Content-Type: text/plain; charset="UTF-8" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Mon, Jun 5, 2017 at 9:30 PM, George Gelashvili wrote: > Hello Hackers! > > Re. > https://www.postgresql.org/message-id/CAFS4TJb-7VTQQrnOi0g6MaoxMfEK9LzCds2yG%2BByS-mLHwydQA%40mail.gmail.com > > We extracted the function bound to onSelectedRangesChanged from sqleditor! > > - we read through the existing implementation and wrapped it in > `web/regression/javascript/selection/set_staged_rows_spec.js` > - we made some changes for clarity > > Thanks, > Joao and George > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers