public inbox for [email protected]help / color / mirror / Atom feed
Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 8+ messages / 3 participants [nested] [flat]
* Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." @ 2023-06-13 08:35 Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Akshay Joshi @ 2023-06-13 08:35 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers I have started the implementation for feature #6367 "DROP DATABASE can now take the option FORCE to drop a database even if other users are connected". For that, I figure out two places one in the Properties tab of the Databases collection node and the other in the context menu on the individual database node except the maintenance database. This feature will be available from PG 13 and above. Please refer to the screenshot below: [image: Properties.png] The 'Drop with Force' button is visible only on the Databases collection node. For other collection nodes, it is a 'Drop Cascade'. [image: Context Menu.png] Please review and let me know your thoughts. Is there any place where I can use this? -- Akshay Joshi Principal Software Architect www.enterprisedb.com *Blog*: https://www.enterprisedb.com/akshay-joshi *GitHub*: https://github.com/akshay-joshi *LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216 Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> @ 2023-06-13 09:20 ` Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Dave Page @ 2023-06-13 09:20 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers On Tue, 13 Jun 2023 at 09:36, Akshay Joshi <[email protected]> wrote: > Hi Hackers > > I have started the implementation for feature #6367 "DROP DATABASE can now > take the option FORCE to drop a database even if other users are connected". > > For that, I figure out two places one in the Properties tab of the > Databases collection node and the other in the context menu on the > individual database node except the maintenance database. This feature will > be available from PG 13 and above. Please refer to the screenshot below: > > [image: Properties.png] The 'Drop with Force' button is visible only on > the Databases collection node. For other collection nodes, it is a 'Drop > Cascade'. > Right, because CASCADE means drop dependent objects as well, but FORCE means disconnect connected users first. > > > [image: Context Menu.png] > > Please review and let me know your thoughts. Is there any place where I > can use this? > I'm not sure what you mean with your last question, but I think the wording needs some thought. Currently we have: Delete/Drop Drop Cascade Delete/Drop with Force I would suggest: Delete Delete (Cascade) Delete (Force) And we should probably re-order the menu to place those options together (and make sure the confirmation dialogues have appropriately matching text). -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> @ 2023-06-13 10:13 ` Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Akshay Joshi @ 2023-06-13 10:13 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: > > > On Tue, 13 Jun 2023 at 09:36, Akshay Joshi <[email protected]> > wrote: > >> Hi Hackers >> >> I have started the implementation for feature #6367 "DROP DATABASE can >> now take the option FORCE to drop a database even if other users are >> connected". >> >> For that, I figure out two places one in the Properties tab of the >> Databases collection node and the other in the context menu on the >> individual database node except the maintenance database. This feature will >> be available from PG 13 and above. Please refer to the screenshot below: >> >> [image: Properties.png] The 'Drop with Force' button is visible only >> on the Databases collection node. For other collection nodes, it is a 'Drop >> Cascade'. >> > > Right, because CASCADE means drop dependent objects as well, but FORCE > means disconnect connected users first. > > >> >> >> [image: Context Menu.png] >> >> Please review and let me know your thoughts. Is there any place where I >> can use this? >> > > I'm not sure what you mean with your last question, > I mean apart from the Properties tab and Context menu, do I need to implement DROP DATABASE...WITH (FORCE)? > but I think the wording needs some thought. Currently we have: > > Delete/Drop > Drop Cascade > Delete/Drop with Force > > I would suggest: > > Delete > Delete (Cascade) > Delete (Force) > > And we should probably re-order the menu to place those options together > (and make sure the confirmation dialogues have appropriately matching text). > I am not sure why we have used Delete/Drop, but for me, DROP seems appropriate as in the backend we used DROP Queries, so can we have Drop Drop (Cascade) Drop (Force) > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> @ 2023-06-13 10:19 ` Dave Page <[email protected]> 2023-06-13 10:29 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Dave Page @ 2023-06-13 10:19 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers On Tue, 13 Jun 2023 at 11:13, Akshay Joshi <[email protected]> wrote: > > > On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: > >> >> >> On Tue, 13 Jun 2023 at 09:36, Akshay Joshi <[email protected]> >> wrote: >> >>> Hi Hackers >>> >>> I have started the implementation for feature #6367 "DROP DATABASE can >>> now take the option FORCE to drop a database even if other users are >>> connected". >>> >>> For that, I figure out two places one in the Properties tab of the >>> Databases collection node and the other in the context menu on the >>> individual database node except the maintenance database. This feature will >>> be available from PG 13 and above. Please refer to the screenshot below: >>> >>> [image: Properties.png] The 'Drop with Force' button is visible only >>> on the Databases collection node. For other collection nodes, it is a 'Drop >>> Cascade'. >>> >> >> Right, because CASCADE means drop dependent objects as well, but FORCE >> means disconnect connected users first. >> >> >>> >>> >>> [image: Context Menu.png] >>> >>> Please review and let me know your thoughts. Is there any place where I >>> can use this? >>> >> >> I'm not sure what you mean with your last question, >> > I mean apart from the Properties tab and Context menu, do I need to > implement DROP DATABASE...WITH (FORCE)? > > >> but I think the wording needs some thought. Currently we have: >> >> Delete/Drop >> Drop Cascade >> Delete/Drop with Force >> >> I would suggest: >> >> Delete >> Delete (Cascade) >> Delete (Force) >> >> And we should probably re-order the menu to place those options together >> (and make sure the confirmation dialogues have appropriately matching text). >> > > I am not sure why we have used Delete/Drop, but for me, DROP seems > appropriate as in the backend we used DROP Queries, so can we have > Drop > Drop (Cascade) > Drop (Force) > Because in the past people (I don't recall who) claimed that "Drop" was not intuitive. I recall arguing that it's the standard SQL terminology, but iirc we eventually settled on Delete/Drop, which is, frankly, messy. -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> @ 2023-06-13 10:29 ` Akshay Joshi <[email protected]> 2023-06-13 10:53 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Akshay Joshi @ 2023-06-13 10:29 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers On Tue, Jun 13, 2023 at 3:49 PM Dave Page <[email protected]> wrote: > > > On Tue, 13 Jun 2023 at 11:13, Akshay Joshi <[email protected]> > wrote: > >> >> >> On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Tue, 13 Jun 2023 at 09:36, Akshay Joshi < >>> [email protected]> wrote: >>> >>>> Hi Hackers >>>> >>>> I have started the implementation for feature #6367 "DROP DATABASE can >>>> now take the option FORCE to drop a database even if other users are >>>> connected". >>>> >>>> For that, I figure out two places one in the Properties tab of the >>>> Databases collection node and the other in the context menu on the >>>> individual database node except the maintenance database. This feature will >>>> be available from PG 13 and above. Please refer to the screenshot below: >>>> >>>> [image: Properties.png] The 'Drop with Force' button is visible only >>>> on the Databases collection node. For other collection nodes, it is a 'Drop >>>> Cascade'. >>>> >>> >>> Right, because CASCADE means drop dependent objects as well, but FORCE >>> means disconnect connected users first. >>> >>> >>>> >>>> >>>> [image: Context Menu.png] >>>> >>>> Please review and let me know your thoughts. Is there any place where I >>>> can use this? >>>> >>> >>> I'm not sure what you mean with your last question, >>> >> I mean apart from the Properties tab and Context menu, do I need to >> implement DROP DATABASE...WITH (FORCE)? >> >> >>> but I think the wording needs some thought. Currently we have: >>> >>> Delete/Drop >>> Drop Cascade >>> Delete/Drop with Force >>> >>> I would suggest: >>> >>> Delete >>> Delete (Cascade) >>> Delete (Force) >>> >>> And we should probably re-order the menu to place those options together >>> (and make sure the confirmation dialogues have appropriately matching text). >>> >> >> I am not sure why we have used Delete/Drop, but for me, DROP seems >> appropriate as in the backend we used DROP Queries, so can we have >> Drop >> Drop (Cascade) >> Drop (Force) >> > > Because in the past people (I don't recall who) claimed that "Drop" was > not intuitive. I recall arguing that it's the standard SQL terminology, but > iirc we eventually settled on Delete/Drop, which is, frankly, messy. > So which option (Delete or Drop) should we use? > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:29 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> @ 2023-06-13 10:53 ` Dave Page <[email protected]> 2023-06-13 15:23 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Vijay B <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Dave Page @ 2023-06-13 10:53 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers On Tue, 13 Jun 2023 at 11:29, Akshay Joshi <[email protected]> wrote: > > > On Tue, Jun 13, 2023 at 3:49 PM Dave Page <[email protected]> wrote: > >> >> >> On Tue, 13 Jun 2023 at 11:13, Akshay Joshi <[email protected]> >> wrote: >> >>> >>> >>> On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Tue, 13 Jun 2023 at 09:36, Akshay Joshi < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers >>>>> >>>>> I have started the implementation for feature #6367 "DROP DATABASE can >>>>> now take the option FORCE to drop a database even if other users are >>>>> connected". >>>>> >>>>> For that, I figure out two places one in the Properties tab of the >>>>> Databases collection node and the other in the context menu on the >>>>> individual database node except the maintenance database. This feature will >>>>> be available from PG 13 and above. Please refer to the screenshot below: >>>>> >>>>> [image: Properties.png] The 'Drop with Force' button is visible >>>>> only on the Databases collection node. For other collection nodes, it is a >>>>> 'Drop Cascade'. >>>>> >>>> >>>> Right, because CASCADE means drop dependent objects as well, but FORCE >>>> means disconnect connected users first. >>>> >>>> >>>>> >>>>> >>>>> [image: Context Menu.png] >>>>> >>>>> Please review and let me know your thoughts. Is there any place where >>>>> I can use this? >>>>> >>>> >>>> I'm not sure what you mean with your last question, >>>> >>> I mean apart from the Properties tab and Context menu, do I need to >>> implement DROP DATABASE...WITH (FORCE)? >>> >>> >>>> but I think the wording needs some thought. Currently we have: >>>> >>>> Delete/Drop >>>> Drop Cascade >>>> Delete/Drop with Force >>>> >>>> I would suggest: >>>> >>>> Delete >>>> Delete (Cascade) >>>> Delete (Force) >>>> >>>> And we should probably re-order the menu to place those options >>>> together (and make sure the confirmation dialogues have appropriately >>>> matching text). >>>> >>> >>> I am not sure why we have used Delete/Drop, but for me, DROP seems >>> appropriate as in the backend we used DROP Queries, so can we have >>> Drop >>> Drop (Cascade) >>> Drop (Force) >>> >> >> Because in the past people (I don't recall who) claimed that "Drop" was >> not intuitive. I recall arguing that it's the standard SQL terminology, but >> iirc we eventually settled on Delete/Drop, which is, frankly, messy. >> > > So which option (Delete or Drop) should we use? > I think Delete, as it's more natural and expected in a GUI which is largely trying to prevent the user from needing to think about SQL. -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:29 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:53 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> @ 2023-06-13 15:23 ` Vijay B <[email protected]> 2023-06-14 04:39 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Vijay B @ 2023-06-13 15:23 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers I would also like to suggest to prompt for a password when drop db is chosen. Especially force drop being critical one. This would prevent accidental drops. Vaij On Tue, Jun 13, 2023 at 6:53 AM Dave Page <[email protected]> wrote: > > > On Tue, 13 Jun 2023 at 11:29, Akshay Joshi <[email protected]> > wrote: > >> >> >> On Tue, Jun 13, 2023 at 3:49 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Tue, 13 Jun 2023 at 11:13, Akshay Joshi < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Tue, 13 Jun 2023 at 09:36, Akshay Joshi < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Hackers >>>>>> >>>>>> I have started the implementation for feature #6367 "DROP DATABASE >>>>>> can now take the option FORCE to drop a database even if other users are >>>>>> connected". >>>>>> >>>>>> For that, I figure out two places one in the Properties tab of the >>>>>> Databases collection node and the other in the context menu on the >>>>>> individual database node except the maintenance database. This feature will >>>>>> be available from PG 13 and above. Please refer to the screenshot below: >>>>>> >>>>>> [image: Properties.png] The 'Drop with Force' button is visible >>>>>> only on the Databases collection node. For other collection nodes, it is a >>>>>> 'Drop Cascade'. >>>>>> >>>>> >>>>> Right, because CASCADE means drop dependent objects as well, but FORCE >>>>> means disconnect connected users first. >>>>> >>>>> >>>>>> >>>>>> >>>>>> [image: Context Menu.png] >>>>>> >>>>>> Please review and let me know your thoughts. Is there any place where >>>>>> I can use this? >>>>>> >>>>> >>>>> I'm not sure what you mean with your last question, >>>>> >>>> I mean apart from the Properties tab and Context menu, do I need to >>>> implement DROP DATABASE...WITH (FORCE)? >>>> >>>> >>>>> but I think the wording needs some thought. Currently we have: >>>>> >>>>> Delete/Drop >>>>> Drop Cascade >>>>> Delete/Drop with Force >>>>> >>>>> I would suggest: >>>>> >>>>> Delete >>>>> Delete (Cascade) >>>>> Delete (Force) >>>>> >>>>> And we should probably re-order the menu to place those options >>>>> together (and make sure the confirmation dialogues have appropriately >>>>> matching text). >>>>> >>>> >>>> I am not sure why we have used Delete/Drop, but for me, DROP seems >>>> appropriate as in the backend we used DROP Queries, so can we have >>>> Drop >>>> Drop (Cascade) >>>> Drop (Force) >>>> >>> >>> Because in the past people (I don't recall who) claimed that "Drop" was >>> not intuitive. I recall arguing that it's the standard SQL terminology, but >>> iirc we eventually settled on Delete/Drop, which is, frankly, messy. >>> >> >> So which option (Delete or Drop) should we use? >> > > I think Delete, as it's more natural and expected in a GUI which is > largely trying to prevent the user from needing to think about SQL. > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:13 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 10:29 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 10:53 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Dave Page <[email protected]> 2023-06-13 15:23 ` Re: Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Vijay B <[email protected]> @ 2023-06-14 04:39 ` Akshay Joshi <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Akshay Joshi @ 2023-06-14 04:39 UTC (permalink / raw) To: Vijay B <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers Hi Vijay On Tue, Jun 13, 2023 at 8:53 PM Vijay B <[email protected]> wrote: > I would also like to suggest to prompt for a password when drop db is > chosen. Especially force drop being critical one. This would prevent > accidental drops. > We have already prompted for confirmation with the Yes and No options. In case of an accidental drop, the user can still have the option to click on the "No" button. > > Vaij > > On Tue, Jun 13, 2023 at 6:53 AM Dave Page <[email protected]> wrote: > >> >> >> On Tue, 13 Jun 2023 at 11:29, Akshay Joshi <[email protected]> >> wrote: >> >>> >>> >>> On Tue, Jun 13, 2023 at 3:49 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Tue, 13 Jun 2023 at 11:13, Akshay Joshi < >>>> [email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Tue, Jun 13, 2023 at 2:50 PM Dave Page <[email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Tue, 13 Jun 2023 at 09:36, Akshay Joshi < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Hackers >>>>>>> >>>>>>> I have started the implementation for feature #6367 "DROP DATABASE >>>>>>> can now take the option FORCE to drop a database even if other users are >>>>>>> connected". >>>>>>> >>>>>>> For that, I figure out two places one in the Properties tab of the >>>>>>> Databases collection node and the other in the context menu on the >>>>>>> individual database node except the maintenance database. This feature will >>>>>>> be available from PG 13 and above. Please refer to the screenshot below: >>>>>>> >>>>>>> [image: Properties.png] The 'Drop with Force' button is visible >>>>>>> only on the Databases collection node. For other collection nodes, it is a >>>>>>> 'Drop Cascade'. >>>>>>> >>>>>> >>>>>> Right, because CASCADE means drop dependent objects as well, but >>>>>> FORCE means disconnect connected users first. >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> [image: Context Menu.png] >>>>>>> >>>>>>> Please review and let me know your thoughts. Is there any place >>>>>>> where I can use this? >>>>>>> >>>>>> >>>>>> I'm not sure what you mean with your last question, >>>>>> >>>>> I mean apart from the Properties tab and Context menu, do I need >>>>> to implement DROP DATABASE...WITH (FORCE)? >>>>> >>>>> >>>>>> but I think the wording needs some thought. Currently we have: >>>>>> >>>>>> Delete/Drop >>>>>> Drop Cascade >>>>>> Delete/Drop with Force >>>>>> >>>>>> I would suggest: >>>>>> >>>>>> Delete >>>>>> Delete (Cascade) >>>>>> Delete (Force) >>>>>> >>>>>> And we should probably re-order the menu to place those options >>>>>> together (and make sure the confirmation dialogues have appropriately >>>>>> matching text). >>>>>> >>>>> >>>>> I am not sure why we have used Delete/Drop, but for me, DROP seems >>>>> appropriate as in the backend we used DROP Queries, so can we have >>>>> Drop >>>>> Drop (Cascade) >>>>> Drop (Force) >>>>> >>>> >>>> Because in the past people (I don't recall who) claimed that "Drop" was >>>> not intuitive. I recall arguing that it's the standard SQL terminology, but >>>> iirc we eventually settled on Delete/Drop, which is, frankly, messy. >>>> >>> >>> So which option (Delete or Drop) should we use? >>> >> >> I think Delete, as it's more natural and expected in a GUI which is >> largely trying to prevent the user from needing to think about SQL. >> >> -- >> Dave Page >> Blog: https://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: https://www.enterprisedb.com >> >> Attachments: [image/png] Properties.png (13.9K, 3-Properties.png) download | view image [image/png] Context Menu.png (132.2K, 4-Context%20Menu.png) download | view image ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2023-06-14 04:39 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-13 08:35 Regarding feature #6367 "DROP DATABASE can now take the option FORCE ..." Akshay Joshi <[email protected]> 2023-06-13 09:20 ` Dave Page <[email protected]> 2023-06-13 10:13 ` Akshay Joshi <[email protected]> 2023-06-13 10:19 ` Dave Page <[email protected]> 2023-06-13 10:29 ` Akshay Joshi <[email protected]> 2023-06-13 10:53 ` Dave Page <[email protected]> 2023-06-13 15:23 ` Vijay B <[email protected]> 2023-06-14 04:39 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox