MIME-Version: 1.0
In-Reply-To: 
 <CA+yw=mPy7QqwWiR-MzMqyd+Zyjca1OBZuD5k_Z+CH6ore1A-vA@mail.gmail.com>
References: 
 <CA+yw=mMx=HsY2K01bQmdh6i+E4hUKJJM+KZWW_4B0AhB-O8cPw@mail.gmail.com>
	<CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
	<CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com>
	<CA+yw=mNuzL-ZOPhN2HeM=4X5TZKjyLi+r4SXqvtfNdGo32SyhA@mail.gmail.com>
	<CA+yw=mMXCnte6_yLEgW-HKbSAa5ZhLVF1U9gr6VYwKfch3eoPQ@mail.gmail.com>
	<CA+yw=mO_GC-jPtngf1AChkWKGfU6gVG3Ag0RP3aEeLnHvV8mCA@mail.gmail.com>
	<CA+OCxoyZ68sU+hLm=THSd8afjAAxLZ0fB0fj-vtLPNvwABL-WA@mail.gmail.com>
	<CA+yw=mPy7QqwWiR-MzMqyd+Zyjca1OBZuD5k_Z+CH6ore1A-vA@mail.gmail.com>
Date: Mon, 14 Mar 2016 13:57:38 +0000
Message-ID: 
 <CA+OCxoz+TiEg+Z3jKu6ccFf7YX7Wp71eSzr+mvefwwqdkPz5-g@mail.gmail.com>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
From: Dave Page <dpage@pgadmin.org>
To: Sanket Mehta <sanket.mehta@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Mon, Mar 14, 2016 at 1:52 PM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> I have incorporated your changes.
> I have also tried to reproduce the Issues that you have mentioned.
> find the response inline.
>
> Also find revised patch having your suggested changes attached with this
> mail.
> Please do review it and let me know in case anything is missing.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Fri, Mar 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Mar 10, 2016 at 6:28 AM, Sanket Mehta
>> <sanket.mehta@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA the patch for fts template after replacing collectionNodeModule with
>> > SchemaChildModule in __init__.py
>> >
>> > Apart from that, there was an error while updating the name of fts
>> > template
>> > which I have resolved in the same.
>> >
>> > Please do review it and let me know in case of any changes.
>>
>> I've updated the patch for consistency with others. Please find
>> attached. Aside from those changes, there are two issues:
>>
>> - When creating or editing a template the SQL pane just says
>> "--modified SQL" even when all required options are specified. The
>> template is created correctly though.
>
> I have tried to reproduce this issue on my system but could not reproduce
> it. PFA screen shorts explaining sql I got while creating and editing a
> template.
>
>>
>> - If a template is renamed, the treeview node is not updated.
>
> This is generic issue and needed to be resolved at higher level.

No, I tested other nodes (database and sequence for example) and they
were properly updated. It's possible *some* are broken, but it's
certainly not a general issue.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers