Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euK7O-0000B7-76 for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:39:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1euK7M-0006F4-HP for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:39:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euK7M-0006Eu-8Y for pgadmin-hackers@lists.postgresql.org; Fri, 09 Mar 2018 15:39:36 +0000 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1euK7I-0006nH-EM for pgadmin-hackers@postgresql.org; Fri, 09 Mar 2018 15:39:34 +0000 Received: by mail-wr0-x234.google.com with SMTP id o76so9419673wrb.7 for ; Fri, 09 Mar 2018 07:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=APj8608bMqUWkiWQ4yuSYbGB6foeXibRvxxTK8LDAfs=; b=jYMvFTyrKYDPyV4lq7mJV0uYi+BL5KwZxk13xzQ1WX88rpeddxi87ZavNrHNghMCOU ILyqZgFBT95dFtvYb+RqOM0ky+0gy0IVub+Sb2Eg+UxVzW8CkVaxgjLnwrzhg+GdW+Ii kdyIFre4qAbGhRgIs8XCeYxE1BQFe4+NTWjjuIBX5WYi/pBHFc5pdjCKTyGNviDze3WO CfhFVGEoXA/H+l53TyPPgQUlTEZqMd/TtLAKKw9XCVabv5HL/tlWUgdkPRVoI0XuVDHQ mafZz9KeaKeFwa4v1Ny0LGJz96zhCVE7p/eWC6c6DjrMPlEc9VdL5E1DL1248OsEQQHv HYdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=APj8608bMqUWkiWQ4yuSYbGB6foeXibRvxxTK8LDAfs=; b=K/bxCiqKa5OaF1SS9I8CYen7O09k1EX2OAoY0zCC2mNYGiq0k3HgLpxIHSeGxPx0Wk VUBkciosdzZSR44xwXxL/PiwS5vy4L7nL0iBHq+ZdQ+iCwSWhHnAffN6a2YB6GRbfZw2 8eNdZn4isGVWogWDgN8W7L4d0ScZeG7XFeoRdawNSNKNzCnr7w9CxuLbzdGBM08Q/lUO 1hyNt4VvTVL4YTxPXq/S/oEbHSn8E/SeoZe6OJBUnXVf5sDXabTLPuhqibkcqNkUivL3 07wnwnDJcqsuIa4XF2GKQXJ4doDOPzrsVeTDTXqMR+ry3tchuWB/2LkNMqFUOvX5Hiv3 vCWQ== X-Gm-Message-State: APf1xPAZEgmlGD+eYDnTK6DXFHURCoSqeAEHW9ijF/idcBtqk3Dt09KL yzad6bLUtK5g3lgCDLs/y0rRmyOFapV65uTg2Ig9mw== X-Google-Smtp-Source: AG47ELvzn6vnGGhCY1aL1UGBonr8w2gZfw/NgeEk3H0e4XFlWURG7/tIeqj2fWrVCm0ZhRVq8uDv9mXOH9pKJvHxyb4= X-Received: by 10.223.166.171 with SMTP id t40mr28365390wrc.49.1520609970212; Fri, 09 Mar 2018 07:39:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 9 Mar 2018 07:39:29 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 9 Mar 2018 15:39:29 +0000 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BpgAdmin4=5D=5BPatch=5D=3A_RM_=232963_=2D_Backup_database=2C_R?= =?UTF-8?Q?estore_database_and_Maintenance_Database_failed_for_=C3=A9_objec?= =?UTF-8?Q?t=2E?= To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113df90a1def670566fc99e2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113df90a1def670566fc99e2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, Mar 9, 2018 at 3:32 PM, Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix below issues: >> >> 1. #2963 - Backup database, Restore database and Maintenance Database >> failed for =C3=A9 object >> 2. #3157 - Process viewer doesn't show complete command executed. >> >> Test cases are not included for these fixes as we don't have test cases >> for these modules (backup, restore, maintenance). >> I will create one separate RM for the same which will cover this. >> > > Interesting that you fix these together, as together they also exhibit > another bug :-). Backing up the =C3=A9 database displays the following co= mmand: > > /usr/local/pgsql/bin/pg_dump --file "/Users/dpage/foo.bak" --host > "localhost" --port "5432" --username "postgres" --no-password --verbose > --format=3Dc --blobs "é" > Also, what tests can we add for backup/restore? We have nothing at all at the moment, and it is pretty troublesome. I'd like to ensure that we can backup and restore a database correctly, and ensure that the displayed commands are what we expect and that we get valid output from pg_dump/pg_restore (though, it may change from PG version to PG version, so maybe we should just check for something small and generic). I guess this might need some config parameters for the tests to specify the pg_* utility paths for each server. I'd suggest maybe having a feature test that opens the prefs, sets the appropriate path, then runs a backup, waits for it to finish, checks the process monitor output, then restores the same backup to a new database, checking the process monitor output again, and then checking that the restored database contains at least one object from the original database (we don't need to check all of pg_dump/pg_restore, just that something expected was restored). We should use a (partial) database name and backup filename from the advanced test config file, and I think both should default to some interesting non-ASCII strings to ensure quoting works. --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113df90a1def670566fc99e2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Mar 9, 2018 at 3:32 PM, Dave Page <dpage@pgadmin.org>= wrote:
Hi

On Fri,= Mar 9, 2018 at 3:54 AM, Khushboo Vashi <khushboo.vashi@ente= rprisedb.com> wrote:
Hi,

Please find = the attached patch to fix below issues:

1. #2963 -= Backup database, Restore database and Maintenance Database failed for =C3= =A9 object
2. #3157 - Process viewer doesn't show complete co= mmand executed.

Test cases are not included for th= ese fixes as we don't have test cases for these modules (backup, restor= e, maintenance).
I will create one separate RM for the same which= will cover this.

Intere= sting that you fix these together, as together they also exhibit another bu= g :-). Backing up the =C3=A9=C2=A0database= displays the following command:

/usr/local/pgsql/bin/pg_dump --file "/Users/dpage/foo.ba= k" --host "localhost" --port "5432" --username &qu= ot;postgres" --no-password --verbose --format=3Dc --blobs "&#= 233;"=C2=A0

=
Also, what tests can we add for backup/restore? We have nothing at all= at the moment, and it is pretty troublesome. I'd like to ensure that w= e can backup and restore a database correctly, and ensure that the displaye= d commands are what we expect and that we get valid output from pg_dump/pg_= restore (though, it may change from PG version to PG version, so maybe we s= hould just check for something small and generic). I guess this might need = some config parameters for the tests to specify the pg_* utility paths for = each server.=C2=A0

I'd suggest maybe having a = feature test that opens the prefs, sets the appropriate path, then runs a b= ackup, waits for it to finish, checks the process monitor output, then rest= ores the same backup to a new database, checking the process monitor output= again, and then checking that the restored database contains at least one = object from the original database (we don't need to check all of pg_dum= p/pg_restore, just that something expected was restored). We should use a (= partial) database name and backup filename from the advanced test config fi= le, and I think both should default to some interesting non-ASCII strings t= o ensure quoting works.


--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a113df90a1def670566fc99e2--