MIME-Version: 1.0
References: 
 <CAOBg0AOa4EfDwph4Ba2=GV4SSnLJ8vxtqdb=zt8koQNAwuNy9w@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AOa4EfDwph4Ba2=GV4SSnLJ8vxtqdb=zt8koQNAwuNy9w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 3 Jun 2021 09:17:41 +0100
Message-ID: 
 <CA+OCxoz-Qr9ubPZ-1wBrHkF+0B=cC72rEHURyLQfFF4dHSDbhg@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6460]: Need a mechanism to detect a corrupt/broken
 config DB file.
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000047e03d05c3d8366e"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoz-Qr9ubPZ-1wBrHkF%2B0B%3DcC72rEHURyLQfFF4dHSDbhg%40mail.gmail.com>
Precedence: bulk

--00000000000047e03d05c3d8366e
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 3, 2021 at 7:39 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6460
> <https://redmine.postgresql.org/issues/6460>:  Need a mechanism to detect
> a corrupt/broken config DB file.
>
> 1. Added checks if all tables added in the model are present in SQLite DB
> or not.
> 2. If migrations fail it will backup older file and try migrations with
> the newly created file.
> (User will get notification on UI for the location of the backup file and
> newly created.)
> 3. If the user deleted any table from SQLite DB pgAdmin will not run on
> the next restart and it will add the missing table list in the logs.
>

Surely if any tables have been deleted, it'll fail the check in point 1?

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--00000000000047e03d05c3d8366e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 3, 2021 at 7:39 AM Nikhil M=
ohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohite@e=
nterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:so=
lid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">H=
i Hackers,<div><br></div><div>Please find the attached patch for=C2=A0<a hr=
ef=3D"https://redmine.postgresql.org/issues/6460" target=3D"_blank">RM-6460=
</a>:=C2=A0 Need a mechanism to detect a corrupt/broken config DB file.</di=
v><div><br></div><div>1. Added checks if all tables added in the model are =
present in SQLite DB or not.</div><div>2. If migrations fail it will backup=
 older file and try migrations with the newly created file.=C2=A0</div><div=
>(User will get notification on UI=C2=A0for the location=C2=A0of the backup=
 file and newly created.)</div><div>3. If the user deleted any table from S=
QLite DB pgAdmin will not run on the next restart and it will add the missi=
ng table list in the logs.</div></div></blockquote><div><br></div><div>Sure=
ly if any tables have been deleted, it&#39;ll fail the check in point 1?</d=
iv><div>=C2=A0</div></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"=
><div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"https://pgsnake.blogspot.co=
m" target=3D"_blank">https://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<=
br><br>EDB: <a href=3D"https://www.enterprisedb.com" target=3D"_blank">http=
s://www.enterprisedb.com</a><br><br></div></div></div>

--00000000000047e03d05c3d8366e--