Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ets0j-0002Hx-Fg for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:38:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ets0i-0001oq-ES for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:38:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ets0i-0001oQ-7r for pgadmin-hackers@lists.postgresql.org; Thu, 08 Mar 2018 09:38:52 +0000 Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ets0e-0001lB-Jj for pgadmin-hackers@postgresql.org; Thu, 08 Mar 2018 09:38:51 +0000 Received: by mail-wr0-x231.google.com with SMTP id n7so4964005wrn.5 for ; Thu, 08 Mar 2018 01:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Awwg8414L/rCq6/ZxPte+D8ESBKpbnWLpl42NXQ6Wk4=; b=TtNqpr8TE+mb3BVo2ugeSKdK3/iYlNLjCjmHZf6hVHl0cOc/c+KGdLYbGczThJKgj8 3e6nBZzAiKPFlV+vN3Kt1FK+Ik0Gte0oc57r1ZoGhV0YTCDzMvJ2l503L3WASz3AYNNN oaQwlfYnNl9FBgWDzWgch+aHUtQuq1l6iS7tsBfAGKHUK+VFuNf8TDgMMnyqtbACV0Y5 Apa6l/jyRS6YM8x3HxKCu7T05LW3Dh+YAe/yCdLWI10943dKxiAMoLOWhn0uaJWl/+4u X4jcVfS1j4iZZSWj+4GqVhuPhQjA56bIztOOxUFbFxBXaBlk+td4CD+AQDRtEp57SS9g a4fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Awwg8414L/rCq6/ZxPte+D8ESBKpbnWLpl42NXQ6Wk4=; b=Hz53t7MzT4f2M0wr5p+PopfKVai11evD5toWmZz5RMCNFIDrcY3iw9ItA589l4U/uy 8/n+/c7O/PwyILTpkHBoF2WD9VUf2Kn3xOwjqnNlB9Y/zW2953CHCzd0eZT7St1Xj7AS X+TrqNCnDpOwol24auVA9UALNdqG8KbpUJPMi7J3r6cwg80NQZZT79zjD3qx5skwFvub T5ZTHoIelox05uvSaePB341Anmq61Znfpf4AwyJl5zfl9G2ftWMMSdSTXkC58cAHm8Pt opFnWNtof+RBqOnXaPV0LxAW7jmS7zaNb93s0Qby3x4T4hcYnvX92ioLp+tZXLkx3iZ2 fntg== X-Gm-Message-State: APf1xPD/XGVpvHSrREm5xBNeSa6fO9FnfYLZ0hU7xcreUO05qQu4FhY+ feTapPFUKh2vdiuZ0s700LAX/Pvj9kB9CdoLahzwaA== X-Google-Smtp-Source: AG47ELt0vaaFfAj1C2cR4wnnTqbHPV8usdPrQ/rUhzK6gTiK71IkoTmpp0g7+m3vfhFFpbUYtBjtapUEBQX1dhhcWqY= X-Received: by 10.223.178.206 with SMTP id g72mr20780223wrd.135.1520501926615; Thu, 08 Mar 2018 01:38:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 8 Mar 2018 01:38:46 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Dave Page Date: Thu, 8 Mar 2018 09:38:46 +0000 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045cf6b83772710566e3711c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045cf6b83772710566e3711c Content-Type: text/plain; charset="UTF-8" Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though (which is odd, as it passed on my local 2.7). On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote: > Thanks, applied. > > On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find the patch to fix this. >>> I have fixed this issue in the StartRunningQueryTest class, this test >>> class changes the behaviour of the methods through MagicMock and due to >>> this this test case is failing. >>> >>> Revised patch with some modification. >> >>> Thanks, >>> Khushboo >>> >>> >>> On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: >>>> >>>>> It still seems to be failing :-( >>>>> >>>>> :( >>>> >>>>> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las >>>>> tFailedBuild/consoleFull >>>>> >>>>> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: >>>>> >>>>>> Thanks, applied. Lets see what happens. >>>>>> >>>>>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Please find the attached updated patch. >>>>>>> This should work. >>>>>>> >>>>>>> >>>>>>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Dave, >>>>>>>>>>> >>>>>>>>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Khushboo, can you look at this ASAP please? It passed tests on >>>>>>>>>>>> my machine, but Jenkins isn't happy. >>>>>>>>>>>> >>>>>>>>>>>> I have tried to reproduce the issue with many combination but >>>>>>>>>>> couldn't reproduce it. >>>>>>>>>>> With the help of logs, I have tried to fix it. Can you please >>>>>>>>>>> check this fix is helpful or not? >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On my laptop I now get: >>>>>>>>>> >>>>>>>>>> ============================================================ >>>>>>>>>> ========== >>>>>>>>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>>>>>>>> .test_poll_query_tool.TestPollQueryTool) >>>>>>>>>> When query tool polling returns messages with result data-set >>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>> ---------- >>>>>>>>>> Traceback (most recent call last): >>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>> /pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line >>>>>>>>>> 104, in runTest >>>>>>>>>> response_data['data']['additional_messages']) >>>>>>>>>> File "/System/Library/Frameworks/Py >>>>>>>>>> thon.framework/Versions/2.7/lib/python2.7/unittest/case.py", >>>>>>>>>> line 802, in assertIn >>>>>>>>>> if member not in container: >>>>>>>>>> TypeError: argument of type 'NoneType' is not iterable >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>> ---------- >>>>>>>>>> >>>>>>>>>> Please provide some more details. Is this failing for particular >>>>>>>>> server version? >>>>>>>>> I am not getting any error with this patch and without this patch >>>>>>>>> on PY2 and PY3 with a single/multiple servers. >>>>>>>>> >>>>>>>> >>>>>>>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here >>>>>>>> are the package versions in the venv: >>>>>>>> >>>>>>>> alabaster==0.7.10 >>>>>>>> alembic==0.9.6 >>>>>>>> args==0.1.0 >>>>>>>> Babel==2.3.4 >>>>>>>> backports.csv==1.0.4 >>>>>>>> beautifulsoup4==4.4.1 >>>>>>>> blinker==1.3 >>>>>>>> chromedriver-installer==0.0.6 >>>>>>>> click==6.6 >>>>>>>> clint==0.5.1 >>>>>>>> dateutils==0.6.6 >>>>>>>> docutils==0.13.1 >>>>>>>> extras==1.0.0 >>>>>>>> fixtures==3.0.0 >>>>>>>> Flask==0.11.1 >>>>>>>> Flask-Babel==0.11.1 >>>>>>>> Flask-Gravatar==0.4.2 >>>>>>>> Flask-HTMLmin==1.2 >>>>>>>> Flask-Login==0.3.2 >>>>>>>> Flask-Mail==0.9.1 >>>>>>>> Flask-Migrate==2.0.3 >>>>>>>> Flask-Paranoid==0.1.0 >>>>>>>> Flask-Principal==0.4.0 >>>>>>>> Flask-Script==2.0.6 >>>>>>>> Flask-Security==1.7.5 >>>>>>>> Flask-SQLAlchemy==2.1 >>>>>>>> Flask-WTF==0.12 >>>>>>>> funcsigs==1.0.2 >>>>>>>> html5lib==1.0b3 >>>>>>>> htmlmin==0.1.11 >>>>>>>> imagesize==0.7.1 >>>>>>>> importlib==1.0.3 >>>>>>>> itsdangerous==0.24 >>>>>>>> Jinja2==2.7.3 >>>>>>>> linecache2==1.0.0 >>>>>>>> Mako==1.0.7 >>>>>>>> MarkupSafe==0.23 >>>>>>>> minify==0.1.4 >>>>>>>> mock==2.0.0 >>>>>>>> passlib==1.6.2 >>>>>>>> pbr==3.1.1 >>>>>>>> pkginfo==1.4.1 >>>>>>>> psycopg2==2.7.3.2 >>>>>>>> pycodestyle==2.3.1 >>>>>>>> pycrypto==2.6.1 >>>>>>>> Pygments==2.2.0 >>>>>>>> pyperclip==1.5.32 >>>>>>>> pyrsistent==0.14.0 >>>>>>>> python-dateutil==2.5.0 >>>>>>>> python-editor==1.0.3 >>>>>>>> python-mimeparse==1.6.0 >>>>>>>> pytz==2014.10 >>>>>>>> requests==2.13.0 >>>>>>>> requests-toolbelt==0.7.1 >>>>>>>> selenium==3.3.3 >>>>>>>> simplejson==3.6.5 >>>>>>>> six==1.11.0 >>>>>>>> snowballstemmer==1.2.1 >>>>>>>> speaklater==1.3 >>>>>>>> Sphinx==1.5.3 >>>>>>>> SQLAlchemy==1.0.14 >>>>>>>> sqlparse==0.1.19 >>>>>>>> testscenarios==0.5.0 >>>>>>>> testtools==2.0.0 >>>>>>>> traceback2==1.4.0 >>>>>>>> unittest2==1.1.0 >>>>>>>> Werkzeug==0.9.6 >>>>>>>> WTForms==2.0.2 >>>>>>>> yuicompressor==2.4.8 >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045cf6b83772710566e3711c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Well, it looks like Python 3 might be happy now. 2.6 and 2= .7 aren't though (which is odd, as it passed on my local 2.7).

On Thu, Mar 8, 2018 = at 9:13 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi = <kh= ushboo.vashi@enterprisedb.com> wrote:


On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi <= span dir=3D"ltr"><khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

Please find the patch to fix this.
I have fixed this issue in = the StartRunningQueryTest class, this test class changes the behaviour of t= he methods through MagicMock and due to this this test case is failing.

Revised patch with some mod= ification.=C2=A0
Thanks,
Khu= shboo


On Wed, Mar 7= , 2018 at 10:34 PM, Khushboo Vashi <khushboo.vashi@enterpris= edb.com> wrote:


On Wed, Mar 7, 2018 at 10:33 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:
It still s= eems to be failing :-(

:(=C2= =A0

On Wed, Mar 7, 2018 a= t 4:50 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied. Lets see what happe= ns.

On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Please find the attached updated = patch.
This should work.


On Wed, Mar 7, 2018 at 9:46 PM, Dave Page &= lt;dpage@pgadmin.org= > wrote:
<= br>

On Wed, = Mar 7, 2018 at 4:13 PM, Khushboo Vashi <khushboo.vashi@enter= prisedb.com> wrote:


On Wed, Mar = 7, 2018 at 9:23 PM, Dave Page <dpage@pgadmin.org> wrote:
=
Hi

On Wed, Mar 7= , 2018 at 3:10 PM, Khushboo Vashi <khushboo.vashi@enterprise= db.com> wrote:
Hi Dave,

On Wed, Mar 7, 2018 at 7:34 PM, Da= ve Page <dpage@pgadmin.org> wrote:
Khushboo, can you look at th= is ASAP please? It passed tests on my machine, but Jenkins isn't happy.=

I have tried to reproduce the= issue with many combination but couldn't reproduce it.
With = the help of logs, I have tried to fix it. Can you please check this fix is = helpful or not?=C2=A0

On my laptop I now get:

=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: r= unTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with = result data-set
-------------------------------------= ---------------------------------
Traceback (most recent cal= l last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pga= dmin/tools/sqleditor/tests/test_poll_query_tool.py", line 104, in= runTest
=C2=A0 =C2=A0 response_data['data']['additio= nal_messages'])
=C2=A0 File "/System/Library/Framew= orks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py= ", line 802, in assertIn
=C2=A0 =C2=A0 if member not in cont= ainer:
TypeError: argument of type 'NoneType' is not iter= able

----------------------------------------= ------------------------------=C2=A0

<= /span>
Please provide some more details= . Is this failing for particular server version?
I am not getting= any error with this patch and without this patch on PY2 and PY3 with a sin= gle/multiple servers.

Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. He= re are the package versions in the venv:

alab= aster=3D=3D0.7.10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babel=3D=3D2.3.4
backports.csv=3D=3D1.0.4
beaut= ifulsoup4=3D=3D4.4.1
blinker=3D=3D1.3
chromedriver-inst= aller=3D=3D0.0.6
click=3D=3D6.6
clint=3D=3D0.5.1
<= div>dateutils=3D=3D0.6.6
docutils=3D=3D0.13.1
extras=3D= =3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babel=3D=3D0.11.1
Flask-Gravatar=3D=3D0.4.2
Fla= sk-HTMLmin=3D=3D1.2
Flask-Login=3D=3D0.3.2
Flask-Mail= =3D=3D0.9.1
Flask-Migrate=3D=3D2.0.3
Flask-Paranoid=3D= =3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-Script=3D=3D2= .0.6
Flask-Security=3D=3D1.7.5
Flask-SQLAlchemy=3D=3D2.= 1
Flask-WTF=3D=3D0.12
funcsigs=3D=3D1.0.2
htm= l5lib=3D=3D1.0b3
htmlmin=3D=3D0.1.11
imagesize=3D=3D0.7= .1
importlib=3D=3D1.0.3
itsdangerous=3D=3D0.24
Jinja2=3D=3D2.7.3
linecache2=3D=3D1.0.0
Mako=3D=3D1.0= .7
MarkupSafe=3D=3D0.23
minify=3D=3D0.1.4
moc= k=3D=3D2.0.0
passlib=3D=3D1.6.2
pbr=3D=3D3.1.1
pkginfo=3D=3D1.4.1
psycopg2=3D=3D2.7.3.2
pycodestyle= =3D=3D2.3.1
pycrypto=3D=3D2.6.1
Pygments=3D=3D2.2.0
pyperclip=3D=3D1.5.32
pyrsistent=3D=3D0.14.0
pyt= hon-dateutil=3D=3D2.5.0
python-editor=3D=3D1.0.3
python= -mimeparse=3D=3D1.6.0
pytz=3D=3D2014.10
requests=3D=3D2= .13.0
requests-toolbelt=3D=3D0.7.1
selenium=3D=3D3.3.3<= /div>
simplejson=3D=3D3.6.5
six=3D=3D1.11.0
snowbal= lstemmer=3D=3D1.2.1
speaklater=3D=3D1.3
Sphinx=3D=3D1.5= .3
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1.19
testscenarios=3D=3D0.5.0
testtools=3D=3D2.0.0
traceba= ck2=3D=3D1.4.0
unittest2=3D=3D1.1.0
Werkzeug=3D=3D0.9.6=
WTForms=3D=3D2.0.2
yuicompressor=3D=3D2.4.8

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgr= eSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y






--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--f403045cf6b83772710566e3711c--