MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELezaRVS+JbX0Xtsms8jWND9H1h8HW_WeB3rKVLT8kJ=Fg@mail.gmail.com>
References: 
 <CAFOhELezaRVS+JbX0Xtsms8jWND9H1h8HW_WeB3rKVLT8kJ=Fg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 14 Jun 2018 08:50:07 +0100
Message-ID: 
 <CA+OCxoz0e8J6qGEzeGrQ6ViL17zpfZeRDFzudwP7A-Y1g14LzA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application
 server could not be contacted
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000020aeb5056e955936"
Precedence: bulk

--00000000000020aeb5056e955936
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
> could not be contacted
>
> The issue is with french translation which has been taken care in the
> attached patch.
>

We've seen similar issues with translations before. How can we write a test
(or tests) to validate them?

One idea that springs to mind is to generate a new template against the
app, then iterate through all the translation catalogs and attempt to
translate each string that we find in the template we generated.

Alternatively, just iterate the catalogs, and grab each of the source
strings from them and attempt to translate using the same catalog.

The former method would ensure that the current state of the application
can be translated, but that of course might miss some strings in the
catalogs. The latter would validate each catalog against itself, but might
miss some strings that are in the application but haven't been merged yet
(though, that doesn't seem like it would cause a problem).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--00000000000020aeb5056e955936
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <span dir=3D"ltr">&lt=
;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khush=
boo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the fix for #34=
11 -=C2=A0pgAdmin 4, Mac. The application server could not be contacted</di=
v><div><br></div><div>The issue is with french translation which has been t=
aken care in the attached patch.</div></div></blockquote><div><br></div><di=
v>We&#39;ve seen similar issues with translations before. How can we write =
a test (or tests) to validate them?</div><div><br></div><div>One idea that =
springs to mind is to generate a new template against the app, then iterate=
 through all the translation catalogs and attempt to translate each string =
that we find in the template we generated.</div><div><br></div><div>Alterna=
tively, just iterate the catalogs, and grab each of the source strings from=
 them and attempt to translate using the same catalog.</div><div><br></div>=
<div>The former method would ensure that the current state of the applicati=
on can be translated, but that of course might miss some strings in the cat=
alogs. The latter would validate each catalog against itself, but might mis=
s some strings that are in the application but haven&#39;t been merged yet =
(though, that doesn&#39;t seem like it would cause a problem).</div></div><=
div><br></div>-- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail=
_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" targ=
et=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>E=
nterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">h=
ttp://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></di=
v>
</div></div>

--00000000000020aeb5056e955936--