Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b05Sh-0000LN-2z for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 11:04:23 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b05Sg-0003JS-MB for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 11:04:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b05ST-0002qL-AV for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 11:04:09 +0000 Received: from mail-io0-x235.google.com ([2607:f8b0:4001:c06::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b05SL-0006tK-JW for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 11:04:08 +0000 Received: by mail-io0-x235.google.com with SMTP id 190so11354059iow.1 for ; Tue, 10 May 2016 04:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=OVuJryETAwUnFux7HLbqAdWc62OkwXD+xqWiwZtKVD0=; b=Z+ErFTaD0QFYpU8FzPY+ic3oXUdAjiiRx19qMPU5yt505DDB1kzbzahFGX/PK9eIR5 upm+3NC/aGzdfCk9RW2yNXjs5aeq/oC83mQKmRx+QQ+iPDm6TPJD7yV7wSjJ2CBZs7yG N0kO9No/+e+eqejYmqI/SYoz4IYA22DwWf3NPAtOHeIp7WEpjtgbBUKoxiEIo+NJIM// BDZldMbj4lcGaiNPLB6Q5xsMmbE5a21u3geedYD74286V1JNKPJX1qj4XkMrPhR29WCv 97rKg5Eq6tb5u4bYYvgPzigPjQKFLeVcLAlb2zPHnKCVOy+0wcH3ZAsOJfsVygWRvu2U CsHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=OVuJryETAwUnFux7HLbqAdWc62OkwXD+xqWiwZtKVD0=; b=Ubffn6qrc5mbHQqGE1a/39KdFz4C1RPRTNLxqLOs8JRXk/EAttJqUncm31WlDSDc+A og+tHaFmrZ3LRfGmh/oRZ+2Oyn8QrSzGkePz3GIPJzzPg4aCDte77PGJfesDuoGmd1ly 20Ydji2JKD5wxMwi8RSgbGA5qH6TY6PNMA9jZsor889vQhmeB8ijTmRM0Rkx/+mupIeR Mbzf4ahMs/K6efIbVrdM3oQH2yNfL0QWKUgrFb4jFeRbmBPLAHK8LFr9/7BHZH0PI1s0 hpwvcUCeluFHucawomRq4Ov0Dkw1cDnA99VtbeWStU/JquZ7oTiNjH+bTtE5IdnYUeaI gVXQ== X-Gm-Message-State: AOPr4FU0XW1BQSs2wKQPb1EUQCR7NTVZgSWrS16IFsV4DtjA+PGelgYzZ0XuOmBI/BMRX+Kgg5bVRwb8UNb+yw== MIME-Version: 1.0 X-Received: by 10.107.56.198 with SMTP id f189mr42974127ioa.156.1462878238720; Tue, 10 May 2016 04:03:58 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Tue, 10 May 2016 04:03:58 -0700 (PDT) In-Reply-To: References: <58B5FCCE-9882-44C0-B990-8BF5D2FA17DC@enterprisedb.com> <928839C0-1CD1-4307-9C62-6A693D6F0533@enterprisedb.com> <2BC9FA40-F05D-48AA-8796-29808FC15498@enterprisedb.com> Date: Tue, 10 May 2016 12:03:58 +0100 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module From: Dave Page To: Ashesh Vashi Cc: Khushboo Vashi , Murtuza Zabuawala , Neel Patel , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114a6b20c5254b05327ae1e4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a6b20c5254b05327ae1e4 Content-Type: text/plain; charset=UTF-8 On Mon, May 9, 2016 at 1:23 PM, Ashesh Vashi wrote: > On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch for the Foreign Tables module. >> > Feedback from my initial testing: - Owner is missing from the New dialogue. - The Properties list shows "Select from the list" in a combo box for Owner and Inherits. - s/Oid/OID - s/Foreign Server/Foreign server - SQL Help filenames are not defined. - SQL formatting is weird, e.g. CREATE FOREIGN TABLE public.redis_table (id text NOT NULL COLLATE pg_catalog."default", value text NULL COLLATE pg_catalog."default") SERVER redis_server1 OPTIONS (database '0'); instead of: CREATE FOREIGN TABLE public.redis_table ( id text NOT NULL COLLATE pg_catalog."default", value text NULL COLLATE pg_catalog."default" ) SERVER redis_server1 OPTIONS (database '0'); - In the validation error messages, please replace ! with . and "can not" with "cannot" for consistency with recently reviewed strings. - s/mulitple/multiple (in the js). - How do I manage the ACL? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114a6b20c5254b05327ae1e4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, May 9, 2016 at 1:23 PM, Ashesh Vashi <ashesh.vashi= @enterprisedb.com> wrote:

On Mon, May 9, 2016= at 5:50 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:

Hi,

Please find the attached updated patch for the Foreign Tables m= odule.
<= br>
Feedback from my initial testing:

- = Owner is missing from the New dialogue.

- The Prop= erties list shows "Select from the list" in a combo box for Owner= and
=C2=A0 Inherits.
=C2=A0=C2=A0
- s/Oid/OI= D

- s/Foreign Server/Foreign server

=
- SQL Help filenames are not defined.

-= SQL formatting is weird, e.g.

CREATE FOREIGN TABL= E public.redis_table
(id text NOT NULL COLLATE pg_catalog."d= efault",
value text NULL COLLATE pg_catalog."default&qu= ot;)
=C2=A0 =C2=A0 SERVER redis_server1
=C2=A0 =C2=A0 O= PTIONS (database '0');
=C2=A0 =C2=A0=C2=A0
inst= ead of:

CREATE FOREIGN TABLE public.redis_table (<= /div>
=C2=A0 =C2=A0 id text NOT NULL COLLATE pg_catalog."default&q= uot;,
=C2=A0 =C2=A0 value text NULL COLLATE pg_catalog."defa= ult"
)
=C2=A0 =C2=A0 SERVER redis_server1
=C2=A0 =C2=A0 OPTIONS (database '0');
=C2=A0 =C2=A0=C2= =A0
- In the validation error messages, please replace ! with . a= nd "can not" with=C2=A0
=C2=A0 "cannot" for c= onsistency with recently reviewed strings.
=C2=A0=C2=A0
- s/mulitple/multiple (in the js).

- How do I man= age the ACL?=C2=A0

Thanks.


--
Dave Page
Blo= g: http://pgsnake= .blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--001a114a6b20c5254b05327ae1e4--