public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
Date: Sat, 4 Feb 2017 14:04:42 +0000
Message-ID: <CA+OCxoz2i3rmquJELdjsdNgvPrYax5T5fNggxSk1M3ahkrxOrA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowUKoSpsKfyAj7-xtvC83KFaKi1C-xtzajPX3vfQFpM0A@mail.gmail.com>
References: <CAKKotZQm+_1amWAvuH3n-hYVdi98pykAz1PRy2fcnYkoi6PzNQ@mail.gmail.com>
<CA+OCxox0BPEd+7iUznLvPkyohOf7ur+c8uov3MPXur3O2JGdCg@mail.gmail.com>
<CAKKotZQmuH7Vm8on6BL9Bdv96wY53mpcFx5Nz_B5iEna6JhoSg@mail.gmail.com>
<CA+OCxow47n8-xX-+docKe8vBhL_+=-UYQ4XkrnY2sD-yAzLabA@mail.gmail.com>
<CAKKotZSt-ypD=nu7YGrpSGJ5BWvAUNBzFpAhUAv-21DXoO4pyw@mail.gmail.com>
<CA+OCxowUKoSpsKfyAj7-xtvC83KFaKi1C-xtzajPX3vfQFpM0A@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Murtuza,
I clearly neglected to run the regression tests with this patch, and
unfortunately it looks like it broke them. Can you look at this ASAP
please?
runTest (pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase)
This function will add column under table node. (Add table Node URL)
... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query
(execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id:
4792242):
Error Message:ERROR: syntax error at or near "False"
LINE 2: ADD COLUMN test_column_add_f0d5d char(False);
^
FAIL
As far as I can see, the app works fine - it's only the test that
broke (probably because the application uses type name aliases (e.g.
character) rather than the base type name that the test is using
("char").
Thanks.
On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <[email protected]> wrote:
> Thanks - patch applied.
>
> On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala
> <[email protected]> wrote:
>> Hi,
>>
>> Please find updates patch for the same.
>> RM#2076
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <[email protected]> wrote:
>>>
>>> Hi
>>>
>>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala
>>> <[email protected]> wrote:
>>> > Hi Dave,
>>> >
>>> > PFA updated patch.
>>>
>>> This seems to display "timestamp(0) with[out] timezone" columns
>>> correctly in both the properties panel and dialog now, but the size is
>>> still ignored if I try to add a new column through the table or column
>>> dialogue.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
In-Reply-To: <CA+OCxoz2i3rmquJELdjsdNgvPrYax5T5fNggxSk1M3ahkrxOrA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox