MIME-Version: 1.0
In-Reply-To: 
 <CAHowoHY1hq-+ibR-+jkQxtGUr9T0Ov0XbFp6hW=KbV-euh=wZQ@mail.gmail.com>
References: 
 <CAHowoHY1hq-+ibR-+jkQxtGUr9T0Ov0XbFp6hW=KbV-euh=wZQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 12 May 2017 15:37:51 +0100
Message-ID: 
 <CA+OCxoz2k6PjgGXo4H+h6JozOvLy5C_uGxU7+CjxVs0LoKL+zQ@mail.gmail.com>
Subject: Re: javascript and css minification process
To: George Gelashvili <ggelashvili@pivotal.io>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="94eb2c054954779aca054f54a6a6"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c054954779aca054f54a6a6
Content-Type: text/plain; charset="UTF-8"

Hi

On Fri, May 12, 2017 at 3:29 PM, George Gelashvili <ggelashvili@pivotal.io>
wrote:

> Hello
>
> We're looking at the js and css minimization python code to investigate
> minification as part of the pgadmin artifact build process.
>
> We're wondering why minimise.py is currently only manually invokable, via
> the minimise make step.
>
> Also it seems like currently, minimise.py's dependencies (rcssmin and
> rjsmin) are not being included in any requirements.txt
>
> When is the minification performed?
>

It's not yet. Those are utility scripts that I was eventually intending to
call from appropriate make targets during package build. Before we get
there though, we need code changes to ensure that we load minified code vs.
debug code at the appropriate times. I haven't done much with it in a while
as Tira had been talking about transpiling everything into a single blob
(though that required us to ensure none of the JS files were Jinja
templates any more).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c054954779aca054f54a6a6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Fri, May 12, 2017 at 3:29 PM, George Gelashvili <span dir=3D"ltr">=
&lt;<a href=3D"mailto:ggelashvili@pivotal.io" target=3D"_blank">ggelashvili=
@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div di=
r=3D"ltr">Hello<div><br><div>We&#39;re looking at the js and css minimizati=
on python code to investigate minification as part of the pgadmin artifact =
build process.</div><div><br></div><div>We&#39;re wondering why minimise.py=
 is currently only manually invokable, via the minimise make step.</div></d=
iv><div><br></div><div>Also it seems like currently, minimise.py&#39;s depe=
ndencies (rcssmin and rjsmin) are not being included in any requirements.tx=
t</div><div><br></div><div>When is the minification performed?</div></div><=
/blockquote><div><br></div><div>It&#39;s not yet. Those are utility scripts=
 that I was eventually intending to call from appropriate make targets duri=
ng package build. Before we get there though, we need code changes to ensur=
e that we load minified code vs. debug code at the appropriate times. I hav=
en&#39;t done much with it in a while as Tira had been talking about transp=
iling everything into a single blob (though that required us to ensure none=
 of the JS files were Jinja templates any more).=C2=A0</div></div><div><br>=
</div>-- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail_signatu=
re">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_b=
lank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>Enterpris=
eDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://ww=
w.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--94eb2c054954779aca054f54a6a6--