Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAsnC-0005Wg-PK for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Aug 2020 10:36:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kAsnB-0006Rn-6n for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Aug 2020 10:36:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAsnA-0006RX-TA for pgadmin-hackers@lists.postgresql.org; Wed, 26 Aug 2020 10:36:33 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kAsn8-0007pd-9I for pgadmin-hackers@postgresql.org; Wed, 26 Aug 2020 10:36:31 +0000 Received: by mail-ej1-x644.google.com with SMTP id si26so2108932ejb.12 for ; Wed, 26 Aug 2020 03:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nAwGIerUD3xOy2I/4fXcjmjvHt/uzvoeSITVuzsKQe4=; b=QBJqmQw/crnC5w1dbVS/E5Y8Smg7NtNWOuKixrQLCBk4aFepG32FK7yGuGOl7H1UDT Xwj0k9PnvMqH3MTF4mu7/l0MzJNnwA28Pm5MTG8hKhEfwb17chdRNmubz5bIi3Q4CXKN WDT80Fqlea+OCx1S/P5bVg06E+IcGLluYHlZ+eYjZvGRrGTQVB5IF3jNxZzK1c9AN5VK rACISxq3k4YZj7lhbU43SAU5ZHjIDkp2W2BCFMb3gM1uhEhEtz+MvaK6DrGduJDgYCdh 8WpDHIwDpMA1w4U311VXUhNNKY/EVnaAiwIUE+FhV8vR9ibY60errtEdDZy8GylbYsKE syfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nAwGIerUD3xOy2I/4fXcjmjvHt/uzvoeSITVuzsKQe4=; b=He5etEFzHoNJwTGLWBm80qJz7j3hge5pO7uk0cwmbVBgs+lpwelXoi221Jf4h+Gy0Z mkICHGXHNX8AnI2BF4C70pFDGoHV2yNngeN9U5txQvh/7/bBXW38lA3PlJMWVVOonbOT rgWwpZ2GEUIdkwOXHeTrTcwH1iKyrNuJ/daKEXnAN/YYI8VGqeajpp6anpCu2BtGweec 7nGAGJnJAqTCXGgvoHmDzEYtKj7ejrzazXTQD6iQ1VVT0qwxWmdrCdSDrzoC7I1EyR2v v5kd0FCXuza3C8XlNXw+qt+kEwXu1viUjhAtvPQ6C6XD9f32cOYvKS/KYws/RsnbCSaF w0ig== X-Gm-Message-State: AOAM530VgDWF8obYcoHefGN//5zWJl4efQtK+SLbL0rf87UESIfNFevK c97M0CbzOI8D+wKQfXVxQOovBX9sRzcFL1gdKiq+QA== X-Google-Smtp-Source: ABdhPJzhGKxbDMsNevwEM6LA8ebbzwHBJcgO/piq+osYkJ5sHgVe+n2rbOWoKHZ4PThPO9su1d1vDBg2yvP6ixH1g2w= X-Received: by 2002:a17:906:f8ce:: with SMTP id lh14mr6676714ejb.89.1598438188417; Wed, 26 Aug 2020 03:36:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 26 Aug 2020 11:36:17 +0100 Message-ID: Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006a9bca05adc5647a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006a9bca05adc5647a Content-Type: text/plain; charset="UTF-8" Thanks, applied with a few changes for consistency in the titles and 404 handling. On Wed, Aug 26, 2020 at 8:23 AM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Dave/Team, > > Updated the implementation for the set title of the page, for this, I have > done a few changes in the flow. > 1. Earlier we are using {% include %} for showing pages in the base > page (styleguide/index.html) for a style guide but in the Django template > we can't use {% block %} statement if we are adding page using "{% include > %}". > 2. To overcome this issue now using {% extends %} instead of {% include > %}, For this added dynamic URL generation in views so instead of loading > "index.html" of style guide we are loading specific component HTML file > (e.g: typography.html) and that template extends the "index.html" of the > style guide. > > PFA v6 patch for the same. > > If required any changes please let me know. > > Regards, > Nikhil Mohite. > > > On Tue, Aug 25, 2020 at 7:09 PM Dave Page wrote: > >> Hi >> >> On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> >>> PFA v5 patch for the same. >>> >>> if required any updates in this please let me know. >>> >> >> Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content with >> code. >> >> The titles should be defined in the HTML pages themselves. We do that >> everywhere else by including a template block like the following in the >> lowest level content: >> >> {% block title %}Contributing{% endblock %} >> >> And then in base.html: >> >> {% block title %}{% endblock %} >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --0000000000006a9bca05adc5647a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied with a few changes for consistency in the = titles and 404 handling.

On Wed, Aug 26, 2020 at 8:23 AM Nikhil Mohite <<= a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohite@enterprisedb= .com> wrote:
Hi Dave/Team,

Updated the implement= ation for the set title of the page, for this, I have done a few changes in= the flow.
1. Earlier we are using {% include %} for showing page= s in the base page=C2=A0(styleguide/index.html) for a style guide but in th= e Django template we can't use {% block %} statement if we are adding p= age using "{% include %}".
2. To overcome this issue no= w using {% extends %} instead of=C2=A0 {% include %},=C2=A0 For this added = dynamic URL generation in views so instead of loading "index.html"= ; of style guide we are loading specific component HTML file (e.g: typograp= hy.html) and that template extends the "index.html" of the style = guide.

PFA v6 patch for the same.

If required any changes please let me know.

Regards,
Nikhil Mohite.


On Tue, Aug 25, 20= 20 at 7:09 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Aug 25= , 2020 at 12:49 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:=

PFA v5 patch for the same.=

if required any updates in this please let me kno= w.

Hmm, yeah - that doesn= 't work for me I'm afraid; it's mixing content with code.
=

The titles should be defined in the HTML pages themselv= es. We do that everywhere else by including a template block like the follo= wing in the lowest level content:

{% block title %= }Contributing{% endblock %}

And then in base.html:=

<title>{% block title %}{% endblock %}</= title>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterpri= sedb.com



--
--0000000000006a9bca05adc5647a--