Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evY7D-0005Mi-PV for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 00:48:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evY7C-0007eH-A1 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 00:48:30 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evY7B-0007dd-TM for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 00:48:30 +0000 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evY73-0001W5-Ua for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 00:48:28 +0000 Received: by mail-wr0-x243.google.com with SMTP id o8so17834485wra.1 for ; Mon, 12 Mar 2018 17:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=czPgqM2gfhiyhJhv772gS5eXr8g5qKMDa5RYk1AFJgs=; b=0mHiE/jjfEupKCrtEi+ckAhVHa5q5C1q05ulu4cjfREkCiMqfGX0R1OxRVKrbaSE5R +BTeNsnjYl9lM647oPXRC9NAKIcWYbX2B+qLnKPyYKIl/q0iXWpIOgvcFt+bAY5FMFCX mx2uhGOoz0uN8kdYKx1C6IjtCk0H/niW9R4LXhMHQDXgHQXj3DV2NqmMcEyhasG1dJQU cIGnF8udnMXPqaglpD12r+0jP5/bhyqKgL11f5sWZFtA3oXGAgjdVIjj6oULF/2iFXJ5 ATxM5e2nYHyOagqlG9VFNV0laEqqqgRPf2A4NVz4US6UJStPgZFBladV33vM/nG5SYH4 ZL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=czPgqM2gfhiyhJhv772gS5eXr8g5qKMDa5RYk1AFJgs=; b=DHB1fYvJgq8GeQ4GjOW4SPjmG/y7PnDALqDbi3bAuHYxeSb5vEffWKxYL/VnPysC7s xdEvL+QmzzB30T4tf8sLgAJ60YnsF9NRsxnQKksWZKYVjUZ2VvVGGxJcQDot2cFf0MAn S6E6Dtig2+h726j1NiV5GsJvJ/PLNkLpeCLR8+Z3EYhvByAPxDaBpnUuB7dEBkpsf+E8 TDfWQCIsxD1g3eFxRA1bR7C4Zj+wpalXSkMIJ9MAyaNUnjIGtxF9h5uKJgId6cAePXDp aQEMGEe7GZO7Kjec+V2qg2KIlnIAzAaQHu1L5HELFfNGsrO/iYiXkXmrbt/EnpY8xP+e GzGA== X-Gm-Message-State: AElRT7FcOFuwx/dcBbVtEUCyqTtyqKZ8ZxB/bf4SmZ3QbqyNwrKMOMC1 MApzth030Z0pG5wP6y8BlAEXk7AkUSs1KnJ2asfULQ== X-Google-Smtp-Source: AG47ELv1QUs22UGWkFf0lRCyWl52XV9fAXWiM85TMRxUX0uA6QIl8RdwChkV0R+4JHmSDMRZffxnBzKBuGsHU23T8iI= X-Received: by 10.28.167.151 with SMTP id q145mr7681738wme.64.1520902099963; Mon, 12 Mar 2018 17:48:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Mon, 12 Mar 2018 17:48:19 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 12 Mar 2018 20:48:19 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Joao De Almeida Pereira Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114b3cd46829610567409da4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114b3cd46829610567409da4 Content-Type: text/plain; charset="UTF-8" Hi On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Dave and Murtuza, > > Regarding this patch we refactored the Javascript code so that is lives in > a different file and added some tests. > > Also we found an issue with karma-jasmine that does not allow us to use > jasmine 3.1 yet. You can find attached a patch that reverts that commit. > Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example. Can you rebase please? Thanks. > > Thanks > Victoria && Joao > > On Mon, Mar 12, 2018 at 4:46 PM Dave Page wrote: > >> Thanks, patch applied! >> >> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA updated patch. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala >> enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> I'll change the name and send you updated patch. >>>> >>>> >>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >>>> >>>>> HI >>>>> >>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala >>>> enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch to add service parameter in server dialog. >>>>>> - Docs updated >>>>>> - Test case added for Service ID parameter >>>>>> >>>>>> Please note, >>>>>> I have extracted Connection class and Server manager class from our >>>>>> own custom Psycopg2 driver module. >>>>>> >>>>>> Patch also covers RM#3120 >>>>>> >>>>> >>>>> This patch seems a little confused. The "Service" and "Service ID" >>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>>>> to be asking for the Service field (the pg_service.conf service name), >>>>> *not* Service ID (the operating system's service ID, used to start/stop the >>>>> database server service). >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114b3cd46829610567409da4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave and Murtuza,

Regardi= ng this patch we refactored the Javascript code so that is lives in a diffe= rent file and added some tests.

Also we found an i= ssue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You = can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, th= e Jasmine one looks entirely backwards). One of the error messages was chan= ged in Murtuza's patch, and wasn't reflected in your update for exa= mple.

Can you rebase please?

<= div>Thanks.
=C2=A0

Thanks
Victoria && Joao

On = Mon, Mar 12, 2018 at 4:46 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:= 31 AM, Murtuza Zabuawala <murtuza.zabuawala@enterpri= sedb.com> wrote:
Hi Dav= e,

PFA updated = patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I'll change the name and s= end you updated patch.
<= div dir=3D"ltr">

<= /div>

On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).

--
Dave Page
Blog= : http://pgsnake.= blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114b3cd46829610567409da4--