Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMIg-0004Xn-35 for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 10:01:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gfMIe-00049k-Dk for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 10:01:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMIe-00049d-81 for pgadmin-hackers@lists.postgresql.org; Fri, 04 Jan 2019 10:01:56 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfMIb-00086a-Gt for pgadmin-hackers@lists.postgresql.org; Fri, 04 Jan 2019 10:01:55 +0000 Received: by mail-wr1-x442.google.com with SMTP id p4so36096989wrt.7 for ; Fri, 04 Jan 2019 02:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CQuYy6IQskbOX5EWGLK0JVuU0Iq/CEEnVwhhKdKh3sQ=; b=K+TpiIpVKfQ8IUNDd69WsT8nuMqOPWUPHTB4aI6ufchThqrAT2vnQ7BTUDkdhtv188 ngbFrz9cRdWofycb7fb77ZSyJjVF32b6WQvq6LyC5cXL+WmjNe7GkNGEZexdB/smwJ8a iyQm/OhyJn34qZhXuWutXC4yR0giHcXuxwsPVm/SWp39GBLE84R/IsvTnYB8fq+uiKLV xvtaSsGVROpHFeXj6kz5zlYA6Id1MxLyNj9nJMgmktcoUqq5fjnPBfQGpy4spIBeEMPJ Nf3G3E/SN+0wkapzWNHVCiMoUN7igocgo5nxC5Pz+LzxSBg9Xc/NVaeGTAo7rqOfwS0n KnkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CQuYy6IQskbOX5EWGLK0JVuU0Iq/CEEnVwhhKdKh3sQ=; b=QO5UYWlfckfrUAoQgEe+8lBWqmY2PRXTWJ9npiQxKUNv2SPMOXYv9EnUpckimRx5Ei MN1nGmcObhpSnVfr9Bm0KrR2LI3/981HnRfRyWt0M+5aqI3MNUBQ8jLaXADHWh20uLk9 4nAw+v2Ssy65uddY7I1uSWf6jcXlO2lpzlPNYO+LECu2A/LdX3sCubraeitP+OMkuJVm J8dYXYEIwAfXzjcrLVCrId/e0UIkm6+PMhb4r2TbbT4qhU/cOUE6huTn3jxk1fR8i79E PHbU21hIMG2dzPbWo+fNTOeZ8p2eecSmnVOr6KwjaMSauvqK+/F5kQpvWZFrqsZ4oGcq SSkA== X-Gm-Message-State: AJcUukexhRVpcJEH7eDiBcuimO8WjqGachr3TSrPM8YbmDOrdJoI1JyH oYNWUXzJ3QUlkFqkaQ3tK1H4AhCQTeP7hRvXWDB4Eg== X-Google-Smtp-Source: ALg8bN71rIHAMfEmFJKXrEM9X/C2PAccJAcWzTX+JuIfsFlmS1LvM7W79LPS79jWQk3FR4HcYc/YbyceNZOvBzZyKzc= X-Received: by 2002:adf:97d1:: with SMTP id t17mr43311810wrb.283.1546596112085; Fri, 04 Jan 2019 02:01:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 4 Jan 2019 10:01:40 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal wrote: > > Hi, > > On Fri, Jan 4, 2019 at 2:53 PM Dave Page wrote: >> >> Hi >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal wrote: >>> >>> Hi Dave, >>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page wrote: >>>> >>>> >>>> A few other things that I noticed (or have been bugging me): >>>> >>>> - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40p= x and setting the font-weight to normal on the menu options (but not the pr= oduct name) seems much better to me (and adjusting everything else as requi= red of course). >>> >>> Giving too much space for the navbar will reduce the usable space for o= ther things. It is good enough(32) to be used easily, and is equal to all t= he other headers in app (including tabs) giving a feel of native desktop ap= plication. You'll find even smaller menu heights in native desktop applicat= ion. We can make font weight to normal and may be slightly increase horizon= tal spacing between the menu links. >> >> >> 8 pixels isn't going to make a noticeable difference to the workspace fo= r users, and would leave the bar smaller than the 50px it's been for the la= st couple of years (iirc). I think it needs it to avoid looking cramped - p= lease make the change. > > Will do. > One more doubt regarding bold headers, should I remove bold headers in da= shboard graph header, subnode headers (eg.table->columns), properties tab a= ccrordian headers ? No, please don't. I left them bold and the styling seemed like it worked. We can tweak again if others disagree later. Thanks! BTW - Chrome 71 shows the offset headers in the file dialogue as well. >>>> >>>> - In the file dialogue, the column headers don't line up with the colu= mns in the rows. >>> >>> I could not see this on my machine (screenshot attached). Could you ple= ase share the screenshot. >> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company