Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv813-0000Oy-2K for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 19:19:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bv812-0001Ep-LM for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Oct 2016 19:19:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bv80o-0000uH-Da for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 19:19:22 +0000 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bv80l-0002pB-5f for pgadmin-hackers@postgresql.org; Fri, 14 Oct 2016 19:19:21 +0000 Received: by mail-io0-x232.google.com with SMTP id r30so131342068ioi.1 for ; Fri, 14 Oct 2016 12:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cx2VIqM2/Tk0P64PI7TMv1jUbFZ1yqTh8tuaNFT6/Po=; b=zpYmkPbHdElVzQw2kI8WvQvaI59YuS20381OmeNBGMFbK8fHtqdyIaHFtDjS/PpehZ jlY/jH1cXxpic752udQl6fU+ZjiBjWyjDxiAtEw5nLk8erDn4dw+F5d5mdGOs7fZzVE0 r6P0+Qo3V360kYAMCv6aZDqFEn8KhlCpcyIA+6bDjyw60pBBvFi4KGroUkl8iQaVnHn+ c+n9gdpOMXGtzGOyV/QbU1jXRKLH8ZSYKXr/MMuQBqgiEr9vyZ7zK5KpcpQx/4TetgF1 U4+wNzjcFacYIbrUjdBC6aJZqQQt758ww0z+UAamBk1pJm6L3ND2iXb+x0xgiABtZoFO xd9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cx2VIqM2/Tk0P64PI7TMv1jUbFZ1yqTh8tuaNFT6/Po=; b=VU2vUrADnO0kutZMdv8jWYtjsShSb/+iRhT5s+C5nxxa/tv/G0HTwWpuYv0dK/LtKL Flfz+d/KW+95T7hNuaGlscikYNlyFISobfYrMc/MHF53TykrffDy1zF1IxZZ4E7FZLV+ ocFjDyDTm6yFGwMJuo+BNeB0oijSnN/KF66hRvJTCl/L2I0sPhVUvERZIUlMCMQzpMwx D6nnWyNPwIWX8e4sNHwohZo9BREaVWXlHfZqldd54yLnpt3YXjssq6nTW0k6z3XLB4AV r4VJ5F2JK5N8mNY8nSvWRGM0Zb8Tw8XOdvHyTllGk7hyhqknOJ0J9UD99auiXtr62obO B6Ng== X-Gm-Message-State: AA6/9RnmnV2K0xqE33w9P0R59+YvLm6Ymz+r0TFWazgcHUS/WqalPDAS+Kfnm+YAqjrJQBOsOnwyc50EU6Na0Q== X-Received: by 10.107.11.98 with SMTP id v95mr13501172ioi.145.1476472758249; Fri, 14 Oct 2016 12:19:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.146.135 with HTTP; Fri, 14 Oct 2016 12:19:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 14 Oct 2016 20:19:17 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f911046dc7f053ed81a4b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f911046dc7f053ed81a4b Content-Type: text/plain; charset=UTF-8 Thanks, applied. On Friday, October 14, 2016, Surinder Kumar wrote: > Hi > > *Following are the issues fixed in nodes:* > > 1) If we create/update a node with non-default schema, It should return > selected schema id in return response. but default schema id is returned > every time due to which it throws error in properties panel. > Fixed in Domains, Collation, Types, Views & Table node. > > 2) Incorrect parent id of object node is returned from *nodes method* due > to which wrong parent id is passed while updating object and > thus node didn't get refreshed. > Fixed in FTS Configuration, FTS Parser nodes. > > Also, I have kept changes of first patch which are essential to refresh > node every time. Without that patch nodes properties panel updates only > sometimes. > > Please find attached patch. Please review and let me know for comments. > > Thanks > Surinder Kumar > > > > On Fri, Sep 23, 2016 at 6:00 PM, Dave Page > wrote: > >> Umm, no it wasn't - sorry. >> >> I see the same issue with Types. Can you fix that, and check all other >> nodes as well please? >> >> Thanks. >> >> On Fri, Sep 23, 2016 at 1:29 PM, Dave Page > > wrote: >> > Thanks, applied. >> > >> > On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar >> > > > wrote: >> >> Hi, >> >> >> >> Please find updated patch with changes: >> >> 1) On debugging through JS files, the issue was in synonym update >> method >> >> which wasn't returning node object. >> >> 2) retrieving schema name in node.sql for creating node object in >> update >> >> method. >> >> >> >> Please review and let me know for comments. >> >> >> >> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page > > wrote: >> >>> >> >>> Hi >> >>> >> >>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar >> >>> > > wrote: >> >>> > Hi >> >>> > >> >>> > Issue: >> >>> > on updating node, we deselect and then again select the node >> updated to >> >>> > refresh the panel. but it needs some delay of few milliseconds >> between >> >>> > deselect and select to fix this issue. >> >>> > >> >>> > Please find attached patch and review. >> >>> >> >>> This does not resolve the issue for me. I tested using a synonym to a >> >>> package on EPAS 9.5, by changing the target package name. >> >>> >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> > >> > >> > >> > -- >> > Dave Page >> > Blog: http://pgsnake.blogspot.com >> > Twitter: @pgsnake >> > >> > EnterpriseDB UK: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113f911046dc7f053ed81a4b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks, applied.

On Friday, October 14, 2016, Surinder Kumar <surinder.kumar@enterprisedb= .com> wrote:
Hi

Following are the issues fixed in nodes:=
=
1)= If we create/update a node with non-default schema, It should return selec= ted schema id in return response. but default schema id is returned every t= ime due to which it throws error in properties panel.
Fixed in Domains, Collation, Types, = Views & Table node.

2= ) Incorrect parent id of object node is returned from nodes method d= ue to which wrong parent id is passed while updating object and=C2=A0
=
thus node didn't= get refreshed.
Fixed in FTS Configuration, FTS Parser nodes.

Also, I have kept changes of first patch which are es= sential to refresh node every time. Without that patch nodes properties pan= el updates only sometimes.

Please find attached patch. Please review and let me know for comments.

Thanks
Surinder Kumar


<= br>
On Fri, Sep 23, 2016 at 6:00 PM, Dave Page <dpage@pgadmin.org> w= rote:
Umm, no it wasn't - sorry.

I see the same issue with Types. Can you fix that, and check all other
nodes as well please?

Thanks.

On Fri, Sep 23, 2016 at 1:29 PM, Dave Page <dpage@p= gadmin.org> wrote:
> Thanks, applied.
>
> On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>> Hi,
>>
>> Please find updated patch with changes:
>> 1) On debugging through JS files, the issue was in synonym update = method
>> which wasn't returning node object.
>> 2) retrieving schema name in node.sql for creating node object in = update
>> method.
>>
>> Please review and let me know for comments.
>>
>> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
>>> <surinder.kumar@enterpri= sedb.com> wrote:
>>> > Hi
>>> >
>>> > Issue:
>>> > on updating node, we deselect and then again select the n= ode updated to
>>> > refresh the panel. but it needs some delay of few millise= conds between
>>> > deselect and select to fix this issue.
>>> >
>>> > Please find attached patch and review.
>>>
>>> This does not resolve the issue for me. I tested using a synon= ym to a
>>> package on EPAS 9.5, by changing the target package name.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--001a113f911046dc7f053ed81a4b--