Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glugS-0004co-PF for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:57:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glugR-0005sO-HP for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 11:57:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glugR-0005sB-Bi for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 11:57:35 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glugO-0004dy-Bp for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 11:57:34 +0000 Received: by mail-ed1-x542.google.com with SMTP id h50so19070222ede.5 for ; Tue, 22 Jan 2019 03:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8T2TqXeg6lkwiXx7k4D7ql22VGqNNPRGmRhjRlSSvh4=; b=Y5tFjiMTtslQck9Kv3x6Xm5uG2oeQNYFF5d6I/Qp35+wt8GC22iRTRu2X4iinIyblG U1vdR2ielTBGowkt3JR+PSVPx/xAseU06Yzfxki/3PwaA5ov0OU1NuwctbXQO9aTSwG9 Igpb9kQA1yoOqsmxVqCXTZaWz8/2pOFRKvqDZDCBGAGdkzaqf40jSSXuGXNDDPCNmAdZ P1xXT5JUIGZxjrirODxOcz/AQ/F39vhOu7sIUcicnVpOmZCWR2d1pfZny6yh2eOr6Mkj ja9mNqoKoqp6PflJ+dE1/wRjQ4WHWaANkZl/mSSqzK27ua/8kUWhA2Ka3gwvlPywizH2 DyOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8T2TqXeg6lkwiXx7k4D7ql22VGqNNPRGmRhjRlSSvh4=; b=ZYD8FB6aZXv8pmdpWiGEzZeaUzd+N8h2LzoQvF1jeodGt6kZH5Lr8OnIZKo6mz4JkB teOA/piFdW/DXTs5imO48rwSWJqalYhIxcjdwKVeW7KwDmd7kGh5+mcuAssYk4gtISsj 8sKRlQiUhlqAUM+C47b8GKFc3SC3/IsQdd18fX+aQ2PbD1loBc0zVF5NlGn0mFH3fKHj ml174nIviU/U372ksNdAJGL1ZXuhCt6V5O6aGffcDbibEqksThHOmiRokUhVnRLu/SCW IrDTF2JL1vWQnQ95kbcSQKdKqG5igXcFpFnqp59Oq54KtFKx0TmcFmUNeJvpaQXIkXDv cYwg== X-Gm-Message-State: AJcUukfvTsnaSyfQg9upYVgyD+c4ul0XBN3Mssk9QtyLmjq9b01VROUI GmVcgCPn4A8iJNOu/n7fMfXrd987h5HElEsV2BnIQhKkyNvEPlJWybGJara6vJcr3MAsdzMWO1X kse0fEAA/Dajr4mrFPl1fK/fx41N1UUEsM4imGTNOWRxpizHbBXvp3H0TEvHmJHpNUB/BBSIgEr +nSuUKQlHJLOA= X-Google-Smtp-Source: ALg8bN7PeHM+RNa6NdD6yxEohw14tJsITxdOj1pLoMwuApxox+esV1hFsa82RLlqril1x6G0Hf/4uw== X-Received: by 2002:a50:8907:: with SMTP id e7mr30967808ede.252.1548158250507; Tue, 22 Jan 2019 03:57:30 -0800 (PST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id i24sm9300369edq.0.2019.01.22.03.57.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 03:57:29 -0800 (PST) Received: by mail-wm1-f46.google.com with SMTP id g67so13872691wmd.2 for ; Tue, 22 Jan 2019 03:57:29 -0800 (PST) X-Received: by 2002:a1c:7719:: with SMTP id t25mr3636918wmi.7.1548158249167; Tue, 22 Jan 2019 03:57:29 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 22 Jan 2019 11:57:18 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal wrote: > > Any suggestions on preferences name/desc ? Name: "Confirm on close" Desc: "Confirm closure of the browser or browser tab is intended before proceeding." > On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: >> >> Hi >> >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi >> wrote: >> > >> > Hi Aditya >> > >> > Below are my review comments: >> > >> > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this. >> >> That does seem like something that should be a per-user preference, >> not a global config option. >> >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users perspective, can you please change it to some meaningful name. >> > >> > Apart from that code looks good to me. >> > >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal wrote: >> >> >> >> Hi Hackers, >> >> >> >> Attached is the patch to throw alert warning when user reloads or closes the browser. >> >> >> >> Kindly review. >> >> >> >> -- >> >> Thanks and Regards, >> >> Aditya Toshniwal >> >> Software Engineer | EnterpriseDB Software Solutions | Pune >> >> "Don't Complain about Heat, Plant a tree" >> > >> > >> > >> > -- >> > Akshay Joshi >> > Sr. Software Architect >> > >> > >> > Phone: +91 20-3058-9517 >> > Mobile: +91 976-788-8246 >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake