Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fZzxA-0006He-8x for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Jul 2018 14:37:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fZzx8-00015f-BK for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Jul 2018 14:37:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fZzx8-00015Y-37 for pgadmin-hackers@lists.postgresql.org; Mon, 02 Jul 2018 14:37:18 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fZzx4-0002r3-AY for pgadmin-hackers@postgresql.org; Mon, 02 Jul 2018 14:37:16 +0000 Received: by mail-wm0-x231.google.com with SMTP id n17-v6so9007473wmh.2 for ; Mon, 02 Jul 2018 07:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HFytvgn6KTakLmDatKkpRPDru6vB0esbQyv6CAvU428=; b=Oxt00iOf6o9zOtpDcExgZvagKZUPDMHM9mMG8XA8QYKEkjHNpfE1lKpevlz0bxjkmX HPb9kE1WPaKGLSapETkZMeywhNG6qs0jbgF97X+55rm/NJuC+RQcy4QqymKvDYFwQ6tw jRSgdAeOLLUgUsuVE4TJdMreKoHWjpU1jY4G5lVfOm0ZH1UHXzryGNkG4cBrMvC+5gg4 j8D3zNovdU6kWdbw/MF4hgQjU5KLZlwlF8qzbn46jyrzNki6N05MBa2pODDT/TLPRa+M A8r/hNdGjzyj2J7XT/7fA4Ldo78FbYKw8tcDBYk1gpEBdpJE7ZNqiVt7uzKap9O4Jd9W HNIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HFytvgn6KTakLmDatKkpRPDru6vB0esbQyv6CAvU428=; b=KRHre6BEEJw15VvKZtfKq17y6De5XfHo+1/S+a1a5l1l1rngat0f5QYUuGUPaskMUU RIELej1S6NbI+t79XIlzSFps1xNUcFKSbTIarANbmL3uubyUCPYZksTSgmK/O5WCvVop d5z2zr3w4VBRv8V8K1Wa5tFcRiwvI2VGMTyrarWgnYQAnqOf/YrvGyYKb2n0mzLRk9UN c/pnei3oAL2bT9w7WsEFrIT4tM0hQxM3e4o2ITnkRUlfzJuXcLzmxhqhwgHTRoumbOCE 7AbP3IeBNUS6k/qBuFh8E6KzmnsTehvonCXJUNnxWMuP1ysQayTBtsEA+43hJbAxRFYf bHGA== X-Gm-Message-State: APt69E0K7VZalydOcRj5Iceq1O3RlaP0SoGdAGQZnhwRD1e6vf+nOdE9 fa5gVnX2mnfhd751TJ0r9MGUsPdv2ol2Jdnv1JmIOQ== X-Google-Smtp-Source: AAOMgpeoh1LzfWq9RqIAYBKTRyFwIbz1bwaafxyoqCM0Nnksz5H3W4wJuEN8bMTr33j8RaN5t2A4eDXO3FVehHRjf2w= X-Received: by 2002:a1c:94f:: with SMTP id 76-v6mr8537353wmj.86.1530542232409; Mon, 02 Jul 2018 07:37:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 07:37:11 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 2 Jul 2018 15:37:11 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000013a93505700522f0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000013a93505700522f0 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Jul 2, 2018 at 5:58 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where cancel button remains enabled even after > the query execution completes, I have moved the enable/disable logic for > that button with rest of the buttons in '*disable_tool_buttons*' method & > removed tests which are not required as we are already testing ' > *disable_tool_buttons*' method. > > *I had to fix it coz it was annoying me :)* > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000013a93505700522f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Mon, Jul 2, 2018 at 5:58 AM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi,

PFA patch to fix the issue wher= e cancel button remains enabled even after the query execution completes, I= have moved the enable/disable logic for that button with rest of the butto= ns in 'disable_tool_buttons' method & removed tests whic= h are not required as we are already testing 'disable_tool_buttons' method.

I had t= o fix it coz it was annoying me=C2=A0:)<= /i>


--
Regards,
Murtuza Zabuawala
Enterp= riseDB:=C2=A0http://www.enterprisedb.com
The Enterprise Post= greSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--00000000000013a93505700522f0--