Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etXYH-0001XY-VG for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 11:48:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etXYG-0000nh-Ci for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 11:48:08 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etXYF-0000nT-UR for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 11:48:08 +0000 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etXYB-0004jT-TI for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 11:48:06 +0000 Received: by mail-wr0-x243.google.com with SMTP id u49so1845873wrc.10 for ; Wed, 07 Mar 2018 03:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HBz1dmavzcrjS1KRZGu8HxU7L0HiZ87Nt6RZqqUNoaw=; b=QDyfi3h1EVzx/ReWspCwz+/C/gZgv/1BOXZsc9apOevwBJa193bykD/aHH54X6QD/N XNAMyKu9n8JnPy7O+FJ36jac/BT3vjXvHNVN4MO0xWLUloQGh7vVfbrhWSIu61OdmDxt qxLENh2rHbD+k4Ttu18A6itIg/S2qXeQzrY+z2RTtynRxjaalM7HWRh+xDiZ/aG2f4F8 ErjOe5qXuyaAoeNs7OOUlrEpyxN1EiaBkn65zLVMBu2lQD4ddKCPpvh+eiIuhI4rVJaY AgBqQBiS3i9Kiw2M2rMzjko7bdho7ZmGaLvuDFT3UyZKWCHEqPci1paXub7BN2GqOGxW LHWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HBz1dmavzcrjS1KRZGu8HxU7L0HiZ87Nt6RZqqUNoaw=; b=jr7pgVal2ymOKdyyDIyalqVStWbA+0OipJ40UWChAenKsJYq+8LnYMJ0YhDUfzvp3H BbJbs6MYZ5R9eQArbj0VxxB/eKOFWx7qrQcB9ieQmSxxgp+fG5ey4OeBBIhhq4pdctsD VD6uxI1Vf+91zWAB8LkYkAwNEXo/p0OPjcl8RqBjfKm2ue1lItaE40RMODPylVArwRVI Y61mApKW3uMuZhy0s39/5+zRNom4buhjL+HAMK0YC2y/0wdGvWoj5sKhkKNe6sRinqfj QQ0p5MxQMjT5in4D8FebdUxJ+gG84yJ/R7JHTT+bevYRUSQBOVqZTJKtYnQnZBjVS+BK aB9g== X-Gm-Message-State: APf1xPALyIAUaydeo6c77WAJfDhuwKX/gBTQe+QKhErEBUfF3Dr0vNtK mrlBO8xzKY1fordvgtuXuBAjiIdsx5yC4t8o25D8GQ== X-Google-Smtp-Source: AG47ELs7NrtqyWpWMfyns8T/rokd581nJCIWhtgL8H2JOlT5xxqtx+wlIA95Oelsx6Lp3YbIYla1DGmL4SnlTIOtMDc= X-Received: by 10.223.178.206 with SMTP id g72mr17938950wrd.135.1520423282210; Wed, 07 Mar 2018 03:48:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 03:48:01 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Wed, 7 Mar 2018 11:48:01 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3175] Fix PEP-8 issues To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045cf6b8a5130f0566d121d6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045cf6b8a5130f0566d121d6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, applied! On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Thanks Joao for reviewing. > > > On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Murtuza, >> >> Looks good, and all tests are green. I run the commands provided and >> nothing pops up. >> >> Only missing 374 :D >> > =E2=80=8B:-) =E2=80=8B > > >> >> Thanks >> Joao >> >> On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix PEP8 issues in Browser & Database modules, >>> pycodestyle --config=3D.pycodestyle pgadmin/browser/__init__.py >>> pycodestyle --config=3D.pycodestyle pgadmin/browser/tests/ >>> pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/__init__.py >>> pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/tests/ >>> >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045cf6b8a5130f0566d121d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied!

On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thanks Joao for r= eviewing.


On Mon, Mar 5, 2018 at 8:58= PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io&= gt; wrote:
Hi Mur= tuza,

Looks good, and all tests are green. I run the com= mands provided and nothing pops up.

Only missing 3= 74 :D
=E2= =80=8B:-) =E2=80=8B
=C2=A0

Thanks
Joao
<= /div>
On Mon, Mar 5, 2018 at= 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi,

PFA patch to fix P= EP8 issues in Browser & Database modules,=C2=A0
pycodestyle --config=3D.pycodestyle pgadmin/browser/__init__.py<= br>
pycodestyle --config=3D.py= codestyle pgadmin/browser/tests/
pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/<= wbr>servers/databases/__init__.py
pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/se= rvers/databases/tests/



--
Regards,
Murtuza Zabuawa= la
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Ent= erprise PostgreSQL Company
<= font face=3D"verdana, sans-serif" color=3D"#444444">




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045cf6b8a5130f0566d121d6--