Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d80G4-0001K8-IC for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:12:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d80G3-00058e-Vw for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:12:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d80G3-00058U-CH for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:12:35 +0000 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d80Fz-0007PR-Rr for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:12:33 +0000 Received: by mail-it0-x234.google.com with SMTP id e65so52277335ita.1 for ; Tue, 09 May 2017 01:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IhB2JkPrkEQ0xXBowDQNHG8Zgb3ZPHoRetL2KTanadY=; b=GHAuWv2WrY68EVc9nrkfPEPmy8lvKDQj1yKwtnnlvUwjFwKDVe+f337/HC+kBBDT+q xAL+IcZOrA4VYjIIbGQGZTSENF+4DbMFGu10pe90FKzg0RsqiqJlbH3YDGcdA8Bb4ZIM QCBiC/f0PHy7STF+aD7eTUT23kXrwNiq1iKn26EzQa5xgcjWNR8hsNnZE7rasqLUfYZs TjFG8N5Um5C7gsjmpNj7LHvNHFoXA5WALVYJIBUa/Y7c/H2QMFayrJft/FzE0IU5Sed7 OaXZzKxuy7rYs45KzMV9V0VX7OjFyrAhUdqPpoLmRFJ0ZjMmmS8GdbJbhtLFLxoBEIex oTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IhB2JkPrkEQ0xXBowDQNHG8Zgb3ZPHoRetL2KTanadY=; b=lfBEmaO9kLF4jvdvX8RDhHlMMQkDYy3HHxNMz+NmBVv+EErOHEQ4cOpOy8YyyDXMw9 /c34hDZLwwLDhKMLSug97s4nuR835lY9IWoe5LRaq+aFTqhPO7IGBZY0nTvK3Dc6lxsP kdqIHdeWPPpvXTkuBhkG6SMWaBKQIc7rSWI7mOiCzsgVqPNgxQRqg21mtkLp+ScLmjmo pZ/h1wWYol6DGsz7xSl8WXZbhfE0HhCgXPzo+DAJ6HPnQdzvq+b5YDo1O1LVKvCkQDGv WMJVfKELx3l35r3KpHsde7fPnpz86NXkHBGvkUUgvF/GJXpp9rbg1H24bNn6nkeDGgFe K0LQ== X-Gm-Message-State: AODbwcBsohYXa4buzbinQFpS5xHOQd5Wz54qohuV5vKOXRSZ8fJT2Lwl AwUjaIlsXavud5IoYEmgnrv12TPTzU4U8kuEt0OrdOON+dAlDlTfUwOrVjOUClDrs6LphgQ9jnq 41jRgPh2D6d1RH2Qb/fUChbzy4YAQ7FYhhx3WyunLF+3At1VJOkvtZXFrzQULljzZ9Z59AvwT X-Received: by 10.36.84.85 with SMTP id t82mr144988ita.114.1494317550836; Tue, 09 May 2017 01:12:30 -0700 (PDT) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com. [209.85.214.43]) by smtp.gmail.com with ESMTPSA id m77sm37336itm.7.2017.05.09.01.12.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 01:12:29 -0700 (PDT) Received: by mail-it0-f43.google.com with SMTP id o5so795468ith.1 for ; Tue, 09 May 2017 01:12:29 -0700 (PDT) X-Received: by 10.36.74.3 with SMTP id k3mr5909545itb.28.1494317548751; Tue, 09 May 2017 01:12:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 9 May 2017 01:12:28 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 May 2017 09:12:28 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Akshay Joshi Cc: Neel Patel , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11449396aceb49054f12eabc X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11449396aceb49054f12eabc Content-Type: text/plain; charset=UTF-8 This appears to have made Jenkins get all angry and red :-( https://jenkins.pgadmin.org/ On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi wrote: > Thanks patch applied. > > On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: > >> Akshay, could you review this please? >> >> Thanks. >> >> On Fri, May 5, 2017 at 11:53 AM, Neel Patel >> wrote: >> >>> Hi, >>> >>> Please find attached patch file with the fix of RM #2328 - [Runtime]: >>> Unable to launch query tool and debugger in new browser tab. >>> >>> I have used Qt 5.8 with webkit mentioned in below URL. >>> >>> https://github.com/annulen/webkit/releases >>> >>> >>> As there was a bug in QWebKit regarding "unload" event. We have raised >>> and also they have provided patch file to fix this issue. I have applied >>> the patch in linux and compile the webkit and tested the attached patch >>> with compiled webkit which is now working fine. >>> >>> Below is the link for reference regarding unload issue. They have >>> provided test webkit release for Mac in below URL but for other platform we >>> need to apply the patch and compile the webkit until they provide >>> webkit-releases for all platforms. >>> >>> https://github.com/annulen/webkit/issues/519 >>> >>> Do review it and let me know in case of any issue. >>> >>> Thanks, >>> Neel Patel >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a11449396aceb49054f12eabc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
This appears to have made Jenkins get all angry and red :-= (


On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.

On Mon, May= 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, could you review t= his please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterp= risedb.com> wrote:
Hi,
Please find attached patch file with the fix of RM #2328 - [Ru= ntime]: Unable to launch query tool and debugger in new browser tab.
<= div>
I have used Qt 5.8 with = webkit mentioned in below URL.



As there was a bug = in QWebKit regarding "unload" event. We have raised and also they= have provided patch file to fix this issue. I have applied the patch in li= nux and compile the webkit and tested the attached patch with compiled webk= it which is now working fine.

Below is the link for reference regarding= unload issue. They have provided test webkit release for Mac in below URL = but for other platform we need to apply the patch and compile the webkit un= til they provide webkit-releases for all platforms.


Do review it and let me= know in case of any issue.

=
Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
<= div class=3D"m_6017984602102400325m_2836179073470347356gmail_signature" dat= a-smartmail=3D"gmail_signature">Dave Page
Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgr= eSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0

<= div>


--
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake
--001a11449396aceb49054f12eabc--