public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Florian Sabonchi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: OAUTH2 implementation
Date: Tue, 30 Mar 2021 15:48:32 +0000
Message-ID: <CA+OCxoz72Hs6t35AXD7RWkPq6othvAFEg-_N7brUkEOyOTYfHA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi
On Tue, Mar 30, 2021 at 3:36 PM Florian Sabonchi <[email protected]> wrote:
> Hello in this patch I have implemented oauth2
>
> Cool!
Unfortunately the patch seems to be messed up. It adds a number of commits
that are already in the primary repo, and attempts to remove your OAuth
support, rather than adding it. Can you rebase it and make sure it only
includes the addition of your work please?
Some other comments (keep in mind it's hard to read the mangled patch, so I
may be missing something):
- There don't seem to be any documentation updates
- There don't seem to be any tests (which I grant may not be feasible to
add unless an OAuth service can be mocked)
- I can't see how you've dealt with password saving, which currently
requires a password from the user to be secure.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: OAUTH2 implementation
In-Reply-To: <CA+OCxoz72Hs6t35AXD7RWkPq6othvAFEg-_N7brUkEOyOTYfHA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox