Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWjrG-0005U1-I6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 31 May 2019 15:54:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWjrD-00046H-Sv for pgadmin-hackers@arkaria.postgresql.org; Fri, 31 May 2019 15:54:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWjpG-0000qy-L2 for pgadmin-hackers@lists.postgresql.org; Fri, 31 May 2019 15:52:15 +0000 Received: from mail-it1-x143.google.com ([2607:f8b0:4864:20::143]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWjpD-0001At-Gs for pgadmin-hackers@postgresql.org; Fri, 31 May 2019 15:52:14 +0000 Received: by mail-it1-x143.google.com with SMTP id h11so15996383itf.5 for ; Fri, 31 May 2019 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KBaqo8qxKMKcx3HmJV5i1CTouahie7Bg5Psg6VrrzmA=; b=nQA6dag/iClorxXKOHK2zqoDTIOCROHra2B52rDU8ciof7sKjMwtuUyGT5I/gGdWIF 6XDRrk8pTUt5wK+7xOrRX840kXjD39LnK1LmVM7Eh9nKukT37C0ounS71aVriPFcdHpQ 44HkxzvM57YIVU6pUBa5NP5kRfTOciUnnSrLshG9SizTpocBBAQleUONtttZXULzuzhJ TjnxPPhwDJLoGz4Va3rlUMw3RhkuTiasN4SvgcunOdtsJpEFrDS8QXaOZDLC7RS3Pu5a 3PwukdZ5juVcFuTFA3WEZP+y6d7LMW5uty48SlEAmUzI1BG8F5whBx45U/6NLRFXBBUp HrZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KBaqo8qxKMKcx3HmJV5i1CTouahie7Bg5Psg6VrrzmA=; b=pUnIg4f41IoC/l8AgiRRmW33VmhBR6CauILMbRP9PM/gHh0DN63DH73I6XnSv8w6Pk hpGafqnS8Tb7lQN3cu9ymNGMCVbYaFLuq30VRrTYHtgNA9SFlZBQwDcdOIdp1afzZLaZ 7jsOK9ra0biekmTaus+WKO5j35bjOELuSR1KYVx4ybJ38NhFZyELHZm4dJODSpTGUNcw tdkhTMWOVdhJQh0KmpYxx++LQ00P9KR61N+3nN8rmkwCEH9ulz/CrHZBPm1O5lNPxcWX O+Wo36tXJfWLvAz875FJAy+bkckb6VNJwC5H0DSvWFQtao2T9aHydCVDzAjIxLusTnSO CaOw== X-Gm-Message-State: APjAAAXPfVwxTiiMiwm6r2wgnSpOa6eBfKkhWQqUleGvNpUMgMyi6bUQ HXR1lA09KhY62sZwpdhEIN8zl2yofCrd8WAdvhCMyD3E+MNcbA== X-Google-Smtp-Source: APXvYqxTMd32D00T73znCSWVLiyUuH+4lhAJq+qqWO313P68XLJ9x0ta5oTiJ76XZ2nwWUKq+6NiXAFdhId+Ng4LPuU= X-Received: by 2002:a24:9d94:: with SMTP id f142mr7267598itd.179.1559317929227; Fri, 31 May 2019 08:52:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 31 May 2019 11:51:56 -0400 Message-ID: Subject: Re: [pgAdmin][RM2653] Lock layout To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000043922c058a30ff07" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000043922c058a30ff07 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Fri, May 31, 2019 at 1:07 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > Attached is the updated rebased patch. > I realised I didn't update the documentations. The patch also include doc > updates. > > On Fri, May 31, 2019 at 12:42 AM Dave Page wrote: > >> Hi >> >> Can you rebase please? >> >> (pgadmin4) dpage@orac:*~/git/pgadmin4*$ git apply >> ~/Downloads/RM2653.patch >> >> error: patch failed: web/pgadmin/browser/static/js/browser.js:15 >> >> error: web/pgadmin/browser/static/js/browser.js: patch does not apply >> >> On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to introduce feature to lock the layout with three >>> different levels: >>> 1) None - No locking >>> 2) Prevent docking - The docking/undocking of panels will be disabled >>> 3) Full lock - The resizing along with docking/undocking of panels will >>> be disabled >>> >>> - This can be changed from new menu under File->Lock layout-> >>> or from Preferences->Browser->Display->Lock Layout >>> - JS test cases added. >>> >>> With this patch I have also changed below: >>> 1) Moved the maintenance dialog button group control to new common >>> control named RadioModern, which I have re-used in preferences for lock >>> layout levels. >>> 2) Added main nav bar menu with check feature, the menus which can >>> checked. >>> 3) Ability to add submenus from existing get_own_menuitems in python >>> code which is not possible currently. >>> 3) Separated all the layout related functions from browser.js to new >>> file layout.js to help JS testing. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000043922c058a30ff07 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Fri, May 31, 2019 at 1:07 AM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

Attached is the updated re= based patch.
I realised I didn't update the documentations. The patch a= lso include doc updates.

On Fri, May 31, 2019 at 12:42 AM Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
<= div dir=3D"ltr">Hi

Can you rebase please?

=

(pgadmin4) dpage= @<= span class=3D"gmail-m_-3423819290292137318gmail-m_-1282213050447364855gmail= -s3" style=3D"font-variant-ligatures:no-common-ligatures;color:rgb(88,229,6= 4)">orac:~/git/pgadmin4$ git apply ~/Downloads/RM2653.patch=C2=A0

error: patch failed: web/pgadmi= n/browser/static/js/browser.js:15

error: web/pgadmin/browser/stat= ic/js/browser.js: patch does not apply


On Thu, May 30, 2019= at 6:15 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrot= e:
H= i Hackers,

Attached is the patch to introduce feature to lock the layo= ut with three different levels:
1) None - No locking
2) Prevent docking - T= he docking/undocking of panels will be disabled
3) Full lock - The resizing= along with docking/undocking of panels will be disabled

- This can be= changed from new menu under File->Lock layout-><The level> or = from Preferences->Browser->Display->Lock Layout
- JS test cases ad= ded.

With this patch I have also changed below:
1) Moved the maintenan= ce dialog button group control to new common control named RadioModern, whi= ch I have re-used in preferences for lock layout levels.
2) Added main= nav bar menu with check feature, the menus which can checked.
3) Ability to add = submenus from existing=C2=A0get_own_menuitems in python code which is not p= ossible currently.
3) Separated all the layout related functions fro= m browser.js to new file layout.js to help JS testing.

Kindly review.<= /div>
--
Th= anks and Regards,
Aditya = Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about= Heat, Plant a TREE"
<= /div>


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000043922c058a30ff07--