MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELebFb=ceHh2bhRFE6awSx1LGW9EYaqC7AfkmEaWnPXXig@mail.gmail.com>
References: 
 <CAFOhELebFb=ceHh2bhRFE6awSx1LGW9EYaqC7AfkmEaWnPXXig@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Sat, 15 Oct 2016 00:29:06 +0100
Message-ID: 
 <CA+OCxoz8pmhgEwF-q3ob9pdOwhOL0D5hPrrpVApw1JFbgbFf6w@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a1143758ab2fc89053edb97f4
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a1143758ab2fc89053edb97f4
Content-Type: text/plain; charset=UTF-8

Hi

On Friday, October 14, 2016, Khushboo Vashi <khushboo.vashi@enterprisedb.com>
wrote:

> Hi,
>
> Please find the attached patch to fix the below 2 bugs.
>
> RM 1603: [Web Based] Export database failed if object contains double
> quotes.
> RM 1220: Backup database is not working with special characters
>
> The issues which were fixed:
>
> 1. Client side data were not unescaped
> 2. Required command line arguments were quoted twice
>

This is not working for me: I tested using Table Export as per Fahar's
instructions. As I'm in desktop mode, the first problem was that we get an
error at line 210 of import_export/__init__.py, because
get_server_directory returned None for the directory. If I fix that, then
the job says it's created, but as far as I can see, nothing else happens.

Secondly, this patch seems to push quoting responsibilty to the front end.
This doesn't seem right, because we might want to use the RESTful APIs for
another purpose in the future, which would mean needing to re-implement
quoting if something else uses an affected API.

Thanks.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1143758ab2fc89053edb97f4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi<br><br>On Friday, October 14, 2016, Khushboo Vashi &lt;<a href=3D"mailto=
:khushboo.vashi@enterprisedb.com">khushboo.vashi@enterprisedb.com</a>&gt; w=
rote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div>=
<div>Please find the attached patch to fix the below 2 bugs.</div><div><br>=
</div><div>RM 1603:=C2=A0[Web Based] Export database failed if object conta=
ins double quotes.</div><div>RM=C2=A01220: Backup database is not working w=
ith special characters</div><div><br></div><div>The issues which were fixed=
:</div><div><br></div><div>1. Client side data were not unescaped</div><div=
>2. Required command line arguments were quoted twice=C2=A0</div></div></bl=
ockquote><div><br></div><div>This is not working for me: I tested using Tab=
le Export as per Fahar&#39;s instructions. As I&#39;m in desktop mode, the =
first problem was that we get an error at line 210 of import_export/__init_=
_.py, because get_server_directory returned None for the directory. If I fi=
x that, then the job says it&#39;s created, but as far as I can see, nothin=
g else happens.=C2=A0</div><div><br></div><div>Secondly, this patch seems t=
o push quoting responsibilty to the front end. This doesn&#39;t seem right,=
 because we might want to use the RESTful APIs for another purpose in the f=
uture, which would mean needing to re-implement quoting if something else u=
ses an affected API.</div><div><br></div><div>Thanks.</div><br><br>-- <br>D=
ave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank"=
>http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB U=
K: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.ent=
erprisedb.com</a><br>The Enterprise PostgreSQL Company<br><br>

--001a1143758ab2fc89053edb97f4--