MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P3zyGfc7nFLCCiq8O4OU=ErTkmvR=mYMOQOao2-T_RJ_A@mail.gmail.com>
References: 
 <CACCA4P3zyGfc7nFLCCiq8O4OU=ErTkmvR=mYMOQOao2-T_RJ_A@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 8 May 2017 10:51:13 +0100
Message-ID: 
 <CA+OCxozAs+3T-Z_rJeZd0TLDr4gbWZdhPi4pYq8UUbM0nqLzVA@mail.gmail.com>
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to
 launch query tool and debugger in new browser tab
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Akshay Joshi <akshay.joshi@enterprisedb.com>
Content-Type: multipart/alternative; boundary=001a113ed3befe3595054f002d28
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a113ed3befe3595054f002d28
Content-Type: text/plain; charset=UTF-8

Akshay, could you review this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterprisedb.com>
wrote:

> Hi,
>
> Please find attached patch file with the fix of RM #2328 - [Runtime]:
> Unable to launch query tool and debugger in new browser tab.
>
> I have used Qt 5.8 with webkit mentioned in below URL.
>
> https://github.com/annulen/webkit/releases
>
>
> As there was a bug in QWebKit regarding "unload" event. We have raised and
> also they have provided patch file to fix this issue. I have applied the
> patch in linux and compile the webkit and tested the attached patch with
> compiled webkit which is now working fine.
>
> Below is the link for reference regarding unload issue. They have provided
> test webkit release for Mac in below URL but for other platform we need to
> apply the patch and compile the webkit until they provide webkit-releases
> for all platforms.
>
> https://github.com/annulen/webkit/issues/519
>
> Do review it and let me know in case of any issue.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113ed3befe3595054f002d28
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Akshay, could you review this please?<div><br></div><div>T=
hanks.</div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote"=
>On Fri, May 5, 2017 at 11:53 AM, Neel Patel <span dir=3D"ltr">&lt;<a href=
=3D"mailto:neel.patel@enterprisedb.com" target=3D"_blank">neel.patel@enterp=
risedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=
=3D"ltr">Hi,<div><br></div><div>Please find attached patch file with the fi=
x of RM #2328 - [Runtime]: Unable to launch query tool and debugger in new =
browser tab.</div><div><br></div><div><div style=3D"font-size:12.8px">I hav=
e used Qt 5.8 with webkit mentioned in below URL.</div><div style=3D"font-s=
ize:12.8px"><br></div><div style=3D"font-size:12.8px"><a href=3D"https://gi=
thub.com/annulen/webkit/releases" target=3D"_blank">https://github.com/annu=
len/web<wbr>kit/releases</a></div><div style=3D"font-size:12.8px"><br></div=
><div style=3D"font-size:12.8px"><br></div><div style=3D"font-size:12.8px">=
As there was a bug in QWebKit regarding &quot;unload&quot; event. We have r=
aised and also they have provided patch file to fix this issue. I have appl=
ied the patch in linux and compile the webkit and tested the attached patch=
 with compiled webkit which is now working fine.</div><div style=3D"font-si=
ze:12.8px"><br></div><div style=3D"font-size:12.8px">Below is the link for =
reference regarding unload issue. They have provided test webkit release fo=
r Mac in below URL but for other platform we need to apply the patch and co=
mpile the webkit until they provide webkit-releases for all platforms.</div=
><div style=3D"font-size:12.8px"><br></div><div><span style=3D"font-size:12=
.8px"><a href=3D"https://github.com/annulen/webkit/issues/519" target=3D"_b=
lank">https://github.com/annulen/web<wbr>kit/issues/519</a></span></div><di=
v style=3D"font-size:12.8px"><br></div><div style=3D"font-size:12.8px">Do r=
eview it and let me know in case of any issue.</div></div><div style=3D"fon=
t-size:12.8px"><br></div><div style=3D"font-size:12.8px">Thanks,</div><div =
style=3D"font-size:12.8px">Neel Patel</div></div>
<br><br>
--<br>
Sent via pgadmin-hackers mailing list (<a href=3D"mailto:pgadmin-hackers@po=
stgresql.org">pgadmin-hackers@postgresql.<wbr>org</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgadmin-hackers" rel=3D"noref=
errer" target=3D"_blank">http://www.postgresql.org/<wbr>mailpref/pgadmin-ha=
ckers</a><br>
<br></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div cla=
ss=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog=
: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.=
blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"ht=
tp://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a=
><br>The Enterprise PostgreSQL Company<br></div>
</div>

--001a113ed3befe3595054f002d28--