Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxbez-0001gy-Dh for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:23:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxbez-0005wd-08 for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:23:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxbey-0005vO-MI for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:23:04 +0000 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxbev-0001vO-3A for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:23:03 +0000 Received: by mail-it0-x231.google.com with SMTP id 4so244942116itv.0 for ; Fri, 21 Oct 2016 08:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5PEpquUrG9EEGb14huNuWZZjQZ/ZmPD1vmdyPdRs34w=; b=qr4u3Nr6+iUKShBZpMSHQ+LUEmZGtcKwg40rFkqLUGm0V1za3SzDFjoFUnF2dBI43D yhPjFIJAMT0SxA6UvsxoUOuQMk8p/xLgxVWRqB+X83uZN5IJmvdJzUg6eYC9RclI/XOM vsFk7GYvG8Itlls0m6wls+PLr/Vtadlk4Gefu48afzz482yac85HMquiovMlvi7zDbWj PNNPdKLzOb/dIjJYc5kDplUowe0MJ4HqjsTzbgKOEppfJF38zj0pgoI4icuQKJ+5FoKq UfcOmuwJMNYObIVZD3T7dg5LG2l8q8FfSEHOO61fmw5xd5iWMVVNe8Ane2PmSSzAqlVY CB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5PEpquUrG9EEGb14huNuWZZjQZ/ZmPD1vmdyPdRs34w=; b=NAHybpPLBrbAuluqfp/xt44vloydqwSj8S1e1Rmf3y2b1VWQB/Ajea9lenFIzpWpO+ 6i8JtvmfpYQ2Ei4GsevsEmjaXrbBk/Pv9EssauMnrVGMBTl3aiwpCEPsU08z22fBWCO5 KzgXEEYiiKA8MJZ9XwkBosvXoBUOWHjwqkqhpz59p/2bjOXYeCIMmFhHn6fkRZCjxgOg M+IsuxOBQGBfDLM5pCT8TmASDGjRxyGBS2C7oT+xRzD7pFtT15PoZQKOQPZWo/6OHXpG bvowfuHO1Z0js5cn0SGC/wFPVHGjj4xikpXp333x+qcI8yAQVOJIVzTUwZH4MFw8CATh uZAQ== X-Gm-Message-State: ABUngvexme2Y1haSZYLPXwJfqcAaH2DMd38wb2MsLBW1WVl7stLbjAdaFffAO/5fcv/faQvxOQrDIAE5ZT/mMg== X-Received: by 10.107.12.206 with SMTP id 75mr1522108iom.208.1477063374195; Fri, 21 Oct 2016 08:22:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.82.130 with HTTP; Fri, 21 Oct 2016 08:22:53 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 21 Oct 2016 16:22:53 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar wrote: > Hi > > This fix is for exclusion constraint. > The options like "order" and "nulls" must be conditional. i.e. include only > when access method type is other than "gist". When creating an index, the asc/desc options are disabled if gist/gin used. I think they also should be here. Also, what about gin indexes in this case? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers