Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d80U0-0001tP-14 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:27:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d80Tz-0001No-At for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:26:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d80Ty-0001Nf-S2 for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:26:58 +0000 Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d80Tv-00086w-6Z for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:26:58 +0000 Received: by mail-it0-x22e.google.com with SMTP id e65so52441167ita.1 for ; Tue, 09 May 2017 01:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tixRl3mGWLEIE4HEhe7fxk2j2fI+FQjfjSaYalc6YVo=; b=woW7PG2ZHyhvYH5U3saMJUHxbp+2DFVOXi/d/UfYQXzRS7YUAmGjpMJc5My5R9C9y8 wBKZjKKiGzenSdkzXz7CnJaiNO//Vr5bkNSbpvbmgRVxoNjrWFWhBc1qgFsyJs/TYrCx 6CVcXIVxLOGCw6lnpbi8ih5wVDnsHT8DW/EZ3F0DlS3JO/r1UJ5fjlegDnI3hlUFR/Dr HHVHhHgSj5t3x+bx3BJK2RRUN4oZ2upqecBJiq98H7p9VJvADFYSqF4f7uEJlsm9ivNX lygrDhlhuyjwqvZCYBPo3Vgx7iy9ioMdlrgBw3H+Jt+usvyypOIuP0KpKFcHRBhFG/eV cLWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tixRl3mGWLEIE4HEhe7fxk2j2fI+FQjfjSaYalc6YVo=; b=nl2G2eLmuDAgNEd4k65frCRll1zDwXeRtT0FsTIZt2GjNYVTQ92mDLuU5wttsGR00d HCXc/KrwIVLKf49Z8wCFYz6WIunfjeaGQ9Fntfj8mYLK89cbDLd7Vu+RF5ekbE0fjioM t4FNJvovH+8hWtiscEED5PiBar/EmSvRGerEH3A+q3yQIJkUzsBAuT7ExVydUgBeXwjs QxJH/mHZ0c4WjerUxnYyqzTyLq0fH8YBpElUA9vwr1S537RGSJ0gSVBdU32ZMO2iM/Fw ItCC2c9nmy7fLRuoHrhOLMrt7l3cf9uCIIXVGXO1iUdCvg26indd9dNBhLv5eLmZZW+W WVug== X-Gm-Message-State: AN3rC/7TORKBUdCTIRRW5ZhVcmt6Y1waiN37m2GXoHUgjV6Fw7vpK5Ry tiLmamsnfFMJ7xv20PHkHLG+kE8wzmfFZYoEPRNqlm8C/SoarDD1NLgWkkJZ2HlUpO1+4f9aSrt YqVA/Ke69HR3iRDzCb4N4NsjZ4MHnVWYWBT7x+UPaucnCN3LC7ZV6eRb8Zy3U6EKvLpbqoi1M X-Received: by 10.36.70.204 with SMTP id j195mr23550429itb.22.1494318413367; Tue, 09 May 2017 01:26:53 -0700 (PDT) Received: from mail-io0-f173.google.com (mail-io0-f173.google.com. [209.85.223.173]) by smtp.gmail.com with ESMTPSA id h200sm1066120ioe.62.2017.05.09.01.26.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 01:26:45 -0700 (PDT) Received: by mail-io0-f173.google.com with SMTP id k91so65557954ioi.1 for ; Tue, 09 May 2017 01:26:45 -0700 (PDT) X-Received: by 10.107.51.14 with SMTP id z14mr7323908ioz.84.1494318404782; Tue, 09 May 2017 01:26:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 9 May 2017 01:26:43 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 May 2017 09:26:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Akshay Joshi Cc: Neel Patel , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113a8bc8b2e802054f131df9 X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a8bc8b2e802054f131df9 Content-Type: text/plain; charset=UTF-8 On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi wrote: > Hi > > On Tue, May 9, 2017 at 1:42 PM, Dave Page > wrote: > >> This appears to have made Jenkins get all angry and red :-( >> >> https://jenkins.pgadmin.org/ >> > > We(Neel and I) have tested it and working fine. > It clearly doesn't compile on QT4. Please review the Jenkins logs. > >> >> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks patch applied. >>> >>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >>> >>>> Akshay, could you review this please? >>>> >>>> Thanks. >>>> >>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>> neel.patel@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find attached patch file with the fix of RM #2328 - [Runtime]: >>>>> Unable to launch query tool and debugger in new browser tab. >>>>> >>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>> >>>>> https://github.com/annulen/webkit/releases >>>>> >>>>> >>>>> As there was a bug in QWebKit regarding "unload" event. We have raised >>>>> and also they have provided patch file to fix this issue. I have applied >>>>> the patch in linux and compile the webkit and tested the attached patch >>>>> with compiled webkit which is now working fine. >>>>> >>>>> Below is the link for reference regarding unload issue. They have >>>>> provided test webkit release for Mac in below URL but for other platform we >>>>> need to apply the patch and compile the webkit until they provide >>>>> webkit-releases for all platforms. >>>>> >>>>> https://github.com/annulen/webkit/issues/519 >>>>> >>>>> Do review it and let me know in case of any issue. >>>>> >>>>> Thanks, >>>>> Neel Patel >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a113a8bc8b2e802054f131df9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave= .page@enterprisedb.com> wrote:
This appears to have made Jenkins get all angry and red :-(

=C2=A0 =C2=A0We(Neel and I) have tested it and working fine.=C2=A0=C2= =A0

It clearly does= n't compile on QT4. Please review the Jenkins logs.
=C2=A0


On Tue, M= ay 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb= .com> wrote:
Thank= s patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, could you review = this please?

Thanks.

On Fri, May 5, 2017 at = 11:53 AM, Neel Patel <neel.patel@enterprisedb.com>= wrote:
= Hi,

Please find attached patch file with the fix of RM #= 2328 - [Runtime]: Unable to launch query tool and debugger in new browser t= ab.

I have used Qt= 5.8 with webkit mentioned in below URL.



As there = was a bug in QWebKit regarding "unload" event. We have raised and= also they have provided patch file to fix this issue. I have applied the p= atch in linux and compile the webkit and tested the attached patch with com= piled webkit which is now working fine.

Below is the link for reference= regarding unload issue. They have provided test webkit release for Mac in = below URL but for other platform we need to apply the patch and compile the= webkit until they provide webkit-releases for all platforms.


Do review i= t and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=



--
Akshay Joshi
Princip= al Software Engineer=C2=A0

=




--
<= /font>
Dave Page
VP, Chief Architect, Tools & InstallersEnterpriseDB: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com<= /a>
Twitter: @pgsnake



--
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake
--001a113a8bc8b2e802054f131df9--