Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLt2Q-0002fp-HG for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 16:24:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fLt2O-0003pf-W1 for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 16:24:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLt2O-0003pU-Lo for pgadmin-hackers@lists.postgresql.org; Thu, 24 May 2018 16:24:24 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fLt2J-0002K6-Oo for pgadmin-hackers@postgresql.org; Thu, 24 May 2018 16:24:23 +0000 Received: by mail-wm0-x230.google.com with SMTP id n10-v6so6992604wmc.1 for ; Thu, 24 May 2018 09:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=i/GDJ5EYTpPuuCbN+DS6kFRbf/RJJI8g9Y7mGE+wGpM=; b=b1F09GqJxOYYkcGv5mIrLoVSLGp29PJZDr0wa3Ep4WBJuAIueRGQIcaFraQzXiJoZM tEJ814O9SHwbU0F7yRFbW1X3qjPHdraC7kIhFXQJwNKRTjEMRsT1QrFpef7H9iRGqF9t GeyAjSrSPfeP7if9zyR9wiKXSKOAxCZ1w87smPubxU9WvqJD6uKOYREtKT1u/h0ThYA6 SMPxsvd9eKS2Y49/N/HnkutMfF6tkdzW6J9qazDWYVNsfEeh+ILH3W64jZgQWwTbOJ5z rPpIsf8HE74/5OHxEXNnH9fbXj3saHfl7M7hCcfRrklt5sz5r7bKJ4f5Qwemdd0GckXL 8HJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=i/GDJ5EYTpPuuCbN+DS6kFRbf/RJJI8g9Y7mGE+wGpM=; b=HWBvpxM/CgYArSkgYD+K1nF7pXFJ4X4G59EG5+1HbXFuIqNzMPWalHrSrX2Y5+hiMO mBI+S0it9X2er4uXxz4AR3+MvDlb6bnQet4XFczcIXQVhKfkveeXtDA9fTGMo/0jl+LY c5ER69rfDHZ7TzE8fBN7K898kR5Ent8cQcWdi/wJ8bN9xg64YIHpvueLaC16v3a8Xhq/ Sv/GD/meBFGUyC5hkzc7WuykW45TZIm8l4RFCW8eFmrav7Z3CQs5cZWGgYck5d7OFFIA HPnnYhTz52HKe3cquuruOG1R4O7bAxbJg7LIycqDQxN+PFibKwcghYN5m1PwUhErA791 hKDw== X-Gm-Message-State: ALKqPwdc/xcGhu1L7/iXM/MMGHPf4E12v5yP2GRJG1afvgQ/0/AnPR2q i0s13qy9wceKCVD+do8aKelDzHgvdBLUNngURa7Ehg== X-Google-Smtp-Source: ADUXVKKU2say8DcI5GKrNKdofd2ibtRw0hz4Z5oRo5zN4AOjW6ZFDxyCztWCc8MEdK+GZUTMCzk1RtG97wIQ8rRPUs4= X-Received: by 2002:a1c:e5c5:: with SMTP id c188-v6mr148119wmh.86.1527179058370; Thu, 24 May 2018 09:24:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:55c2:0:0:0:0:0 with HTTP; Thu, 24 May 2018 09:24:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 24 May 2018 17:24:17 +0100 Message-ID: Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests To: Anthony Emengo Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000486faf056cf61592" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000486faf056cf61592 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo wrote: > Here=E2=80=99s a followup patch with the relevant README and Makefile cha= nges. To > be clear, both patches need to be applied in succession to run the tests. > > The error that you were running into was because the appropriate > PYTHONPATH environment variable was not set. We updated the README to > reflect that, but haven=E2=80=99t done anything to the code for that > That really needs to be fixed then. I shouldn't need to do anything beyond activate the appropriate virtual environment (which I had done). --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000486faf056cf61592 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo <<= a href=3D"mailto:aemengo@pivotal.io" target=3D"_blank">aemengo@pivotal.io> wrote:

Here=E2=80=99s a followup patch with the relevant = README and Makefile changes. To be clear, both patches need to be applied i= n succession to run the tests.

The error that you were running= into was because the appropriate PYTHONPATH enviro= nment variable was not set. We updated the README to reflect that, but have= n=E2=80=99t done anything to the code for that

=
That really needs to be fixed then. I shouldn't need to do anythin= g beyond activate the appropriate virtual environment (which I had done).= =C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company
--000000000000486faf056cf61592--