Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aGnOm-0001Gk-Kq for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jan 2016 12:41:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aGnOl-0007OZ-KF for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jan 2016 12:41:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aGnOX-00079o-N8 for pgadmin-hackers@postgresql.org; Wed, 06 Jan 2016 12:40:53 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aGnOT-0002jT-BQ for pgadmin-hackers@postgresql.org; Wed, 06 Jan 2016 12:40:51 +0000 Received: by mail-io0-x22a.google.com with SMTP id g73so18052230ioe.3 for ; Wed, 06 Jan 2016 04:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LJBqrroCiEA3AYBHpcQbaPPsiCsWsC9REw/T5WH8R+s=; b=ImT7MqXRkE/wgEQxYSv9pkLMygGMtBnLsytgjl2ycgl+fl9gtIXBCH60rLfkscBVP8 KTVQXpTIDaBvBCEcXYK+GDP/YgdbnGwQMka4w3eth1pZwjk7HAHCpn0vPIELVHcGsAVZ xKNNBPT/wX1pZGf/I09dDdpXL5ice1zjfdTIntHRRQ+JfuPx9FMdd2yU2J/td4T8LPEW crY9/QEk6MF2fledyfub2JCLcmZFAJdOsV5uC5inZCHyshZi8qm1UldP4E4prTMnYX3W sssyptmpvW4UE+pLEUsNFjMRT7sqfFDr6mxNbFaXPC7oZ2nTVMWwaby0Y6WlYERfqBTL H9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=LJBqrroCiEA3AYBHpcQbaPPsiCsWsC9REw/T5WH8R+s=; b=jvgPmGkcPrefqylBF5GoPNmTRKC4tsPQFX5Qvhn0IGo9Y2UPEeXfFw5gYY4w8LyJCx g1goujsDp8To83rlNs959VmErz04+XeD+4dV4OPxh6wfpfJTnj8IVteSXMyePR0Q1ebh weSerRlUaIG/iw3OW1oL+AzMe28BxbuXFMmoZaMp7ttlp0e/wKXsOOVK/Sd/fP/YFFQq wdis6qTdXmPTHtOOZDsyx/NouwMYLM3MMyTceMARjDnCI7zrSSoh2fO+53ov1N0xmsmp 3E/Je+y/k4P3DqIwMgykAaxMOWz3VJxOIpwp46N2wCzuUk17OTVvalgpStnK7zI2VjMf MaSw== X-Gm-Message-State: ALoCoQkCSNmTSCS2bPyHToB/nCqRjFV70XyHUrBh6Nm9mAOl8PbfWzpXrTlE/ij8X1CvIVXN9a+eGM7uDT43NoEiHjXdyebBJg== MIME-Version: 1.0 X-Received: by 10.107.6.209 with SMTP id f78mr65812564ioi.63.1452084048501; Wed, 06 Jan 2016 04:40:48 -0800 (PST) Received: by 10.64.0.195 with HTTP; Wed, 6 Jan 2016 04:40:48 -0800 (PST) In-Reply-To: <568D05F9.6070809@enterprisedb.com> References: <568D05F9.6070809@enterprisedb.com> Date: Wed, 6 Jan 2016 12:40:48 +0000 Message-ID: Subject: Re: PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4 From: Dave Page To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Wed, Jan 6, 2016 at 12:18 PM, Murtuza Zabuawala wrote: > Hi, > > Please find patch to add "Collation" & "Catalog Objects" nodes in pgAdmin4. > > Please note that this patch is mainly for "Collation" & "Catalog Objects" > nodes, Schema/Catalog node is not yet complete as we are yet to implement > privileges control for the same. Thanks - a couple of quick comments: - Please ensure the copyright notices are updated for 2016. - The text: Below SQL will .... Should be: The SQL below will .... -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers