MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P2GP-F=Rh1CJW0YXJt8E4vtQ9mBJZbGRuRsBSXEUmOgCA@mail.gmail.com>
References: 
 <CACCA4P2GP-F=Rh1CJW0YXJt8E4vtQ9mBJZbGRuRsBSXEUmOgCA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 25 Jul 2016 12:40:13 +0100
Message-ID: 
 <CA+OCxozC+=25qaNTv0qGZU=f-P0cXY6T444HHzjUGOxfj=x2Zw@mail.gmail.com>
Subject: Re: [pgAdmin4][runtime][patch]: Compilation error
 with Qt4
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks - applied.

On Sat, Jul 23, 2016 at 2:39 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file with the fix of below issues with runtime
> application.
>
> Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5.
> Client side download code has been removed as now we support server side
> download.
> We should not delete sender object inside slot. If we do so it may crash the
> application. To avoid this, we used Qt's "deleteLater" which will delete the
> objects once the processing of all the events have been done.
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers