public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)
Date: Tue, 13 Mar 2018 15:32:48 -0400
Message-ID: <CA+OCxozCgyQh-1r36nUKRVxszqr7KPd77vX5NuEbd9vvoSvWxg@mail.gmail.com> (raw)
In-Reply-To: <CAE+jjanR8C9mbr447JC=PZ6ORdXyu6FexcmDhrXYiy-A_73jgQ@mail.gmail.com>
References: <CAE+jjak_FQKTrBj0cOi6Whaz1k_iseZu697v_-x2Rn8K7U49QQ@mail.gmail.com>
<CA+OCxowdoxCvcV6ag4Q85rD5HuG29jS08BH0M3V5Uac4EfN7pg@mail.gmail.com>
<CAE+jjamfkFYZ6P0Gp+h6UpHhuO7c3qWJfrompN-Mf=tn5Sj=9w@mail.gmail.com>
<CA+OCxozii9oa-7jFqjq_ssjiUd9rwAmR7qDKNrfnKeOUCRR4ug@mail.gmail.com>
<CAE+jjanR8C9mbr447JC=PZ6ORdXyu6FexcmDhrXYiy-A_73jgQ@mail.gmail.com>
Thanks, applied.
On Tue, Mar 13, 2018 at 2:19 PM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hi
>
> Attached you can find the patch that instead of using the json
> configuration, connects to the database to retrieve the type and then check
> if the test should be skipped or not.
>
> Thanks
> Victoria & Joao
>
> On Sun, Mar 11, 2018 at 8:20 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Sun, Mar 11, 2018 at 7:22 PM, Joao De Almeida Pereira <
>> [email protected]> wrote:
>>
>>> Hello,
>>> Can you point out an example?
>>> Thanks
>>>
>>
>> See the setUp function in test_resource_groups_add.py:
>>
>> if "type" in server_con["data"]:
>> if server_con["data"]["type"] == "pg":
>> message = "Resource groups are not supported by PG."
>> self.skipTest(message)
>> else:
>> if server_con["data"]["version"] < 90400:
>> message = "Resource groups are not supported by PPAS
>> 9.3" \
>> " and below."
>> self.skipTest(message)
>>
>>
>>>
>>>
>>> On Sat, Mar 10, 2018, 3:53 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Friday, March 9, 2018, Joao De Almeida Pereira <
>>>> [email protected]> wrote:
>>>>
>>>>> Hello Hackers,
>>>>>
>>>>> Attached you can find the patch that skip some tests and correct
>>>>> issues on SQL that are failing when trying to connect to a GreenPlum
>>>>> database.
>>>>>
>>>>> We did this by adding a attribute to to test_json called "db_type"
>>>>> that will carry the type of database we are running tests against.
>>>>>
>>>>
>>>> Any reason we can't do that dynamically as we do with the EPAS-specific
>>>> tests?
>>>>
>>>>
>>>>>
>>>>> When we run tests against a GreenPlum instance the configuration would
>>>>> look like this:
>>>>>
>>>>> {
>>>>> "name": "GreenPlum",
>>>>> "comment": "GreenPlum DB",
>>>>> "db_username": "gp",
>>>>> "host": "localhost",
>>>>> "db_password": "",
>>>>> "db_port": 5433,
>>>>> "maintenance_db": "postgres",
>>>>> "sslmode": "prefer",
>>>>> "tablespace_path": "",
>>>>> "enabled": true,
>>>>> "db_type": "gpdb"
>>>>> }
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Thanks
>>>>> Joao
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)
In-Reply-To: <CA+OCxozCgyQh-1r36nUKRVxszqr7KPd77vX5NuEbd9vvoSvWxg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox