MIME-Version: 1.0
References: 
 <CAKtn9dM=dEKHahvsVKfvUrMPVY+r9iOkEtXHi2tUJpuzF3Nd-Q@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dM=dEKHahvsVKfvUrMPVY+r9iOkEtXHi2tUJpuzF3Nd-Q@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 26 Nov 2020 13:26:02 +0000
Message-ID: 
 <CA+OCxozDMADKo7p332SOdpmgk7jEMsXnheZB=eMCfJ94hoP8ZA@mail.gmail.com>
Subject: Re: Unable to download macros query results (reference #RM5965)
To: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000dda3b705b5027c5f"
Precedence: bulk

--000000000000dda3b705b5027c5f
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Team,
>
> Users are unable to download macros query results.
>
> *Lets look out how download query result button works:*
>
> For pgadmin4, always downloads the latest query result when the user makes
> n-number of sql changes in the query tool, no need to execute, download
> takes care of it. Does not work with macros as query is needed in the query
> tool, which macros does not provide (While feature implementation, it was
> decided that macros query won't be added to the query tool, as users may
> lose any important queries in it).
>
> In pgadmin3, always the last executed query result gets downloaded even if
> the user makes n-number of sql changes in the query tool. Works with
> macros. For the latest query change results, the user has to first execute
> before every download.
>
> For Macros, with the pgadmin4 approach, even if we implement a download
> option, it would be difficult to decide whether to download the already ran
> macros or to download the query result present in the query tool.
>
> Please suggest.
>

I've not been happy with that for a while. The button is marked as a
download button, however, it's really "Execute and save results". That's
quite different, and could result (as at least some users have found), the
file containing different data from what's shown in the grid from a normal
execution of the query.

I think we should make it a "Save results to file" button, and clarify the
behaviour (through docs, and only enabling button when there are results to
save). It should *not* execute a query, but simply save what is currently
in the grid. The only caveat I would note is that if the grid isn't fully
populated, it should do so first (the same as we do if you select all rows).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--000000000000dda3b705b5027c5f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Thu, Nov 26, 2020 at 1:18 PM Rahul S=
hirsat &lt;<a href=3D"mailto:rahul.shirsat@enterprisedb.com">rahul.shirsat@=
enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex"><div dir=3D"ltr">Hi Team,<div><br></div><div>Users are unab=
le to download macros query results.</div><div><br></div><div><b><u>Lets lo=
ok out how download query result button works:</u></b></div><br>For pgadmin=
4,=C2=A0always downloads the latest query result when the user makes n-numb=
er of sql changes=C2=A0in the query tool, no need to execute, download take=
s care of it. Does not work with macros as query is needed in the query too=
l, which macros does not provide (While feature implementation, it was deci=
ded that macros query won&#39;t be added to the query tool, as users may lo=
se any important queries in it).<div><br></div><div><div>In pgadmin3, alway=
s the last executed query result gets downloaded even if the user makes n-n=
umber of sql changes=C2=A0in the query tool. Works with macros. For the lat=
est query change results, the user has to first execute before every downlo=
ad.</div><div><br></div><div>For Macros, with the pgadmin4 approach, even i=
f we implement a download option, it would be difficult=C2=A0to decide whet=
her to download the already ran macros or to download the query=C2=A0result=
 present in the query tool.</div><div><br></div><div>Please suggest.</div><=
/div></div></blockquote><div><br></div><div>I&#39;ve not been happy with th=
at for a while. The button is marked as a download button, however, it&#39;=
s really &quot;Execute and save results&quot;. That&#39;s quite different, =
and could result (as at least some users have found), the file containing d=
ifferent data from what&#39;s shown in the grid from a normal execution of =
the query.</div><div><br></div><div>I think we should make it a &quot;Save =
results to file&quot; button, and clarify the behaviour (through docs, and =
only enabling button when there are results to save). It should *not* execu=
te a query, but simply save what is currently in the grid. The only caveat =
I would note is that if the grid isn&#39;t fully populated, it should do so=
 first (the same as we do if you select all rows).</div><div>=C2=A0</div></=
div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave=
 Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">ht=
tp://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"h=
ttp://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</=
a><br><br></div></div></div>

--000000000000dda3b705b5027c5f--