MIME-Version: 1.0
References: 
 <CANxoLDe_FGeAnGy9Vo22VBKRfd8-=yb4AbZcE4AbyR-tUnYgBg@mail.gmail.com>
In-Reply-To: 
 <CANxoLDe_FGeAnGy9Vo22VBKRfd8-=yb4AbZcE4AbyR-tUnYgBg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 14 Jun 2019 09:29:31 +0100
Message-ID: 
 <CA+OCxozE6mwqrBrGnQaaEjcJoyR7t8RYJGNj+RkfP0HsrYohCw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test
 Reverse Engineering SQL
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000c33e57058b447285"
Precedence: bulk

--000000000000c33e57058b447285
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers
>
> I have implemented the new test framework to test the Reverse Engineering
> SQL. I have integrated it as a part of API/Regression test suite. It will
> work when we run all the test cases or module wise test case.
>
> *How it works*: Attached patch contains the generic framework to read all
> the JSON files from the *tests->version based (example 9.6_plus, 10_plus
> or default) folder. *Run all the test scenarios present in the JSON file
> in sequential order.
>
> Format of the JSON file is mentioned in
> "<path_of_source>web/pgadmin/browser/server_groups/servers/databases/casts/tests/default/test.json"
>
> For expected SQL we will have following two options:
>
>    - Provide the expected sql in scenario itself as parameter *"expected_sql"
>    : "<SQL>"*.
>    - Create a output file with any name in the same directory where the
>    JSON file resides and specify the parameter "*expected_sql_file":
>    "<name of the file>"*
>
> Attached patch contains both the above mentioned examples.
>
> Please review it.
>

Nice!

A few comments:

- The scenario name should be "Reverse Engineered SQL Test Cases"
- After the scenario name is output, can we output a \n so the next line
isn't appended to the name?
- How do we run only the re_sql tests? I tried the obvious ways
(e.g. python runtests.py --pkg
regression.re_sql.tests.test_resql.ReverseEngineeringSQLTestCase) but got
errors. Please add an example to web/regression/README.
- Once we have a way to run these tests only, please add a "make
check-resql" target to the Makefile.
- Can the expected output be formatted in the JSON such that it doesn't use
\n, but uses regular line breaks? That would make it easier to copy/paste.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000c33e57058b447285
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 13, 2019 at 12:52 PM Akshay=
 Joshi &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@en=
terprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr">Hi Hackers<div><br></div><div>I have impleme=
nted the new test framework to test the Reverse Engineering SQL. I have int=
egrated it as a part of API/Regression test suite. It will work when we run=
 all the=C2=A0test cases or module wise test case.</div><div><br></div><div=
><b>How it works</b>: Attached patch contains the generic framework to read=
 all the JSON files from the <b>tests-&gt;version based (example 9.6_plus, =
10_plus or default) folder. </b>Run all the test scenarios present in the J=
SON file in sequential order.</div><div><br></div><div>Format of the JSON f=
ile is mentioned in &quot;&lt;path_of_source&gt;web/pgadmin/browser/server_=
groups/servers/databases/casts/tests/default/test.json&quot;</div><div><br>=
</div><div>For expected SQL we will have following two options:</div><div><=
ul><li>Provide the expected sql in scenario itself as parameter <b>&quot;ex=
pected_sql&quot; : &quot;&lt;SQL&gt;&quot;</b>.<br></li><li>Create a output=
 file with any name in the same directory where the JSON file resides and s=
pecify the parameter &quot;<b>expected_sql_file&quot;: &quot;&lt;name of th=
e file&gt;&quot;</b><br></li></ul></div><div>Attached patch contains both t=
he above mentioned examples.</div><div><br></div><div>Please review it.</di=
v></div></blockquote><div><br></div><div>Nice!</div><div><br></div><div>A f=
ew comments:</div><div><br></div><div>- The scenario name should be &quot;R=
everse Engineered SQL Test Cases&quot;</div><div>- After the scenario name =
is output, can we output a \n so the next line isn&#39;t appended to the na=
me?</div><div>- How do we run only the re_sql tests? I tried the obvious wa=
ys (e.g.=C2=A0python runtests.py --pkg regression.re_sql.tests.test_resql.R=
everseEngineeringSQLTestCase) but got errors. Please add an example to web/=
regression/README.</div><div>- Once we have a way to run these tests only, =
please add a &quot;make check-resql&quot; target to the Makefile.</div><div=
>- Can the expected output be formatted in the JSON such that it doesn&#39;=
t use \n, but uses regular line breaks? That would make it easier to copy/p=
aste.</div><div><br></div><div>Thanks.</div><div><br></div></div>-- <br><di=
v dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http:=
//pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><b=
r>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterpris=
edb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterpris=
e PostgreSQL Company<br></div></div>

--000000000000c33e57058b447285--