public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server
Date: Wed, 7 Sep 2016 14:02:04 +0100
Message-ID: <CA+OCxozEfTUpKxxE=fiZkt7d20cbQn32V813TEZ-6XGqow1kRw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D-jn-Di9D3iAtsz8k8H2+_fNXU+aEj_GYOK+KuvmeiZJw@mail.gmail.com>
References: <CAG7mmoz6hEi1BE=nSs2fGt_y5gpkpj6gDEp+WMAWJrJwepVHYw@mail.gmail.com>
<CAG7mmoxUL-H1poTGZz4KyMd9Tw3Po4yRDw_GK1Wu6w4YTK1WXA@mail.gmail.com>
<CA+OCxoz9cAT8x-YEKQ7MEOjqpR_0mrVbBt0QQ3_+aNdWhdPBPQ@mail.gmail.com>
<CANxoLDd517cU_yD_QpP1tPhePBRYQ5HoPR1y=HXc3HeDFbac4w@mail.gmail.com>
<CANxoLDdF0ooA5qQo4ymjzcsSxjPEYL6nCziWOTtwC4jSnQxeWQ@mail.gmail.com>
<CAM5-9D-jn-Di9D3iAtsz8k8H2+_fNXU+aEj_GYOK+KuvmeiZJw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - applied.
On Wed, Sep 7, 2016 at 12:38 PM, Surinder Kumar <
[email protected]> wrote:
> Hi
>
> while closing query tool, the following error is display on python console.
>
> File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/tools/datagrid/__init__.py",
> line 270, in close
> manager.release(did=cmd_obj.did, conn_id=cmd_obj.conn_id)
> File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/
> utils/driver/psycopg2/__init__.py", line 1501, in release
> self.connections[my_id]._release()
> File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/
> utils/driver/psycopg2/__init__.py", line 1002, in _release
> if self.wasConneted:
> AttributeError: 'Connection' object has no attribute 'wasConneted'
>
> *Issue:*
> This issue is due to typo. Please find attached patch.
>
> On Tue, Sep 6, 2016 at 6:35 PM, Akshay Joshi <
> [email protected]> wrote:
>
>> Code looks good to me. Patch applied.
>>
>> On Tue, Sep 6, 2016 at 12:05 PM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Fri, Sep 2, 2016 at 7:49 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Akshay, can you review/commit this please?
>>>>
>>>
>>> Sure.
>>>
>>>>
>>>> Thanks.
>>>>
>>>> On Tue, Aug 30, 2016 at 5:05 PM, Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> On Tue, Aug 30, 2016 at 7:16 PM, Ashesh Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Please find the add-on patch on top of the current change.
>>>>>>
>>>>>> Can you please take a look at it?
>>>>>> This mainly works on the postgres driver to make an attempt to
>>>>>> reconnect the server.
>>>>>>
>>>>>
>>>>> One more attempt with some more corner cases handling.
>>>>> * Handled the connection-lost, and object gone error on client side
>>>>> during 'refresh' operation.
>>>>> * Handle the reconnection more consistently (even during cursor object
>>>>> creation).
>>>>>
>>>>> Please take a look at it.
>>>>>
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>> <http://www.enterprisedb.com/;
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com;
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Re: RM#1387 [Add-on PATCH] Bad handling of missing connection database server
In-Reply-To: <CA+OCxozEfTUpKxxE=fiZkt7d20cbQn32V813TEZ-6XGqow1kRw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox