Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTkuB-00054y-Mu for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 09:20:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fTkuA-000547-Ou for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 09:20:26 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTksz-00047S-2F for pgadmin-hackers@lists.postgresql.org; Fri, 15 Jun 2018 09:19:13 +0000 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fTksu-0003so-6x for pgadmin-hackers@postgresql.org; Fri, 15 Jun 2018 09:19:10 +0000 Received: by mail-wr0-x232.google.com with SMTP id l41-v6so9199455wre.7 for ; Fri, 15 Jun 2018 02:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=C9OxDwvnAZydkRZ98Grlfm3Zv8vFiDePdGOJQaBqJ10=; b=KEY9+d8QBKYAmoe720JhCM0WYT5mXxGLKBOWFeAaiLUV9X+65ZYIxBnS/Zkc44yDdu pdoLrzMX27sTTWPWYfxb8RT2IMgIDnUb7gX1xOH5e128fIyBMBguu9itz3T3rfCIRR9+ rUf7OKwgK0muGInWJq/58FRUT34updG74lIfTEY6P7yaeJ5d0RHyP28TiwdovuslthbE PcY36NKtBWM7QmFNxezhjxtZD6+wJrb5RnGdQKmlrEfKHMATMUl9xWfYxCHZ3Guel2KW 47O838aAeTd7Vmskaah/mepPqRmKI0cGqYBOLCYXGiDvbzEpVoqQqXeDHgX5B2WGEmd6 qcMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C9OxDwvnAZydkRZ98Grlfm3Zv8vFiDePdGOJQaBqJ10=; b=A3NQQILDSnIFccnEk1Z8R2aAmzU6knHgl61qafAJTW0RhYUtUnjD7reSeGI+AVB+Al xVz1xM4UV2GAaioJ93SXnOqZhiPCHa9acslDAyh/F2efWgWLP9MqD/xIuPAjMQ2biZBZ aT9LfeLPyO3xSvw2KR5gDfyYyNWX7m9iAAAs3iJ/eKFEYs6bvmjJb9UNVN46BUnF8ff0 jPawmZwlW0pUHf8/ktkWevfex/jbF1gRAEgOoC5hCKVsI4Q5Yctbc7ci+rBe8sEArz/v n8cbAqxK9DAgP2tZ2f4l0rtxklsFw7WO04DHtSKzUxPoelZyccmTNunGw90VxQGF1xKx vUeQ== X-Gm-Message-State: APt69E3zBUQUdjiD4ZO7Naluzy43XfKPQ7mTfmI6Lj00IgWIGGwqgVLp aHM8fn8daCpg1DgWJvFwQPiAMBFqVixmLFJA/l53vw== X-Google-Smtp-Source: ADUXVKJl8mWoP/uNxDopeJQemOmGUpMypnmMsagg0Y0RjOGK2MuqcXydO3tn/YkyppR2b7yCp2arYp0wwTm/f5vppSo= X-Received: by 2002:adf:8211:: with SMTP id 17-v6mr900342wrb.144.1529054346663; Fri, 15 Jun 2018 02:19:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Fri, 15 Jun 2018 02:19:05 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 15 Jun 2018 10:19:05 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000002cea22056eaab580" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000002cea22056eaab580 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Jun 14, 2018 at 10:34 AM, Akshay Joshi < akshay.joshi@enterprisedb.com> wrote: > Hi > > On Thu, Jun 14, 2018 at 2:48 PM, Dave Page wrote: > >> >> >> On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch for the Feature #2686 Property to switch >>>>> lower/upper case auto completion. I have added new preferences settings >>>>> "Keywords in uppercase" if it is set to True then all the keywords are >>>>> shown in upper case in auto completion. >>>>> >>>>> I have also implemented the second request in the RM to change the >>>>> selected text to upper/lower case. For that I have added new keyboard >>>>> shortcut "Toggle case of selected text" in preferences dialog. >>>>> Default key is "Ctrl + Shift + u". >>>>> >>>>> Please review it. >>>>> >>>> >>>> I don't see any doc updates in the patch - seems like that was >>>> forgotten? >>>> >>> >>> You mean to say ".rst" files? If yes, then sorry I forgot to update >>> that. Will do it and send the modified patch. >>> >> >> Yes (and any screenshots). Thanks. >> > > Done. Attached is the updated patch. > >> >> >>> >>>> Any opportunities to re-factor the code in that area into more testable >>>> functions? >>>> >>> >>> I have modified the files which are already re-factored. I haven't >>> seen any logic that can be re-factored. >>> >> >> Great, thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000002cea22056eaab580 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Jun 14, 2018 at 10:34 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0

=
On Thu, Jun 14, 2018 at 2:48 PM= , Dave Page <dpage@pgadmin.org> wrote:


On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Thu, Jun 14, 2018 at 1:14 PM, Dave= Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attach= ed is the patch for the Feature=C2=A0#2686 Property to switch lower/upper c= ase auto completion. I have added new preferences settings "Keywords i= n uppercase" if it is set to True then all the keywords are shown in u= pper case in auto completion.

I have also implemen= ted the second request in the RM to change the selected text to upper/lower= case. For that I have added new keyboard shortcut "Toggle case of sel= ected text" in preferences dialog. Default key is "Ctrl + Shift + u".

Please review it.=C2=A0

I don't see any doc updates in the patch - seems like that was forgo= tten?

=C2=A0= =C2=A0 You mean to say ".rst" files? If yes, then sorry I forgot= to update that. Will do it and send the modified patch.=C2=A0
<= /div>

Yes (and any screenshots= ). Thanks.

= =C2=A0 =C2=A0 Done. Attached is the updated patch.=C2=A0=C2=A0
=C2=A0

Any opport= unities to re-factor the code in that area into more testable functions?=C2= =A0

=C2=A0 = =C2=A0 I have modified the files which are already re-factored. I haven'= ;t seen any logic that can be re-factored.=C2=A0 =C2=A0

Great, thanks.=C2=A0

--
Dave PageBlog: http://pgs= nake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company



<= /div>--
Akshay Joshi
Sr. Sof= tware Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /b>



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--0000000000002cea22056eaab580--