Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6IET-0005Oz-PV for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 16:04:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f6IES-0008CT-BC for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 16:04:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6IER-0008CI-U3 for pgadmin-hackers@lists.postgresql.org; Wed, 11 Apr 2018 16:04:24 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f6IEO-0003Ud-8I for pgadmin-hackers@postgresql.org; Wed, 11 Apr 2018 16:04:22 +0000 Received: by mail-wm0-x241.google.com with SMTP id i3so4720730wmf.3 for ; Wed, 11 Apr 2018 09:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vDE2ED5FjUD9Zd/RzMw19pt6HGaq/90bnpOMd+xU0YE=; b=SMP32WQBBMpBH///ZUAAGgeBr6MF8FgYTgef0cxwABrMIt0jObur0Rg/RTzKUncE// 1LPhC1NpRsyX2qPvdbdKOo1MNF4aok2V0oxsh+NEQDsie65LcNh87z85ftL8AlVrTMXP gFaZFTWbB/Ow6VzJZuWh64HiFk4onzhUoDNS2/7aZEVvfOkHSsJqOFREzEcTtBAwd0GC NLfVcUlFSi+LSpXCMaCYlFWAzL3og5OV0o8bJXbesLEdVPNhxu5WVtTnKa/V1y45CWgm y0Lowz1sUjXgFWc6vcxgYiC2Z8eD7kZZq7Mfh31HCykoQd2L0GFw9qjazcslo/+4mFd4 XLlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vDE2ED5FjUD9Zd/RzMw19pt6HGaq/90bnpOMd+xU0YE=; b=nOu0hFcjIwbFQ2ZgVhxGI4i7/JY+xTmh7QaYjg/faahRtZhEAe5lpJDQyr3x4IqUpp xG3DHZrD7GkDnqEdkrn0GeLxaRw/VTPcfo+u8kOEE4jZzOw9iO/LPtQX9IJW3e4Rigvy VJbTmAFdXAoIfZ2KwN7qts39O4OFDs7urWcILYQPOFGB14EfFcaj8+CQiqnWrOM2dhz1 9Yrj90yLyhH+nvV1yVClD5YPYVjgs6euDyhJ8WqOpQyeKe+s6eSnT8KVsJcxHcVN5/iP Scrn+miiW1SRElDBB7svd52ctCh/26ufAShu4EgXrsSjo3r+ITzL0iOnOPtr75rMaB2w YlRg== X-Gm-Message-State: ALQs6tCyO5MZxahSMwoCgMe7jJOK74rwr9r+SOqgqDyrw0EwEkWeeAmu AlyCuoN+724ATtYmGXI6dE4fFrpgyUOo0MKz8hjzoQ== X-Google-Smtp-Source: AIpwx4829/Pz8ffNUFc5WyLTT4djXsQ0UOuDQUONlCzTDJBWnaoJarNJK9fNJj4yxCiMMQA2/BiB5c/dafSgh20GpLE= X-Received: by 10.28.45.9 with SMTP id t9mr2901377wmt.161.1523462658372; Wed, 11 Apr 2018 09:04:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 11 Apr 2018 09:04:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 11 Apr 2018 17:04:17 +0100 Message-ID: Subject: Re: Bug #3083 fix To: Joao De Almeida Pereira Cc: Harshal Dhumal , Akshay Joshi , Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114248a094cf53056994ca6c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114248a094cf53056994ca6c Content-Type: text/plain; charset="UTF-8" Hi On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Dave, > Do you still have issues in your environment? > I just tested on my MBP, and got the following failure: ====================================================================== ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) Query tool feature test ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py", line 43, in setUp self.before() File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py", line 46, in before self._reset_options() File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py", line 113, in _reset_options self.page.fill_codemirror_area_with('') File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 227, in fill_codemirror_area_with until(find_codemirror, "Timed out waiting for codemirror " File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 80, in click self._execute(Command.CLICK_ELEMENT) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 628, in _execute return self._parent.execute(command, params) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 312, in execute self.error_handler.check_response(response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response raise exception_class(message, screen, stacktrace) WebDriverException: Message: unknown error: Element is not clickable at point (813, 155). Other element would receive the click:
...
(Session info: chrome=65.0.3325.181) (Driver info: chromedriver=2.37.544337 (8c0344a12e552148c185f7d5117db1f28d6c9e85),platform=Mac OS X 10.12.6 x86_64) > > Thanks > Joao > > On Wed, Apr 11, 2018 at 5:56 AM Dave Page wrote: > >> Joao, are you looking at this? >> >> On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote: >>> >>>> Argh, managed to send before I finished typing... >>>> >>>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < >>>>> jdealmeidapereira@pivotal.io> wrote: >>>>> >>>>>> Hi Dave, >>>>>> That looks like in the surrounding area of the change. We run our >>>>>> pipeline and everything was green. >>>>>> Can you provide more details, which python version are you using? OS? >>>>>> >>>>> >>>>> That was on my travel laptop, which is macOS Sierra with the Apple >>>>> supplied Python 2.7. >>>>> >>>>> Interestingly, I'm on my dev laptop today (same OS and Python) and >>>>> it's working just fine. The difference is that the travel machine is a 12" >>>>> Macbook, whilst the dev machine is >>>>> >>>> >>>> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if >>>> the small screen size is causing a problem with this test, something we >>>> have seen before. >>>> >>>> >>> >>> Yes, screen size does cause problem. Slick grid does not render all >>> columns if viewport is not wide enough (like it does for rows). >>> Remaining columns would render when user scrolls right. >>> >>> To avoid similar problem in datatype feature test (commit: >>> 88bcd3b5129db88975421e26c1bf188daf4892f9 >>> ) >>> I have executed >>> queries in batch to limit number of columns in single query result. >>> >>> >>> >>>> >>>>> >>>>>> >>>>>> Thanks >>>>>> Joao >>>>>> >>>>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>> >>>>>>>> Hey Akshay and Neethu >>>>>>>> >>>>>>>> We refactored the patch to add tests for the resize feature. We >>>>>>>> were able to write test cases for the drag event by using spies and setting >>>>>>>> the rect dimensions. In cases like this, we can just test some components >>>>>>>> in order to have enough confidence in the code. So we isolated the >>>>>>>> function that implements the behavior of this feature and tested that it >>>>>>>> was performing as expected. >>>>>>>> >>>>>>>> We ran the patch through the pipelines and all of the tests passed. >>>>>>>> >>>>>>> >>>>>>> I'm consistently seeing the feature test failure below with this >>>>>>> patch applied: >>>>>>> >>>>>>> ============================================================ >>>>>>> ========== >>>>>>> FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries. >>>>>>> CheckForViewDataTest) >>>>>>> Validate Insert, Update operations in View/Edit data with given test >>>>>>> data >>>>>>> ------------------------------------------------------------ >>>>>>> ---------- >>>>>>> Traceback (most recent call last): >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>>>> line 125, in runTest >>>>>>> self._verify_row_data(True) >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>>>> line 325, in _verify_row_data >>>>>>> self.assertEquals(cells[idx], config_data[str(idx)][1]) >>>>>>> AssertionError: u'[null]' != u'1' >>>>>>> - [null] >>>>>>> + 1 >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114248a094cf53056994ca6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave,
Do you still ha= ve issues in your environment?

= I just tested on my MBP, and got the following failure:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFea= tureTest)
Query tool feature test
---------------------= -------------------------------------------------
Traceback (most= recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/w= eb/regression/feature_utils/base_feature_test.py", line 43, in setUp
=C2=A0 =C2=A0 self.before()
=C2=A0 File "/Users/dpa= ge/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py", line 4= 6, in before
=C2=A0 =C2=A0 self._reset_options()
=C2=A0= File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_= tests.py", line 113, in _reset_options
=C2=A0 =C2=A0 self.pa= ge.fill_codemirror_area_with('')
=C2=A0 File "/Users= /dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", lin= e 227, in fill_codemirror_area_with
=C2=A0 =C2=A0 until(find_code= mirror, "Timed out waiting for codemirror "
=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selen= ium/webdriver/remote/webelement.py", line 80, in click
=C2= =A0 =C2=A0 self._execute(Command.CLICK_ELEMENT)
=C2=A0 File "= ;/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/we= bdriver/remote/webelement.py", line 628, in _execute
=C2=A0 = =C2=A0 return self._parent.execute(command, params)
=C2=A0 File &= quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/seleniu= m/webdriver/remote/webdriver.py", line 312, in execute
=C2= =A0 =C2=A0 self.error_handler.check_response(response)
=C2=A0 Fil= e "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/sele= nium/webdriver/remote/errorhandler.py", line 242, in check_response
=C2=A0 =C2=A0 raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element <iframe cd_f= rame_id_=3D"6af0765089f43a73f733471ef04cb792">...</iframe&g= t; is not clickable at point (813, 155). Other element would receive the cl= ick: <div class=3D"wcLoadingIconContainer">...</div><= /div>
=C2=A0 (Session info: chrome=3D65.0.3325.181)
=C2=A0 (D= river info: chromedriver=3D2.37.544337 (8c0344a12e552148c185f7d5117db1f28d6= c9e85),platform=3DMac OS X 10.12.6 x86_64)

= =C2=A0

Thanks
Joao

O= n Wed, Apr 11, 2018 at 5:56 AM Dave Page <dpage@pgadmin.org> wrote:
Joao, are you lo= oking at this?

On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <harshal.d= humal@enterprisedb.com> wrote:


--=C2=A0
<= b>Harshal Dhumal
Sr. Software Engineer
En= terpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise Po= stgreSQL Company
=

On Tue, Apr 3, 2018 at 6:10 PM, Dave P= age <dpage@pgadmin.org> wrote:
Argh, managed to send before I fin= ished typing...

On Tue, Apr 3, 2018 at 1:38 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
Hi

On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereir= a <jdealmeidapereira@pivotal.io> wrote:
Hi Dave,
T= hat looks like in the surrounding area of the change. We run our pipeline a= nd everything was green.
Can you provide more details, which pyth= on version are you using? OS?

That was on my travel laptop, which is macOS Sierra with the Apple su= pplied Python 2.7.

Interestingly, I'm on my de= v laptop today (same OS and Python) and it's working just fine. The dif= ference is that the travel machine is a 12" Macbook, whilst the dev ma= chine is=C2=A0

a 15" MacBook Pro with 2 24" external monitors. That makes me = wonder if the small screen size is causing a problem with this test, someth= ing we have seen before.
=C2=A0

Yes, scre= en size does cause problem. Slick grid does not render all columns if viewp= ort is not wide enough (like it does for rows).
Remaining col= umns would render when user scrolls right.

To avoid simil= ar problem in datatype feature test (commit: 88bcd3b5129db88975421e26c1bf188da= f4892f9) I have executed
queries in batch to limit number of columns= in single query result.

=C2=A0
=C2=A0
<= br>
Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> wrote:
=
Hi=

<= /div>
On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <jdea= lmeidapereira@pivotal.io> wrote:
Hey Akshay and Neethu

We refactored the patch to add tests for the resize feature.=C2=A0 = We were able to write test cases for the drag event by using spies and sett= ing the rect dimensions.=C2=A0 In cases like this, we can just test some co= mponents in order to have enough confidence in the code.=C2=A0 So we isolat= ed the function that implements the behavior of this feature and tested tha= t it was performing as expected.

We ran the patch = through the pipelines and all of the tests passed.
=

I'm consistently seeing the feature t= est failure below with this patch applied:

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View= /Edit data with given test data
----------------------------------------------------------------------
Traceback (most r= ecent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", line 125, = in runTest
=C2=A0 =C2=A0 self._verify_row_data(True)
= =C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/= view_data_dml_queries.py", line 325, in _verify_row_data
=C2=A0 =C2=A0 self.assertEquals(cells[idx], config_data[str(idx)][1])
AssertionError: u'[null]' !=3D u'1'
- [nul= l]
+ 1


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=



--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company



--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company




--
Dave= Page
Blog: ht= tp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: = http://www.enterp= risedb.com
The Enterprise PostgreSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company
--001a114248a094cf53056994ca6c--