public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Feature #5370 User should be able to set the binary path for each database server
Date: Thu, 13 May 2021 10:39:42 +0100
Message-ID: <CA+OCxozFY0Vs_KmhmCR0ranY=ti-Qc5YU1vM1nPsj0erQDnWvQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfe8H-E9qmO1KYiRVodpBRWPcEmxKKKwPXQ4MDShE9XPQ@mail.gmail.com>
References: <CANxoLDfRrBE4e0sFL7nt7GxRy4ALyjCMSwv_YC1RPq33uWBzwA@mail.gmail.com>
<CAM9w-_nYDWxCVOB6-xLu-Yqw79juoAKv1Jv7UJcSujphPK2hkg@mail.gmail.com>
<CANxoLDfe8H-E9qmO1KYiRVodpBRWPcEmxKKKwPXQ4MDShE9XPQ@mail.gmail.com>
Hi Akshay,
On Thu, May 13, 2021 at 10:35 AM Akshay Joshi <[email protected]>
wrote:
> Hi Aditya/Hackers
>
> [image: Screenshot 2021-05-13 at 3.02.59 PM.png]
>
> Are the above changes looks good?
>
Well, s/Global/Default, but otherwise that, and the other UI is fine.
However, that does mean the path needs to be set for every server (and keep
in mind, I know some users of this code have hundreds registered), and it
also means that we cannot pre-configure the paths in, for example, our
container.
I'd prefer to see all the configuration in Preferences, so we'd maybe have
a grid instead of a text field, containing three columns, one with the
major version number, and one with the path to use for that version. The
third column would be a radio button to mark a particular path as the
default to use in case another path isn't set.
>
>
> On Thu, May 13, 2021 at 2:43 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> Just to make it more discoverable, please also change the help text in
>> Preferences dialog.
>>
>> On Thu, May 13, 2021 at 2:26 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Dave/Hackers
>>>
>>> I have implemented feature #5370 "User should be able to set the binary
>>> path for each database server." I have added "Utility path" control in the
>>> Advanced tab of the server dialog, refer to the image below:
>>>
>>> [image: Screenshot 2021-05-13 at 2.11.52
>>> PM.png]
>>>
>>> If the above path is set by the user then will pick that else we will
>>> pick the default binary path of the preferences dialog (if set). In case
>>> utility is not found on the specified path we raise the popup dialog with
>>> the modified error message.
>>>
>>> [image: Screenshot 2021-05-13 at 2.12.28
>>> PM.png]
>>>
>>> If the above implementation looks good then, I'll commit this feature by
>>> today's EOD.
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Attachments:
[image/png] Screenshot 2021-05-13 at 2.11.52 PM.png (110.6K, 3-Screenshot%202021-05-13%20at%202.11.52%20PM.png)
download | view image
[image/png] Screenshot 2021-05-13 at 2.12.28 PM.png (47.8K, 4-Screenshot%202021-05-13%20at%202.12.28%20PM.png)
download | view image
[image/png] Screenshot 2021-05-13 at 3.02.59 PM.png (150.0K, 5-Screenshot%202021-05-13%20at%203.02.59%20PM.png)
download | view image
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Feature #5370 User should be able to set the binary path for each database server
In-Reply-To: <CA+OCxozFY0Vs_KmhmCR0ranY=ti-Qc5YU1vM1nPsj0erQDnWvQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox