Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etrc6-0007di-Ud for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:13:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etrc5-0005aY-TG for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Mar 2018 09:13:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etrc5-0005aJ-Ht for pgadmin-hackers@lists.postgresql.org; Thu, 08 Mar 2018 09:13:25 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etrc1-0001Dh-Bc for pgadmin-hackers@postgresql.org; Thu, 08 Mar 2018 09:13:25 +0000 Received: by mail-wm0-x231.google.com with SMTP id t6so9650094wmt.5 for ; Thu, 08 Mar 2018 01:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hnFT7pTr5RRuMhqf/Eq3+5096nPtbaQiuLVSZWLxl9Q=; b=DGvbem+Ed5m7NKmaLuajuoc9EmYGlfPW+1nncWhoFKp+FFZ6UMwxhi8EPquZcMAXLl iiaFXXX7aUWP6hMb3WI2rd6gz2PgNDaKJaWBW+7hQxUhVwWm5nRz4/Q5A/+DfkCfNkTj KwLpknLof5aJ1tPCTRsZIS/21cBSRXO+Gn2QI3+UsXxb9nhkvtFAG8XPjCcP4Hz+7nKc xWopzFumzJWKhR0I8WkS0Rvsz6WsS0rlWB1YOlLUkzciVBlT68hVOS0Umr1xtG0Ibg/y tE4d91ClpKk5LkZ1UFJwxP31vz5fri3p9kBBFPjDCJkXsj55rzZS3QYiH7/GI13O4dh9 pIlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hnFT7pTr5RRuMhqf/Eq3+5096nPtbaQiuLVSZWLxl9Q=; b=kar7bQD5w+1l9h0OHcr8Os8MNnHLkrwx3CoWkKeM71Ag3jBhAlUEUEwcyepVBy3XB2 HI0DnqyGLlM3NgjITtU5swa4WO/BnhlHVgGPifClT8EanyWUILoUuqhlf4XPpxLKezF3 2nb0nltn2CtxcUhnZOkTMTzdqiF4HyqxQmI8U9zqyPd8MkrqQ7CFFIr32eUHWNnjDSTz BizQMKFTnDAHD2VewbR4eerT6CgP6MXiXDs2BRh5A9v3WlC1EkZv976rUl3N6D6ZBE4Y A2uW77XXQ1fqsUXtszdYwnAS4SujYczR1vae8N9bYBU+n1g4hbXcl9Q4PRB1gophSdQO HXLQ== X-Gm-Message-State: AElRT7F/udk+wMCwE4X9Ip6FxK4PeqGsFT6/rXmFr5zjNo2UFkxFm5bX fY0Te7xe1r4OGXMF7Q5qj0XXljdNRpgjRB8aeuvO3g== X-Google-Smtp-Source: AG47ELvJZgaiIP/MFJwd7aJaqLwCK9CvLNn9RC8AwGhKW9KiS7V6Ueo82CLJ+I+s+S8Ffz46BrjPjvib+eRbSzlwnhI= X-Received: by 10.28.5.75 with SMTP id 72mr17763109wmf.154.1520500400546; Thu, 08 Mar 2018 01:13:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 8 Mar 2018 01:13:19 -0800 (PST) In-Reply-To: References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org> From: Dave Page Date: Thu, 8 Mar 2018 09:13:19 +0000 Message-ID: Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507 To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114429c8417c180566e316ca" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114429c8417c180566e316ca Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch to fix this. >> I have fixed this issue in the StartRunningQueryTest class, this test >> class changes the behaviour of the methods through MagicMock and due to >> this this test case is failing. >> >> Revised patch with some modification. > >> Thanks, >> Khushboo >> >> >> On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: >>> >>>> It still seems to be failing :-( >>>> >>>> :( >>> >>>> https://jenkins.pgadmin.org/job/pgadmin4-master-python26/las >>>> tFailedBuild/consoleFull >>>> >>>> On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: >>>> >>>>> Thanks, applied. Lets see what happens. >>>>> >>>>> On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Please find the attached updated patch. >>>>>> This should work. >>>>>> >>>>>> >>>>>> On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < >>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Dave, >>>>>>>>>> >>>>>>>>>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Khushboo, can you look at this ASAP please? It passed tests on >>>>>>>>>>> my machine, but Jenkins isn't happy. >>>>>>>>>>> >>>>>>>>>>> I have tried to reproduce the issue with many combination but >>>>>>>>>> couldn't reproduce it. >>>>>>>>>> With the help of logs, I have tried to fix it. Can you please >>>>>>>>>> check this fix is helpful or not? >>>>>>>>>> >>>>>>>>> >>>>>>>>> On my laptop I now get: >>>>>>>>> >>>>>>>>> ============================================================ >>>>>>>>> ========== >>>>>>>>> ERROR: runTest (pgadmin.tools.sqleditor.tests >>>>>>>>> .test_poll_query_tool.TestPollQueryTool) >>>>>>>>> When query tool polling returns messages with result data-set >>>>>>>>> ------------------------------------------------------------ >>>>>>>>> ---------- >>>>>>>>> Traceback (most recent call last): >>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>> /pgadmin/tools/sqleditor/tests/test_poll_query_tool.py", line >>>>>>>>> 104, in runTest >>>>>>>>> response_data['data']['additional_messages']) >>>>>>>>> File "/System/Library/Frameworks/Py >>>>>>>>> thon.framework/Versions/2.7/lib/python2.7/unittest/case.py", line >>>>>>>>> 802, in assertIn >>>>>>>>> if member not in container: >>>>>>>>> TypeError: argument of type 'NoneType' is not iterable >>>>>>>>> >>>>>>>>> ------------------------------------------------------------ >>>>>>>>> ---------- >>>>>>>>> >>>>>>>>> Please provide some more details. Is this failing for particular >>>>>>>> server version? >>>>>>>> I am not getting any error with this patch and without this patch >>>>>>>> on PY2 and PY3 with a single/multiple servers. >>>>>>>> >>>>>>> >>>>>>> Python 2.7.10 on macOS Sierra, testing against PostgreSQL 9.4. Here >>>>>>> are the package versions in the venv: >>>>>>> >>>>>>> alabaster==0.7.10 >>>>>>> alembic==0.9.6 >>>>>>> args==0.1.0 >>>>>>> Babel==2.3.4 >>>>>>> backports.csv==1.0.4 >>>>>>> beautifulsoup4==4.4.1 >>>>>>> blinker==1.3 >>>>>>> chromedriver-installer==0.0.6 >>>>>>> click==6.6 >>>>>>> clint==0.5.1 >>>>>>> dateutils==0.6.6 >>>>>>> docutils==0.13.1 >>>>>>> extras==1.0.0 >>>>>>> fixtures==3.0.0 >>>>>>> Flask==0.11.1 >>>>>>> Flask-Babel==0.11.1 >>>>>>> Flask-Gravatar==0.4.2 >>>>>>> Flask-HTMLmin==1.2 >>>>>>> Flask-Login==0.3.2 >>>>>>> Flask-Mail==0.9.1 >>>>>>> Flask-Migrate==2.0.3 >>>>>>> Flask-Paranoid==0.1.0 >>>>>>> Flask-Principal==0.4.0 >>>>>>> Flask-Script==2.0.6 >>>>>>> Flask-Security==1.7.5 >>>>>>> Flask-SQLAlchemy==2.1 >>>>>>> Flask-WTF==0.12 >>>>>>> funcsigs==1.0.2 >>>>>>> html5lib==1.0b3 >>>>>>> htmlmin==0.1.11 >>>>>>> imagesize==0.7.1 >>>>>>> importlib==1.0.3 >>>>>>> itsdangerous==0.24 >>>>>>> Jinja2==2.7.3 >>>>>>> linecache2==1.0.0 >>>>>>> Mako==1.0.7 >>>>>>> MarkupSafe==0.23 >>>>>>> minify==0.1.4 >>>>>>> mock==2.0.0 >>>>>>> passlib==1.6.2 >>>>>>> pbr==3.1.1 >>>>>>> pkginfo==1.4.1 >>>>>>> psycopg2==2.7.3.2 >>>>>>> pycodestyle==2.3.1 >>>>>>> pycrypto==2.6.1 >>>>>>> Pygments==2.2.0 >>>>>>> pyperclip==1.5.32 >>>>>>> pyrsistent==0.14.0 >>>>>>> python-dateutil==2.5.0 >>>>>>> python-editor==1.0.3 >>>>>>> python-mimeparse==1.6.0 >>>>>>> pytz==2014.10 >>>>>>> requests==2.13.0 >>>>>>> requests-toolbelt==0.7.1 >>>>>>> selenium==3.3.3 >>>>>>> simplejson==3.6.5 >>>>>>> six==1.11.0 >>>>>>> snowballstemmer==1.2.1 >>>>>>> speaklater==1.3 >>>>>>> Sphinx==1.5.3 >>>>>>> SQLAlchemy==1.0.14 >>>>>>> sqlparse==0.1.19 >>>>>>> testscenarios==0.5.0 >>>>>>> testtools==2.0.0 >>>>>>> traceback2==1.4.0 >>>>>>> unittest2==1.1.0 >>>>>>> Werkzeug==0.9.6 >>>>>>> WTForms==2.0.2 >>>>>>> yuicompressor==2.4.8 >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114429c8417c180566e316ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Wed, Mar 7, 2018 at 11:13 = PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
Hi Da= ve,

Please find the patch to fix this.
I have = fixed this issue in the StartRunningQueryTest class, this test class change= s the behaviour of the methods through MagicMock and due to this this test = case is failing.

Revised= patch with some modification.=C2=A0
Thanks,
Khu= shboo

=

On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">


On Wed, Mar 7, 2018 at 10:33 PM, Da= ve Page <dpage@pgadmin.org> wrote:
It still seems to be failing :-(

=
:(=C2=A0
<= br>
On Wed, Mar 7, 2018 at 4:50 PM, Dave Page <d= page@pgadmin.org> wrote:
Thanks, applied. Lets see what happens.
On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi = <khushboo.vashi@enterprisedb.com> wrote:<= br>
Please find the attached= updated patch.
This should work.


On Wed, Mar 7, 2018 at 9:46 PM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, Mar 7, 201= 8 at 4:13 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.c<= wbr>om> wrote:


On Wed, Mar 7, 2018 at 9:23 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

<= div class=3D"gmail_quote">On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Va= shi <khushboo.vashi@enterprisedb.com> wro= te:
H= i Dave,

On Wed, M= ar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:<= br>
Khush= boo, can you look at this ASAP please? It passed tests on my machine, but J= enkins isn't happy.

I have= tried to reproduce the issue with many combination but couldn't reprod= uce it.
With the help of logs, I have tried to fix it. Can you pl= ease check this fix is helpful or not?=C2=A0

On my laptop I now get:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D
ERROR: runTest (pgadmin.tools.sqleditor.tests.test_po= ll_query_tool.TestPollQueryTool)
When query tool polli= ng returns messages with result data-set
-----------------= -----------------------------------------------------
T= raceback (most recent call last):
=C2=A0 File "/Users/dpage/= git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_to= ol.py", line 104, in runTest
=C2=A0 =C2=A0 response_data[= 9;data']['additional_messages'])
=C2=A0 File &qu= ot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/p= ython2.7/unittest/case.py", line 802, in assertIn
=C2=A0 =C2= =A0 if member not in container:
TypeError: argument of type '= NoneType' is not iterable

--------------------= --------------------------------------------------=C2=A0

Please = provide some more details. Is this failing for particular server version?
I am not getting any error with this patch and without this patch = on PY2 and PY3 with a single/multiple servers.

Python 2.7.10 on macOS Sierra, testing a= gainst PostgreSQL 9.4. Here are the package versions in the venv:

alabaster=3D=3D0.7.10
alembic=3D=3D0.9.6
args=3D=3D0.1.0
Babel=3D=3D2.3.4
backports.csv= =3D=3D1.0.4
beautifulsoup4=3D=3D4.4.1
blinker=3D=3D1.3<= /div>
chromedriver-installer=3D=3D0.0.6
click=3D=3D6.6
<= div>clint=3D=3D0.5.1
dateutils=3D=3D0.6.6
docutils=3D= =3D0.13.1
extras=3D=3D1.0.0
fixtures=3D=3D3.0.0
Flask=3D=3D0.11.1
Flask-Babel=3D=3D0.11.1
Flask-Grav= atar=3D=3D0.4.2
Flask-HTMLmin=3D=3D1.2
Flask-Login=3D= =3D0.3.2
Flask-Mail=3D=3D0.9.1
Flask-Migrate=3D=3D2.0.3=
Flask-Paranoid=3D=3D0.1.0
Flask-Principal=3D=3D0.4.0
Flask-Script=3D=3D2.0.6
Flask-Security=3D=3D1.7.5
<= div>Flask-SQLAlchemy=3D=3D2.1
Flask-WTF=3D=3D0.12
funcs= igs=3D=3D1.0.2
html5lib=3D=3D1.0b3
htmlmin=3D=3D0.1.11<= /div>
imagesize=3D=3D0.7.1
importlib=3D=3D1.0.3
its= dangerous=3D=3D0.24
Jinja2=3D=3D2.7.3
linecache2=3D=3D1= .0.0
Mako=3D=3D1.0.7
MarkupSafe=3D=3D0.23
min= ify=3D=3D0.1.4
mock=3D=3D2.0.0
passlib=3D=3D1.6.2
=
pbr=3D=3D3.1.1
pkginfo=3D=3D1.4.1
psycopg2=3D=3D2.= 7.3.2
pycodestyle=3D=3D2.3.1
pycrypto=3D=3D2.6.1
<= div>Pygments=3D=3D2.2.0
pyperclip=3D=3D1.5.32
pyrsisten= t=3D=3D0.14.0
python-dateutil=3D=3D2.5.0
python-editor= =3D=3D1.0.3
python-mimeparse=3D=3D1.6.0
pytz=3D=3D2014.= 10
requests=3D=3D2.13.0
requests-toolbelt=3D=3D0.7.1
selenium=3D=3D3.3.3
simplejson=3D=3D3.6.5
six= =3D=3D1.11.0
snowballstemmer=3D=3D1.2.1
speaklater=3D= =3D1.3
Sphinx=3D=3D1.5.3
SQLAlchemy=3D=3D1.0.14
sqlparse=3D=3D0.1.19
testscenarios=3D=3D0.5.0
testto= ols=3D=3D2.0.0
traceback2=3D=3D1.4.0
unittest2=3D=3D1.1= .0
Werkzeug=3D=3D0.9.6
WTForms=3D=3D2.0.2
yui= compressor=3D=3D2.4.8

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

E= nterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company






--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114429c8417c180566e316ca--