MIME-Version: 1.0
References: 
 <3e6e541367894c4c95ac17f8050aad96@G08CNEXMBPEKD06.g08.fujitsu.local>
In-Reply-To: 
 <3e6e541367894c4c95ac17f8050aad96@G08CNEXMBPEKD06.g08.fujitsu.local>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 14 Jan 2021 09:14:43 +0000
Message-ID: 
 <CA+OCxozHHs4rDiD05GWLOjzd00h=9z3VZpX7M0eH==ap=b84YQ@mail.gmail.com>
Subject: Re: Is there a mistake in line 22 of Make.bat?
To: "Huang, Jun" <huangj.fnst@cn.fujitsu.com>
Cc: "pgadmin-hackers@postgresql.org" <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000005165fc05b8d8b06e"
Precedence: bulk

--0000000000005165fc05b8d8b06e
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <huangj.fnst@cn.fujitsu.com>
wrote:

> Hi,
>
> The following code is line 22 of Make.bat:
>         if "%Platform%" == "X86" (
>
> I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the
> result is "x86"(not "X86").
> If it's a mistake, the attached patch adds the changes.
>

Hmm, on the 32bit build VM I get this:

C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform%
X86

C:\Program Files (x86)\Microsoft Visual C++ Build Tools>

Which explains why everything works in the production builds. Note that
that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc.

Given that 32 bit Windows builds will be dropped soon, I'm inclined to
leave this as-is for now.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--0000000000005165fc05b8d8b06e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 14, 2021 at 1:20 AM Huang, =
Jun &lt;<a href=3D"mailto:huangj.fnst@cn.fujitsu.com">huangj.fnst@cn.fujits=
u.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">Hi,<br>
<br>
The following code is line 22 of Make.bat:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if &quot;%Platform%&quot; =3D=3D &quot;X86&quot=
; (<br>
<br>
I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the re=
sult is &quot;x86&quot;(not &quot;X86&quot;).<br>
If it&#39;s a mistake, the attached patch adds the changes.<br></blockquote=
><div><br></div><div>Hmm, on the 32bit build VM I get this:</div><div><br><=
/div><div>C:\Program Files (x86)\Microsoft Visual C++ Build Tools&gt;echo %=
Platform%<br>X86<br><br>C:\Program Files (x86)\Microsoft Visual C++ Build T=
ools&gt;<br></div><div><br></div><div>Which explains why everything works i=
n the production builds. Note that that system is VS 2015 though, but the 6=
4 bit builds are VS 2017 iirc.</div><div><br></div><div>Given that 32 bit W=
indows builds will be dropped soon, I&#39;m inclined to leave this as-is fo=
r now.</div><div>=C2=A0</div></div>-- <br><div dir=3D"ltr" class=3D"gmail_s=
ignature"><div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EDB: <a href=3D"http://www.enterprisedb.com" target=3D"_blank=
">http://www.enterprisedb.com</a><br><br></div></div></div>

--0000000000005165fc05b8d8b06e--