MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZT1XntE=3SC+FAoatWR0H3ecyZnQGfv9WY6d4=WbQ3+sw@mail.gmail.com>
References: 
 <CAKKotZR5b=JjkC5cS2x=TzVY2MfEhc+eHpcbMm41eW5jv4uYBA@mail.gmail.com>
 <CA+OCxow2ZO0RRELTnQo45o+mqX6GJpEEHzuZYGg0g6D6msb_9w@mail.gmail.com>
 <CAKKotZQNGSBSa=XjhKfDgBgMpAXEQUaMrBnNkW_F58q2CkdvLQ@mail.gmail.com>
 <CA+OCxoxcKKbHqmhaaOZKQLk1tqTkpereYzN5vCz3zS3oZbUM7A@mail.gmail.com>
 <CAKKotZRH-go6m2uhpVOs9-ps4SiLFvfbjeV5mf9NK+=GztToXw@mail.gmail.com>
 <CA+OCxozYsK_aV5Gwh95-dm4m3HoeS8VS4KwX4Ds7PUXcvmH6eg@mail.gmail.com>
 <CA+OCxowMFzdQm1fQPPAPF3je_-x6oh95XPYX3rW27R0DkYsVFQ@mail.gmail.com>
 <CAKKotZT2YcvNF-cr3XV_EGiWhc-mPvGZCe5r62YFYbx6Zxvhyw@mail.gmail.com>
 <CA+OCxoxf9shrYLa_WyZL5V2FKxV+Mu2UfjCBJCFNv50qyCrJwQ@mail.gmail.com>
 <CAKKotZQmyVg8eJD8+Ha+fNg=MUX_i6YcUJCkJwzp_sWf3mC=uA@mail.gmail.com>
 <CAKKotZQhqoX0FtSCWyuCpW96XsgR7+y3pc60H9VHzEHJCoqRDg@mail.gmail.com>
 <CA+OCxoxBv0QfbjdV2VFLEWWuTYO7YXmFuOwS+1eEXOVCa4rN4A@mail.gmail.com>
 <CAKKotZQ+-zCKvohhg0C-n+SE2dX3Y1d+KhHEWudcck86Jrx3Hw@mail.gmail.com>
 <CA+OCxozkMUiTbd5yNNibmm4YBB2Zsyv=594EXj+NUMFgvvX4TQ@mail.gmail.com>
 <CAKKotZT1XntE=3SC+FAoatWR0H3ecyZnQGfv9WY6d4=WbQ3+sw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 1 Aug 2016 15:24:19 +0100
Message-ID: 
 <CA+OCxozJCntCRBnDY0vyUM86sWeYn5id6SQxZZ=_RS6NhNRrLA@mail.gmail.com>
Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Mon, Aug 1, 2016 at 2:53 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Yes... :-)

OK, committed with the following:

                # If schema is public, prefix it. Otherwise, we should
already have it.
                if row['nspname'] == 'public':
                    rtn_type = "public." + row['typname']
                else:
                    rtn_type = row['typname']

> On Mon, Aug 1, 2016 at 7:16 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Mon, Aug 1, 2016 at 2:33 PM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > We have to added it because postgres format_type() function do not
>> > provide
>> > us type with 'public' schema prefix to it, due to which wrong SQL's are
>> > getting generated.
>> > Rest other types are pre fixed with their respective schema as required.
>>
>> OK, so:
>>
>>                 # If schema is not pg_catalog & then add schema
>>                 if row['nspname'] == 'public':
>>                     rtn_type = row['nspname'] + "." + row['typname']
>>                 else:
>>                     rtn_type = row['typname']
>>
>> ?
>>
>> != pg_catalog is redundant with == public.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers