Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyflf-0001OH-9C for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 15:35:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyfld-0007XU-UH for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 15:35:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyfld-0007X9-Ko for pgadmin-hackers@lists.postgresql.org; Wed, 21 Mar 2018 15:35:09 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyflZ-0000Ia-Nv for pgadmin-hackers@postgresql.org; Wed, 21 Mar 2018 15:35:09 +0000 Received: by mail-wm0-x22e.google.com with SMTP id l9so10558536wmh.2 for ; Wed, 21 Mar 2018 08:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=LSm/7IPuCyMg1mTxeoXLvhQUk3IhNz+Pceo5zrMnMf8=; b=CDktWFUXezyX27U0dEYxEpjvdUW+Q+q4pvL2l1JctJ10mA6lSrUzRR6Q1XuEZUrlyH 29/awwt6m3u9MVtvizUmvE6bB5+HuPRRWWeE0Kq9ndyl3LJxgR7wG7XNpYi4W2rZ5fFX Zjx0L499x/IuPNZx17Ae/Df39wz3d6QBOOEk1HkXVsvlNHnytrDh75n2V4LIIOXY1tfB TX6ShzUeyFXQrD3WtFF3SxWnk2ISgK4JbBLMKLT+VMSkUhs1uPU6diXxIlCDjby0CK6y +5604KXIEqiHNBuz8ZAtxCJSi8U/pw7Le6lGtx8tRCjwc9lhbBeN+GSdxe6XFHn6nwj3 TGaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=LSm/7IPuCyMg1mTxeoXLvhQUk3IhNz+Pceo5zrMnMf8=; b=M+jdsoo3r5XGirvAp8EwaMh8qyw24G30v+N35NbeTU8ItyE+EbpV4hPX5+dW0jUt94 GfVinwywHs4OqrlANhjHoSNOjWcQEq/fnICSXP4bI2dGkllfY6C4bSiO3cSapXKPyzgL k5OMPZjlyQXkOrss6ref2yqbMvyfKw3IkJ0aqycqYk0E5/ygGC2hR6t/CDcAq+pw84oK X+9NBWaMYWXx/03JQq/eVYzbbWRJNt7ruP0GP0y7FbOJG0YAqTBnZJjmzwoFxPtOMt/Y +mqnhnIMljpqijF9NyxrySR4s0Kwpb1epB/wuA8Y5AZOl3uXtdrWB2x0rL/Ai03XqUee Uf+w== X-Gm-Message-State: AElRT7EpX4ihauHP4uzH/0h9jBKGg3Hwfxb16kloqePwOxx8IzSXeo1m iOW9+uaHg0JLykiUBsjpK2AA1MEWJD44dRgfgpOOsqjgnho= X-Google-Smtp-Source: AG47ELs6HjGtZz+wCsf8iQPlEY1isHrjNYDZh9zXNCiQBWBQ6SIsz6It/7MNMJOo9IufiDP+YZCzi2MD2IxR8DeVrbg= X-Received: by 10.28.176.134 with SMTP id z128mr3156467wme.86.1521646504205; Wed, 21 Mar 2018 08:35:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 21 Mar 2018 08:35:03 -0700 (PDT) From: Dave Page Date: Wed, 21 Mar 2018 15:35:03 +0000 Message-ID: Subject: v3.0 release on hold To: pgadmin-hackers Cc: Akshay Joshi , Murtuza Zabuawala , Khushboo Vashi , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a114110125b82d20567edef27" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114110125b82d20567edef27 Content-Type: text/plain; charset="UTF-8" We've run into a number of unexpected issues with the v3.0 release that I think we need to resolve before moving forwards. For the time being, only patches critical to fix these issues should be committed. I'll try to look at 1, though I do have another deadline I need to meet. Akshay, can you look at 2 please? Fahar is already looking at 3. Khushboo, can you look at 4 please? Thanks all. 1) There is no longer a system tray in Gnome 3.26 and later, and thus the runtime won't initialise in Fedora 27 and later. We need an alternative for this, either a tray replacement that the RPM can depend on, or better yet, support whatever it is Gnome expect such apps to use these days. 2) Starting a second instance of the app bundle on Mac doesn't always open a new pgAdmin window as it should. It works fine in the debugger, or if you start the app with a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, but apparently his is a fresh installation. 4) On my Windows 7 machine, after running a backup I get no status window, and see the following in the logs: Traceback (most recent call last): File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi execute(self.server.app) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute application_iter = app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__ return self.wsgi_app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app response = self.handle_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app response = self.full_dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in full_dispatch_request rv = self.handle_user_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in handle_user_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in full_dispatch_request rv = self.dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view return func(*args, **kwargs) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index return make_response(response=BatchProcess.list()) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list details = desc.details(p.command, args) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details res += html.safe_str(cmd + self.cmd) AttributeError: 'BackupMessage' object has no attribute 'cmd' -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114110125b82d20567edef27 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
We've run into a number of unexpected issues with the = v3.0 release that I think we need to resolve before moving forwards. For th= e time being, only patches critical to fix these issues should be committed= .

I'll try to look at 1, though I do have another de= adline I need to meet.=C2=A0
Akshay, can you look at 2 please?
Fahar is already looking at 3.
Khushboo, can you look at = 4 please?

Thanks all.

1) = There is no longer a system tray in Gnome 3.26 and later, and thus the runt= ime won't initialise in Fedora 27 and later. We need an alternative for= this, either a tray replacement that the RPM can depend on, or better yet,= support whatever it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac does= n't always open a new pgAdmin window as it should. It works fine in the= debugger, or if you start the app with a command like: "/Applications= /pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you d= ouble-click the appbundle or use a command like "open /Applications/pg= Admin\ 4.app"

3) Fahar saw a crash on Windows= 7. I couldn't reproduce this on my copy, but apparently his is a fresh= installation.

4) On my Windows 7 machine, after r= unning a backup I get no status window, and see the following in the logs:<= /div>

Traceback (most recent call last):
=
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-pa= ckages\werkzeug\serving.py", line 209, in run_wsgi
=C2=A0 = =C2=A0 execute(self.server.app)
=C2=A0 File "C:\Program File= s (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line= 197, in execute
=C2=A0 =C2=A0 application_iter =3D app(environ, = start_response)
=C2=A0 File "C:\Program Files (x86)\pgAdmin = 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packag= es\flask\app.py", line 1985, in wsgi_app
=C2=A0 =C2=A0 respo= nse =3D self.handle_exception(e)
=C2=A0 File "C:\Program Fil= es (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1540,= in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, t= b)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib= \site-packages\flask\app.py", line 1982, in wsgi_app
=C2=A0 = =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File &quo= t;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&q= uot;, line 1614, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D se= lf.handle_user_exception(e)
=C2=A0 File "C:\Program Files (x= 86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in h= andle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, t= b)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib= \site-packages\flask\app.py", line 1612, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File &q= uot;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py= ", line 1598, in dispatch_request
=C2=A0 =C2=A0 return self.= view_functions[rule.endpoint](**req.view_args)
=C2=A0 File "= C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py&q= uot;, line 792, in decorated_view
=C2=A0 =C2=A0 return func(*args= , **kwargs)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3= \web\pgadmin\misc\bgprocess\__init__.py", line 62, in index
= =C2=A0 =C2=A0 return make_response(response=3DBatchProcess.list())
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bg= process\processes.py", line 584, in list
=C2=A0 =C2=A0 detai= ls =3D desc.details(p.command, args)
=C2=A0 File "C:\Program= Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line = 190, in details
=C2=A0 =C2=A0 res +=3D html.safe_str(cmd + self.c= md)
AttributeError: 'BackupMessage' object has no attribu= te 'cmd'



--
<= div class=3D"gmail_signature">Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company
--001a114110125b82d20567edef27--