MIME-Version: 1.0
References: 
 <CAFSMqn_dG6Ecn2z1to5jSFndyu0Y6QQ9A+RALo0Rr2YucYRogQ@mail.gmail.com>
 <CAFSMqn_n4kMF-BYHj7mVpR1oe5-ztZHV+XjVcM5Bc-Tj=srSBA@mail.gmail.com>
 <CA+OCxox1FEypF6y46DkSy3gZ77j7CBRa90kacMBF+qULNCcfcw@mail.gmail.com>
 <CAFSMqn--z1ro3eG0FRmLSyRYqa-CDb+H3PehMYbTd=i3jyBPtA@mail.gmail.com>
 <CA+OCxoz=pZjkffHQm5GiP=n1F66K9XKqk=LTt1eO-HP0jFPHkQ@mail.gmail.com>
 <CAFSMqn9So7MQ729EM0CD9CVXG6q=p77r0NvxUryFAtFqaunh-Q@mail.gmail.com>
 <CA+OCxozpBQUfmBMuZ8EXN2NRM4Y5pyCmY3SOq6AnbC5VeLG70A@mail.gmail.com>
 <CAM9w-_nUKgKScDtraiX+ALKDcO5GP+cA12yzNFa9PQ-CTJWs9w@mail.gmail.com>
 <CAFSMqn9qsjRzyW3zO5MD2DYfdiyhsXR5J1+4GPr4TnQuEaYYDQ@mail.gmail.com>
 <CAFSMqn87dZ_uKjk6UEwNd=wUM4NvWEc7d1Tqs5yj-MkaVK94Kw@mail.gmail.com>
 <CAM9w-_mRyY+Ljuy0Wvq5bUVXMnqO-Tv1RYeBjFgyerkkYg6efw@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_mRyY+Ljuy0Wvq5bUVXMnqO-Tv1RYeBjFgyerkkYg6efw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 25 Jun 2019 07:09:22 -0400
Message-ID: 
 <CA+OCxozJqTisLGsv8FvpgNAQu3rVQ8SgtPwdL5XVHYp1AweiYA@mail.gmail.com>
Subject: Re: [GSoC][Patch] Automatic Mode Detection V1
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: Yosry Muhammad <yosrym93@gmail.com>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000bd5267058c23f639"
Precedence: bulk

--000000000000bd5267058c23f639
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Jun 24, 2019 at 7:03 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

>
> - What else is missing from this patch to make it applicable ? I would
>> like to produce a release-ready patch if possible. If so, I can continue
>> working on the project on following patches, I just want to know what is
>> the minimum amount of work needed to make this patch release-ready
>> (especially that changes are being made in the master branch that require
>> me to re-edit parts of the code that I have written before to keep things
>> in-sync).
>>
> @Dave Page is the right person to answer this.
>

It needs:

- A code complete feature (or infrastructure/refactoring ready for a
feature), that is acceptable to us. Seems like this is 90% there for an
initial commit.
- Documentation updates.
- Tests for the new feature to ensure it works without needing manual
testing.
- To pass all existing tests (which may be modified if appropriate).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000bd5267058c23f639
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Mon, Jun 24, 2019 at 7:03 AM Aditya Toshniwal &l=
t;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshniwal@ent=
erprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-family:ve=
rdana,sans-serif"><br></div></div><div class=3D"gmail_quote"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>- What else is mi=
ssing from this patch to make it applicable ? I would like to produce a rel=
ease-ready patch if possible. If so, I can continue working on the project =
on following patches, I just want to know what is the minimum amount of wor=
k needed to make this patch release-ready (especially that changes are bein=
g made in the master branch that require me to re-edit parts of the code th=
at I have written before to keep things in-sync).</div></div></blockquote><=
div><span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">=
@Dave Page is the right person to answer this.</span>=C2=A0</div></div></di=
v></blockquote><div><br></div><div>It needs:</div><div><br></div><div>- A c=
ode complete feature (or infrastructure/refactoring ready for a feature), t=
hat is acceptable to us. Seems like this is 90% there for an initial commit=
.</div><div>- Documentation updates.</div><div>- Tests for the new feature =
to ensure it works without needing manual testing.</div><div>- To pass all =
existing tests (which may be modified if appropriate).</div><div>=C2=A0</di=
v></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog=
: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.=
blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"ht=
tp://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a=
><br>The Enterprise PostgreSQL Company<br></div></div>

--000000000000bd5267058c23f639--