Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ek9xU-0006Xs-Gv for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Feb 2018 14:47:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek9xT-00017I-Jj for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Feb 2018 14:47:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ek9xT-000178-Av for pgadmin-hackers@lists.postgresql.org; Fri, 09 Feb 2018 14:47:23 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ek9xP-0002Xc-L1 for pgadmin-hackers@postgresql.org; Fri, 09 Feb 2018 14:47:22 +0000 Received: by mail-wr0-x241.google.com with SMTP id u60so5767246wrb.8 for ; Fri, 09 Feb 2018 06:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OZkQLTcRyKHuKJEFe33A+nAfjpw0ErtuaidCHJyp4Io=; b=Oo72DamYw8PtuppKWARLvYck8Ihf+oLGXY59eCOEElMzL72x7OwYoNQt0M6UL6Sa1r 4M3o31y8L8IpLRDCrwbg+j4nbj6dBt1WPk5UDSseCIdeg9GEFpmR5dJYRyGmGqdKk7gg 9hOmSiswWYy9smE/JjoMbkwKnfaJbn/cOQnhGyorfSO5cdcILFHg3EtEanrbcmWEU9XC L1faS/6zvvRiUQ0xOcDMpXcrUIlLCcIWYNr7Vw93/x3d53611ihMP9D2Zi+esBgW18BJ KQLT9woDoPbI2HseMiy6hw1gbU2rX1O3FntxVm6T8glYYlwful73d6ntJxAxZn5kyTot 3SQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OZkQLTcRyKHuKJEFe33A+nAfjpw0ErtuaidCHJyp4Io=; b=YdPTMyoEZIHbYnjFr7+Y9TVAKFGDVJDHag4V7S1942U3LFGCbAjxgEcZwska2/vo55 IHH53bMVG0U9FlSX8qgjWJhvB+7lDmP1FUCirn4xi+G1Xl9JDh5W0d99vT8EPRvSS/jM evp3TPelVb12+t4tj4Dceyu3tjv8eTkriXWi93zF15KmKEa10EDcrlk8B6ht9EcSzW21 KGX08sZXKkaDf//b/ZR0RKGj3FRDqlVZDGsCxbEt23cPf6wf4s7+1xeJeVDyIHnG4KbO Z2d5SUIvCevn4WGFPOZO8bORpQGB6uHAkUtvXwmsgbI67nqdENdYUpZg7drFrDpveoxe fDkQ== X-Gm-Message-State: APf1xPAFSnR6BzQSkIxnTHEgVpOQ+fC9jw1IClPsg7B3PZDMR/9LhLDd wR9rPIx/MMZhVIeynhZJv5KmRvPueXRoL6l+MonMpQ== X-Google-Smtp-Source: AH8x224gUg+frElOhiyRT5QCuH34dEKQ1KUhNf+kEYSEIYuPv+BqqhhpOhh8ZIip2bK49Cz+QX5KPq5bczsPy9+lbN4= X-Received: by 10.223.151.53 with SMTP id r50mr2649404wrb.207.1518187638426; Fri, 09 Feb 2018 06:47:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.16.138 with HTTP; Fri, 9 Feb 2018 06:47:17 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 9 Feb 2018 14:47:17 +0000 Message-ID: Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045d5a60e41f900564c89a90" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045d5a60e41f900564c89a90 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello, > Attached you can find the fix for the current pronlem > > > On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: > >> Hi Joao, >> >> It looks like Jenkins has taken umbrage to this change, at least with >> Python 3.x. Can you take a look please? >> >> https://jenkins.pgadmin.org/ >> >> Thanks. >> >> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: >> >>> Thanks, patches applied. >>> >>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Hackers, >>>> This is quite a big patch in order to solve the problem with the >>>> Explain Plan. >>>> >>>> We sent 2 patches that have the following: >>>> *- update-javascript-packages.diff * >>>> Add package: >>>> is-docker to select a specific setting when running the Chrome >>>> tests in >>>> Docker >>>> >>>> Upgrade the version of: >>>> - babel-loader >>>> - extract-text-webpack-plugin >>>> - jasmine-core >>>> - jasmine-enzyme >>>> - moment >>>> *- explain-plan-greenplum.diff* >>>> Extract SQLEditor.execute and SQLEditor._poll into their own files >>>> and add test around them >>>> Extract SQLEditor backend functions that start executing query to >>>> their own files and add tests around it >>>> Move the Explain SQL from the front-end and now pass the Explain plan >>>> parameters as a JSON object in the start query call. >>>> Extract the compile_template_name into a function that can be used by >>>> the different places that try to select the version of the template and the >>>> server type >>>> >>>> >>>> Thanks >>>> Joao >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045d5a60e41f900564c89a90 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Perei= ra <jdealmeidapereira@pivotal.io> wrote:
Hello,
Attached you can find= the fix for the current pronlem


On Fri, Feb 9, 2018 at 7:2= 9 AM Dave Page <d= page@pgadmin.org> wrote:
Hi Joao,

It looks like Jenkins has taken u= mbrage to this change, at least with Python 3.x. Can you take a look please= ?


T= hanks.

On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, pat= ches applied.

On Fri,= Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <jdealmeidape= reira@pivotal.io> wrote:
Hi Hackers,
This is quite a big patch in order to solve = the problem with the Explain Plan.

We sent 2 patch= es that have the following:
-=C2=A0update-javascript-packages.= diff=C2=A0
=C2=A0 =C2=A0 Add package:
=C2=A0 =C2=A0 =C2=A0is-docker to select a specific setting when running th= e Chrome tests in
=C2=A0 =C2=A0 =C2=A0Docker

=
=C2=A0 =C2=A0 Upgrade the version of:
=C2=A0 =C2=A0 - babel-= loader
=C2=A0 =C2=A0 - extract-text-webpack-plugin
=C2= =A0 =C2=A0 - jasmine-core
=C2=A0 =C2=A0 - jasmine-enzyme
=C2=A0 =C2=A0 - moment
-=C2=A0explain-plan-greenplum.d= iff
=C2=A0 Extract SQLEditor.execute and SQLEditor._poll into= their own files and add test around them
=C2=A0 Extract SQLEdito= r backend functions that start executing query to their own files and add t= ests around it
=C2=A0 Move the Explain SQL from the front-end and= now pass the Explain plan parameters as a JSON object in the start query c= all.
=C2=A0 Extract the compile_template_name into a function tha= t can be used by the different places that try to select the version of the= template and the server type


Thank= s
Joao



-= -
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsn= ake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045d5a60e41f900564c89a90--