MIME-Version: 1.0
References: 
 <CA+36bxGWg9GD=4LY_tv82YVy=X+DMLts+DXK=JsWcLdxVtiNiQ@mail.gmail.com>
In-Reply-To: 
 <CA+36bxGWg9GD=4LY_tv82YVy=X+DMLts+DXK=JsWcLdxVtiNiQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 8 Oct 2024 14:04:02 +0100
Message-ID: 
 <CA+OCxozKmbRHDdtFVy0AfGtQy7FncUb8B+0VtZaxQaXpybnZtw@mail.gmail.com>
Subject: Re: Require suggestion for issue #8007
To: Pravesh Sharma <pravesh.sharma@enterprisedb.com>
Cc: pgadmin-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000002a40390623f6c6b6"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxozKmbRHDdtFVy0AfGtQy7FncUb8B%2B0VtZaxQaXpybnZtw%40mail.gmail.com>
Precedence: bulk

--0000000000002a40390623f6c6b6
Content-Type: text/plain; charset="UTF-8"

On Tue, 8 Oct 2024 at 13:56, Pravesh Sharma <pravesh.sharma@enterprisedb.com>
wrote:

> Hi Hackers,
>
> We have been working on issue #8007
> <https://github.com/pgadmin-org/pgadmin4/issues/8007>. After our
> analysis, we found that the length and scale of the argument's data type
> are not stored in the database server, making it difficult to fetch. In the
> debugger, pgAdmin typecasts the provided value to its data type when
> calling the function, which is causing the issue.
>
> If we typecast the value to a character without specifying the length, it
> is treated as a character (1) (character of length 1). For example, the
> output of SELECT 'pgadmin', 'pgadmin'::character; is different.
>
> There are two solutions we can consider:
>
>    1. Do not typecast if the data type is character.
>    2. Typecast to varchar when the data type is character.
>
> Please provide your suggestions which solution looks good to you.
>

Why not include the length in the cast? We know what the input string is,
so can't we just do the equivalent of:

'pgadmin'::character(7);

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

--0000000000002a40390623f6c6b6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 8 Oct 2024 at 13:56, Pravesh =
Sharma &lt;<a href=3D"mailto:pravesh.sharma@enterprisedb.com">pravesh.sharm=
a@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style=
:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr=
"><p style=3D"color:rgb(0,0,0)">Hi Hackers,</p><p style=3D"color:rgb(0,0,0)=
">We have been working on issue <a href=3D"https://github.com/pgadmin-org/p=
gadmin4/issues/8007" target=3D"_blank">#8007</a>. After our analysis, we fo=
und that the length and scale of the argument&#39;s data type are not store=
d in the database server, making it difficult to fetch. In the debugger, pg=
Admin typecasts the provided value to its data type when calling the functi=
on, which is causing the issue.</p><p style=3D"color:rgb(0,0,0)">If we type=
cast the value to a character without specifying the length, it is treated =
as a character (1) (character of length 1). For example, the output of<span=
>=C2=A0</span><code>SELECT &#39;pgadmin&#39;, &#39;pgadmin&#39;::character;=
</code><span>=C2=A0</span>is different.</p><p style=3D"color:rgb(0,0,0)">Th=
ere are two solutions we can consider:</p><ol style=3D"color:rgb(0,0,0)"><l=
i>Do not typecast if the data type is character.</li><li>Typecast to<span>=
=C2=A0</span><code>varchar</code><span>=C2=A0</span>when the data type is c=
haracter.</li></ol><div><font color=3D"#000000"><span>Please provide your s=
uggestions which solution looks good to you.</span></font></div></div></blo=
ckquote><div><br></div><div>Why not include the length in the cast? We know=
 what the input string is, so can&#39;t we just do the equivalent of:</div>=
<div><br></div><div><span style=3D"color:rgb(0,0,0);font-family:monospace">=
&#39;pgadmin&#39;::character(7);</span><br></div><div>=C2=A0</div></div><sp=
an class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D=
"gmail_signature"><div dir=3D"ltr">Dave Page<div>pgAdmin: <a href=3D"https:=
//www.pgadmin.org" target=3D"_blank">https://www.pgadmin.org</a></div><div>=
PostgreSQL: <a href=3D"https://www.postgresql.org" target=3D"_blank">https:=
//www.postgresql.org</a><br><div>EDB:=C2=A0<a href=3D"https://www.enterpris=
edb.com" target=3D"_blank">https://www.enterprisedb.com</a></div><div></div=
><div><br></div></div></div></div></div>

--0000000000002a40390623f6c6b6--