Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hie25-0000Zr-Fk for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 12:06:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hie24-000281-8j for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 12:06:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hie23-00027l-G0 for pgadmin-hackers@lists.postgresql.org; Wed, 03 Jul 2019 12:06:40 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hie20-0003h4-8v for pgadmin-hackers@postgresql.org; Wed, 03 Jul 2019 12:06:38 +0000 Received: by mail-wr1-x444.google.com with SMTP id f9so2484955wre.12 for ; Wed, 03 Jul 2019 05:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aZcCAbwNFjXvKYUzICYkSs7AsIVnOCdj99hbybHsp/U=; b=Jfx78hC+XxzGv/rvlm+Ekmu8P3XjBTFI/P8jH0C/4Jjmq1PbNvBcJ3uae+qqZUpgXk sKhgUFV91dvRkOJID8xfTaTZvMEPHhE+7C9REoJToRzaQUu5KmXpHaQCEBNu4XgmXvi7 mWD7V35HzchHjIltitylyzYEDBWuITNL3CO6x9MKo98WWQspI32CMLC/9OtBeuqsMaeF +Fn4ALKzzXA9FYaTM95fXA+gTpv4YFI+cI8HVfmp0kN9IEojjklTCQgNGc3EQ6YRsZ/6 daxE7t52+TQxn8e87/ZIQgPEsQ8SThkD70LiDEPNsxzvgM5k9CUEoczV0sfIYSOd/2g5 a9cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aZcCAbwNFjXvKYUzICYkSs7AsIVnOCdj99hbybHsp/U=; b=GOKCVU0Dfp+Hh1TtBCubMfW2cOyQp51m3QF/LWLJYPgYBJUfUl+XkhMT6SunTs4GEy g5v+l44crFtjFNR5sPkvhvNEZw3lgbIiwQCSpxez4+0ScxLMQy9JAFX+NBbbxvKsrcgT pmFSXt4EsdWOas330h+4cxM4XZfzf6l7azlqE2H0WMSTE2T5coDxyQ/A3HssFvADCkxJ wXDrAtcx9NTpBOjeQZoVNtV3L2d2tm84QqOpWrhjk1LbdNUjpZ+q/7tFnGtkRzTdxCv3 pFUG70VQwgQYL8aFyiScoYgtUA7gTdUpNLXaBQfoufU76BTN0ePYfnhVeUYqt1IJtjMV 3OXQ== X-Gm-Message-State: APjAAAUpu1Do8yfuF8ss1oyCewopwHq1AlvKZptQfe/gDmsl/37fH0e8 hfy5A4eRKqhNv2N8ffH68BIKLjsqJ6tO2jLTzwtXXA== X-Google-Smtp-Source: APXvYqz6KEggmfnxjodcHGLJ5h8wBlzvXn+2f8WeH6drmUaIjKFLavI9XDYOCmgz7bcSMv/cOvrQn0lJmPd2F+w9L/Q= X-Received: by 2002:a5d:4086:: with SMTP id o6mr29816002wrp.185.1562155593774; Wed, 03 Jul 2019 05:06:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 3 Jul 2019 13:06:20 +0100 Message-ID: Subject: Re: RE-SQL tests for Roles & Resource Group nodes To: Akshay Joshi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000404d8a058cc5b173" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000404d8a058cc5b173 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi wrote: > Hi Murtuza > > I have tested the patch and I think below string should be modified: > Server(Type: #ppas) is not supported for the Resource Groups module - > Skipped > Server version(120000) is not supported for the Resource Groups module - > Skipped > > It misleads, that server type 'ppas' is not supported for the Resource > Group, it should be changed to "Resource groups are not supported by PG - > Skipped". Similarly for version string should be ''Resource groups are not > supported by PPAS server less/greater than " > Agreed. > >> Please note that our framework considers test cases from all the modules >> as one single test case, If we need module wise detailed summary report for >> the reverse engineered SQL tests then we may have to change the framework. >> > We're just treating all the re-sql tests as one test in the higher-level suite. Maybe we'd want to change that in the future, but I think it's fine for now. > >> >> Regards, >> Murtuza >> >> >> On Tue, Jul 2, 2019 at 5:52 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> ++ Attaching patch >>>> >>>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find the updated patch, >>>>> >>>>> - Added a mechanism to check for supported minimum/maximum version and >>>>> a server type in the framework. >>>>> >>>> >>> There's still a problem with this I'm afraid - it says in the summary >>> that the re_sql test cases were all skipped, which is not the case. I think >>> we should just skip the irrelevant tests in the re_sql module, but not mark >>> the entire module as being skipped: >>> >> >>> =============Running the test cases for 'Regression - PG 11'============= >>> >>> runTest >>> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >>> >>> Reverse Engineered SQL Test Cases >>> >>> >>> Create IMPLICIT Cast >>> >>> Alter IMPLICIT Cast >>> >>> Drop IMPLICIT Cast >>> >>> Create EXPLICIT Cast >>> >>> Alter EXPLICIT Cast >>> >>> Drop EXPLICIT Cast >>> >>> ... skipped 'Server(Type: #ppas) is not supported for the Resource >>> Groups module' >>> >>> >>> ---------------------------------------------------------------------- >>> >>> Ran 1 test in 0.480s >>> >>> >>> OK (skipped=1) >>> >>> >>> ====================================================================== >>> >>> Test Result Summary >>> >>> ====================================================================== >>> >>> >>> Regression - PG 11: >>> >>> >>> 0 tests passed >>> >>> 0 tests failed >>> >>> 1 test skipped: >>> >>> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >>> >>> >>> ====================================================================== >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000404d8a058cc5b173 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
=
Hi=C2=A0Murtuza

I have tested the patch= and I think below string should be modified:
Server(Type: #= ppas) is not supported for the Resource Groups module - Skipped
Se= rver version(120000) is not supported for the Resource Groups module - Skip= ped

It misleads, that server type 'ppas= 9; is not supported for the Resource Group, it should be changed to "R= esource groups are not supported by PG - Skipped". Similarly for versi= on string should be ''Resource groups are not supported by PPAS ser= ver less/greater than <server version>"
=

Agreed.
=C2=A0

Please note that our f= ramework considers test cases from all the modules as one single test case,= If we need module wise detailed=C2=A0summary report for the reverse engine= ered SQL tests then we may have to change the framework.
<= /blockquote>

We're just treating = all the re-sql tests as one test in the higher-level suite. Maybe we'd = want to change that in the future, but I think it's fine for now.
=
=C2=A0


= Regards,
Murtuza


On Tue, Jul 2, 2019 at 5:52 PM Dave Page <dpage@pgadmin.org> w= rote:
Hi

On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <murtuza.z= abuawala@enterprisedb.com> wrote:
++ Attaching patch

On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <murtuza.zabuawala@ent= erprisedb.com> wrote:
Hi Dave,

Please find the updated patch,<= br>
=
- Added a mechanism to check for supported minimum/maximum version and a s= erver type in the framework.

There's still a problem with this I'm = afraid - it says in the summary that the re_sql test cases were all skipped= , which is not the case. I think we should just skip the irrelevant tests i= n the re_sql module, but not mark the entire module as being skipped:
<= /div>
<= div dir=3D"ltr">

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases = for 'Regression - PG 11'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

runTest (regression.re_sql.tests.test_resql.ReverseEngineeredS= QLTestCases)

Reverse Engineered SQL Test Cases


Create IMPLICIT Cast

Alter IMPLICIT Cast

Drop IMPLICIT Cast

Create EXPLICIT Cast

Alter EXPLICIT Cast

Drop EXPLICIT Cast

=C2=A0..= . skipped 'Server(Type: #ppas) is not supported for the Resource Groups= module'


--------------------------------------------------------------= --------

Ran 1 test in 0.480s


OK (skipped=3D1)


=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

Test Result Summary

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=


Regression - PG 11:


0 tests passed

0 tests failed

1 test skipped:

ReverseEngineeredSQLTestCases (Reverse Engineered SQL = Test Cases)


Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Ar= chitect
EnterpriseDB So= ftware India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000404d8a058cc5b173--